Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032268Openbravo ERP09. Financial managementpublic2016-02-17 19:512016-04-08 11:00
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary0032268: Wrong payment status when unmatching bankstatement line manually matched against an invoice
DescriptionWrong payment status when unmatching bankstatement line manually matched against an invoice
Steps To Reproduce0. Configure "Bank" financial account to use "Advanced Matching algorithm"
1. Access Financial Account, create Bank Statement record and add line with amount in =100. Process bank statement
2. Register Sales invoice with any line and total invoice amount = 100
3. Come back to Financial Account and run "Match Statement" process
4. Select "Cancel" option to not execute automatic matching
5. Run "add transaction" process by pressing + button
6. Create payment by pressing "+" button in payment's selector and select your invoice. Process Done and Done to finish with matching process
7. Filter in the grid by "matched=yes" records and unmatch record. Press OK to save reconciliation
8. Realize that transaction has correct status "deposited not cleared"
9. Navigate to related payment in and realize that status is "payment cleared" instead of "deposited not cleared"

NOTE: I followed same steps in an standard MP30.3 version and both payment and transaction has status "deposited not cleared"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00322983.0PR16Q1 closed AtulOpenbravo Wrong payment status when unmatching bankstatement line manually matched against an invoice 
depends on backport 00322993.0PR15Q4.4 closed AtulOpenbravo Wrong payment status when unmatching bankstatement line manually matched against an invoice 
depends on backport 00323003.0PR15Q3.6 closed AtulOpenbravo Wrong payment status when unmatching bankstatement line manually matched against an invoice 
caused by feature request 00293903.0PR14Q4 closed Sandrahuguet Reconciliation refactor project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-17 19:51maiteNew Issue
2016-02-17 19:51maiteAssigned To => Triage Finance
2016-02-17 19:51maiteResolution time => 1456268400
2016-02-17 19:51maiteIssue Monitored: networkb
2016-02-17 19:52maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11156#r11156
2016-02-22 10:26AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2016-02-22 10:26AtulOpenbravoStatusnew => scheduled
2016-02-22 10:39AtulOpenbravoRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2016-02-22 10:39AtulOpenbravoRegression level => Production - Confirmed Stable
2016-02-22 10:39AtulOpenbravoResolution time1456268400 => 1411423200
2016-02-22 10:41AtulOpenbravoRelationship addedcaused by 0029390
2016-02-22 10:41AtulOpenbravoStatusscheduled => acknowledged
2016-02-22 10:45vmromanosProjectModules => Openbravo ERP
2016-02-22 10:46vmromanosModules => Core
2016-02-22 10:46vmromanosTriggers an Emergency Pack => No
2016-02-22 10:46vmromanosCategoryAdvanced Matching Algorithm => 09. Financial management
2016-02-22 10:46AtulOpenbravoStatusacknowledged => scheduled
2016-02-22 10:47AtulOpenbravoResolution time1411423200 =>
2016-02-22 10:47AtulOpenbravoRegression date => 2014-09-23
2016-02-22 10:52AtulOpenbravoRegression introduced in release => 3.0PR14Q4
2016-02-22 11:13AtulOpenbravoNote Added: 0084399
2016-02-22 14:08psanjuanNote Added: 0084405
2016-02-22 14:27psanjuanNote Edited: 0084399bug_revision_view_page.php?bugnote_id=0084399#r11193
2016-02-22 14:33psanjuanNote Edited: 0084399bug_revision_view_page.php?bugnote_id=0084399#r11194
2016-02-22 14:40psanjuanNote Edited: 0084399bug_revision_view_page.php?bugnote_id=0084399#r11195
2016-02-22 14:42psanjuanNote Added: 0084407
2016-02-22 16:45vmromanosResolution time => 1456268400
2016-02-22 18:00vmromanosNote Added: 0084410
2016-02-23 14:00hgbotCheckin
2016-02-23 14:00hgbotNote Added: 0084422
2016-02-23 14:00hgbotStatusscheduled => resolved
2016-02-23 14:00hgbotResolutionopen => fixed
2016-02-23 14:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/143d5c8089260d63d8f645b73c5cf43bf1216828 [^]
2016-02-23 14:02vmromanosReview Assigned To => vmromanos
2016-02-23 14:02vmromanosNote Added: 0084429
2016-02-23 14:02vmromanosStatusresolved => closed
2016-03-03 18:53aferrazNote Added: 0084697
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085162
2016-04-08 11:00hgbotCheckin
2016-04-08 11:00hgbotNote Added: 0085527

Notes
(0084399)
AtulOpenbravo   
2016-02-22 11:13   
(edited on: 2016-02-22 14:40)
Test Plan
- Configure "Bank" financial account to use "Advanced Matching algorithm"
- Access Financial Account, create Bank Statement record and add line with amount in =100. Process bank statement
- Register Sales invoice with any line and total invoice amount = 100
- Come back to Financial Account and run "Match Statement" process
- Select "Cancel" option to not execute automatic matching
- Remove the filter.
- Run "add transaction" process by pressing + button
- Create payment by pressing "+" button in payment's selector and select your invoice. Process Done and Done to finish with matching process
- Filter in the grid by "matched=yes" records and unmatch record. Press OK to save reconciliation
- Check that financial account transaction has correct status "deposited not cleared".
- Go to related payment in and check that status is "deposited not cleared" which is correct.
- Match the payment and the statement line and check that payment status changes to "Payment Cleared" same as Financial Account Transaction.

Repeat same flow for purchase out, therefore Status is "Withdrawn not Cleared" for both payment out created and financial account transaction.
(0084405)
psanjuan   
2016-02-22 14:08   
Issue verified.
(0084407)
psanjuan   
2016-02-22 14:42   
Test plan above verified.

Issue can be code reviewed and closed.
(0084410)
vmromanos   
2016-02-22 18:00   
Verified also with the new "Unmatch Selected" process
(0084422)
hgbot   
2016-02-23 14:00   
Repository: erp/devel/pi
Changeset: 143d5c8089260d63d8f645b73c5cf43bf1216828
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Feb 22 15:33:27 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/143d5c8089260d63d8f645b73c5cf43bf1216828 [^]

Fixes Issue 32268: Wrong payment status when unmatching bankstatement line
manually matched against an invoice

Incase a finTransaction is unmatched which has finPayment,status of finPayment
is also updated accordingly as per isReceipt flag

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/APRM_MatchingUtility.java
---
(0084429)
vmromanos   
2016-02-23 14:02   
Code review + testing OK
(0084697)
aferraz   
2016-03-03 18:53   
Tests in TestLink:

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10003 [^]

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10004 [^]
(0085162)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085527)
hgbot   
2016-04-08 11:00   
Repository: tools/automation/int
Changeset: a0e4097727b38183d7209a473e0e709f9b5bfea5
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Mar 09 19:05:46 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/a0e4097727b38183d7209a473e0e709f9b5bfea5 [^]

Related to issue 32268: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/data/financial/receivablespayables/transactions/AddPaymentPopUpData.java
M src-test/com/openbravo/test/integration/erp/data/financial/receivablespayables/transactions/bankstatement/BankStatementHeaderData.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/FormInputFieldFactory.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/APRIn_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/APROut_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/build.xml
A src-test/com/openbravo/test/integration/erp/modules/client/application/gui/searchitems/FinaccTransactionSearchItem.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/APRRegression32268In.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/APRRegression32268Out.java
---