Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032264Retail ModulesWeb POSpublic2016-02-17 17:322016-06-03 14:53
Reporteradrianromero 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032264: Taxes at document level are not properly calculated in some cases
DescriptionIn the case of price including taxes and taxes at document level there are cases where taxes are not properly calculated:

For example:
1 x 6.50
1 x 6.50
1 x 5.90
1 x 5.90
Total 24.80

If all products have a tax of 20%, POS calculates taxable amount 20.68 and tax amount 4.12

This is wrong, the expected values are: taxable amount 20.67 and tax amount 4.13
Steps To ReproduceIn Description
Proposed SolutionAttached export file fixes the calculation at document level but only for orders. It does not fix cashup taxes calculation.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0032996RR16Q2 closed adrianromero Retail Modules Taxes at document level are not properly calculated in some cases 
related to design defect 0032265 closed aferraz Openbravo ERP [SER QA 1434] Taxes at document level are not properly calculated in some cases 
related to defect 0033611 closed migueldejuana Retail Modules wrong "net unit price" with tax include taxes and price precision 6 
causes defect 0035837 closed jorge-garcia Retail Modules Add 2 different products quickly using not including taxes price list breaks the application 
Attached Filespng Captura de pantalla de 2016-02-17 17:34:32.png (97,970) 2016-02-17 17:38
https://issues.openbravo.com/file_download.php?file_id=9076&type=bug
png

diff issue32264taxesdocleve.diff (22,318) 2016-03-14 09:28
https://issues.openbravo.com/file_download.php?file_id=9152&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-17 17:32adrianromeroNew Issue
2016-02-17 17:32adrianromeroAssigned To => adrianromero
2016-02-17 17:32adrianromeroTriggers an Emergency Pack => No
2016-02-17 17:36adrianromeroRelationship addedrelated to 0032265
2016-02-17 17:38adrianromeroFile Added: Captura de pantalla de 2016-02-17 17:34:32.png
2016-03-14 09:28adrianromeroFile Added: issue32264taxesdocleve.diff
2016-03-14 09:29adrianromeroProposed Solution updated
2016-05-18 09:13hgbotCheckin
2016-05-18 09:13hgbotNote Added: 0086513
2016-05-18 09:13hgbotStatusnew => resolved
2016-05-18 09:13hgbotResolutionopen => fixed
2016-05-18 09:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4913e4f46904b72df39b08f1da7c1f18cbaf5d00 [^]
2016-05-18 09:13hgbotCheckin
2016-05-18 09:13hgbotNote Added: 0086514
2016-05-18 09:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4913e4f46904b72df39b08f1da7c1f18cbaf5d00 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cc8253e62126a41ea457138df479440ccdec8de5 [^]
2016-05-18 09:13hgbotCheckin
2016-05-18 09:13hgbotNote Added: 0086515
2016-05-18 09:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cc8253e62126a41ea457138df479440ccdec8de5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ec493ec95bc15f8139d92de0a50986c5c8f045f [^]
2016-05-18 09:13hgbotCheckin
2016-05-18 09:13hgbotNote Added: 0086516
2016-05-18 09:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ec493ec95bc15f8139d92de0a50986c5c8f045f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98fe075ba7222439c42f598ae14cc06df258ebd3 [^]
2016-05-18 09:13hgbotCheckin
2016-05-18 09:13hgbotNote Added: 0086517
2016-05-18 09:14hgbotCheckin
2016-05-18 09:14hgbotNote Added: 0086518
2016-05-18 09:14hgbotCheckin
2016-05-18 09:14hgbotNote Added: 0086519
2016-05-18 09:14hgbotCheckin
2016-05-18 09:14hgbotNote Added: 0086520
2016-05-18 09:14hgbotCheckin
2016-05-18 09:14hgbotNote Added: 0086521
2016-05-18 09:14hgbotCheckin
2016-05-18 09:14hgbotNote Added: 0086522
2016-05-18 09:16adrianromeroReview Assigned To => marvintm
2016-05-19 10:45OrekariaStatusresolved => new
2016-05-19 10:45OrekariaResolutionfixed => open
2016-05-19 10:45OrekariaStatusnew => scheduled
2016-05-19 10:45OrekariaStatusscheduled => resolved
2016-05-19 10:45OrekariaResolutionopen => fixed
2016-06-03 14:53marvintmStatusresolved => closed
2016-06-03 14:53marvintmFixed in Version => RR16Q2
2016-08-18 14:20migueldejuanaRelationship addedrelated to 0033611
2017-04-26 16:41jorge-garciaRelationship addedcauses 0035837

Notes
(0086513)
hgbot   
2016-05-18 09:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4913e4f46904b72df39b08f1da7c1f18cbaf5d00
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 18 18:50:06 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4913e4f46904b72df39b08f1da7c1f18cbaf5d00 [^]

Fixes issue 0032264: Taxes at document level are not properly calculated in some cases

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086514)
hgbot   
2016-05-18 09:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: cc8253e62126a41ea457138df479440ccdec8de5
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 25 09:48:37 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/cc8253e62126a41ea457138df479440ccdec8de5 [^]

Fixes issue 0032264: Taxes at document level are not properly calculated in some cases
Implementing taxes at document adjustments in price not including taxes

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0086515)
hgbot   
2016-05-18 09:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5ec493ec95bc15f8139d92de0a50986c5c8f045f
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 25 13:01:07 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5ec493ec95bc15f8139d92de0a50986c5c8f045f [^]

Fixes issue 0032264: Taxes at document level are not properly calculated in some cases
* Complete implementation of adjustments in taxes not including taxes

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0086516)
hgbot   
2016-05-18 09:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 98fe075ba7222439c42f598ae14cc06df258ebd3
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu May 12 13:31:50 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98fe075ba7222439c42f598ae14cc06df258ebd3 [^]

Fixes issue 0032264: Taxes at document level are not properly calculated in some cases
* Adjust cashup taxes to match that net + taxes = gross for returns and for sales

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0086517)
hgbot   
2016-05-18 09:13   
Repository: tools/automation/pi-mobile
Changeset: b056bb7f4f009076f518df99a786eb2cbac06abf
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Feb 19 15:45:34 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b056bb7f4f009076f518df99a786eb2cbac06abf [^]

Related to issue 0032264: Taxes at document level are not properly calculated in some cases
* Adjustment of previous taxes amounts
* New tests

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/APIs/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupRecoverLastCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithInitialAmount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithSaleAndReturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I29153_CashupWithSaleAndReturnRetrieveFromServer.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifySimpleReturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/VerifiedReturnProductsNotInAssortment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleWithBOMTaxes.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes20.java
---
(0086518)
hgbot   
2016-05-18 09:14   
Repository: tools/automation/pi-mobile
Changeset: acf8502aec34f04da4e7c05fdfb17fb2e54c22e1
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 25 10:03:48 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/acf8502aec34f04da4e7c05fdfb17fb2e54c22e1 [^]

Related to issue 0032264: Taxes at document level are not properly calculated in some cases

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes20.java
---
(0086519)
hgbot   
2016-05-18 09:14   
Repository: tools/automation/pi-mobile
Changeset: 9320833bc997e8bddd193753aa86d63c36cfbcaa
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 11 16:56:15 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9320833bc997e8bddd193753aa86d63c36cfbcaa [^]

Related to issue 0032264: Taxes at document level are not properly calculated in some cases
* Fixes taxes verifications to the appropiate values

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/I32217_MPLDiscountOnlyForOneCustomerAndDifferentTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/MPLDiscountsWithPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleWithBOMTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
---
(0086520)
hgbot   
2016-05-18 09:14   
Repository: tools/automation/pi-mobile
Changeset: 4e416d9593da865044c784edba91c75d5359614e
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu May 12 13:33:31 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4e416d9593da865044c784edba91c75d5359614e [^]

Related to issue 0032264: Taxes at document level are not properly calculated in some cases
* Adjust cashup values for taxes

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithOverpayment.java
---
(0086521)
hgbot   
2016-05-18 09:14   
Repository: tools/automation/pi-mobile
Changeset: fb5f10486e3f13ada3b554a2a1351ffef52be8c5
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri May 13 09:20:35 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fb5f10486e3f13ada3b554a2a1351ffef52be8c5 [^]

Related to issue 0032264: Taxes at document level are not properly calculated in some cases
* A new rounding adjustment in test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
---
(0086522)
hgbot   
2016-05-18 09:14   
Repository: tools/automation/pi-mobile
Changeset: f39bcd595134665b24c3f1027a6478a1fc035b9e
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue May 17 14:07:56 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f39bcd595134665b24c3f1027a6478a1fc035b9e [^]

Related to issue 0032264: Taxes at document level are not properly calculated in some cases
* Adjusting test for taxes at document level that has differences if calculated at line level

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxesAtDocLevel.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes20.java
---