Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032260Openbravo ERPA. Platformpublic2016-02-17 14:292016-08-11 18:40
Reporterinigosanchez 
Assigned ToNaroaIriarte 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032260: Editing a record in grid view with a few visible columns doesnt work properly
DescriptionEditing a record in grid view with a few visible columns doesnt work properly. If there is a visible selector, for example business partner selector, the behaviour is correct.
Steps To Reproduce1.- Login as F&B International Admin.
2.- Go to Sales Order.
3.- Clear all filters.
3.- Make visible only the following columns:
3.1.- Organization.
3.2.- Document No.
4.- Click on pencil button for edit any record in grid view.
5.- Click on pencil button of another record.
5.1.- Check that previous record is opened yet. This behaviour is not correct.
5.2.- New record is opened too. It is not possible to close these records.
6.- Now make visible "Business Partner" selector.
7.- Click on pencil button for edit any record in grid view.
8.- Click on pencil button of another record.
8.1.- Check that previous record is closed. This works properly.
8.2.- New record is ready for editing in grid view.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033452 acknowledged Triage Platform Base refresh grid can cause edit icons to disappear 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-17 14:29inigosanchezNew Issue
2016-02-17 14:29inigosanchezAssigned To => platform
2016-02-17 14:29inigosanchezOBNetwork customer => No
2016-02-17 14:29inigosanchezModules => Core
2016-02-17 14:29inigosanchezTriggers an Emergency Pack => No
2016-02-25 14:27alostalePrioritylow => high
2016-02-25 14:27alostaleSeverityminor => major
2016-02-25 14:27alostaleStatusnew => acknowledged
2016-06-23 10:10NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-07-06 11:08NaroaIriarteNote Added: 0088231
2016-07-07 09:10hgbotCheckin
2016-07-07 09:10hgbotNote Added: 0088257
2016-07-07 09:10hgbotStatusacknowledged => resolved
2016-07-07 09:10hgbotResolutionopen => fixed
2016-07-07 09:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b1f17fd0957b749b078ffcb82d94dfe846f06173 [^]
2016-07-07 09:13NaroaIriarteReview Assigned To => alostale
2016-07-07 09:13NaroaIriarteIssue Monitored: NaroaIriarte
2016-07-07 09:14NaroaIriarteIssue End Monitor: NaroaIriarte
2016-07-07 09:15NaroaIriarteIssue Monitored: NaroaIriarte
2016-07-07 09:15NaroaIriarteIssue End Monitor: NaroaIriarte
2016-07-08 09:08alostaleNote Added: 0088317
2016-07-08 09:08alostaleStatusresolved => closed
2016-07-08 09:08alostaleFixed in Version => 3.0PR16Q4
2016-07-08 09:13alostaleRelationship addedrelated to 0033452
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088995

Notes
(0088231)
NaroaIriarte   
2016-07-06 11:08   
This happens only when every column of the record are read only.
But if one of those columns is a selector, even if it is read only, it works fine.
(0088257)
hgbot   
2016-07-07 09:10   
Repository: erp/devel/pi
Changeset: b1f17fd0957b749b078ffcb82d94dfe846f06173
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Jul 06 17:52:48 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b1f17fd0957b749b078ffcb82d94dfe846f06173 [^]

Fixed issue 32260: Editing records in grid view was not working properly.

Editing in grid view was not working properly when all the fields of the record were readonly.
The problem was in "ob-view-grid.js" in the "startEditing" function. In this function, the focused field is set, but when every field is readonly there was not setting the value, so it was undefined. This was causing the failure.

To fix this a new condition has been added. Now, it is checked if the colNum is undefined and if the new function "isThereAnyEditableField" returns false. If these conditions are met, it means that the focus is not set yet and that there aren't any editable fields. Because if there were any editable fields, not setting the focus at that point would not be a problem, smartclient puts the focus there.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0088317)
alostale   
2016-07-08 09:08   
Code reviewed + tested
(0088995)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test