0032256: oracle shows error in log when setting an AD column to not null

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0032256

Openbravo ERP

Y. DBSourceManager

public

2016-02-16 07:42

2016-02-17 13:17

Reporter

alostale

Assigned To

platform

Priority

immediate

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

open

Platform

OS Version

Product Version

Target Version

3.0PR16Q1

Fixed in Version

Merge Request Status

Review Assigned To

AugustoMauch

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2015-04-28

Regression introduced in release

3.0PR15Q3

Regression introduced by commit

http://code.openbravo.com/erp/devel/pi/rev/f8c18a0c0a00d9dc01482bb1ca5b72d2c68c1fe3 [^]

Triggers an Emergency Pack

Summary

0032256: oracle shows error in log when setting an AD column to not null

Description

model change changing char(1) boolean from nullable to not null and looks like the incremental update.db processing that change has some issues:
     [java] 40817 INFO - Disabling triggers
     [java] 51348 WARN - SQL Command failed with: ORA-01451: column to be modified to NULL cannot be modified to NULL
     [java]
     [java] 51365 WARN - -- END
     [java] ALTER TABLE OBPOS_PRINT_TEMPLATE MODIFY ISPDF CHAR(1) NULL
     [java] 51740 INFO - Executed 837 SQL command(s) with 1 error(s)

https://ci.openbravo.com/job/ret-inc-oracle/3585/console [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ab2b38250f44 [^]

Steps To Reproduce

There are different ways to reproduce, all of them in an Oracle instance.

1.1. Update an Oracle instance from a previous version to https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ab2b38250f44 [^]
   -> Check in log WARN message

2.1 Emulate this situation in by executing in DB:
   ALTER TABLE AD_WINDOW MODIFY (ISACTIVE NULL); --next update will reset not null contraint
   update ad_module set status='I' where ad_module_id = 'A918E3331C404B889D69AA9BFAFB23AC'; --pick a module and set it as rebuild required
   select ad_db_modified('Y') from dual; --forget local db changes
2.2 Login as System Admin
2.3 Open Module Management window and rebuild
   -> ERROR: Build is marked as having warnings

Proposed Solution

Additional Information