Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032240Openbravo ERPA. Platformpublic2016-02-15 18:522017-02-15 09:11
Reportervmromanos 
Assigned Toinigosanchez 
PriorityimmediateSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2015-11-23
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/9f99e60411fcba42b78da7923bca7465ae71aa09 [^]
Triggers an Emergency PackNo
Summary0032240: Read only logic doesn't work on some columns in grid view
DescriptionThe read only doesn't apply properly when a display logic or read only logic are applied in grid view. It is not take into account read only value.

This is a regression that affects Main and PI (Introduced by Grid Display Logic as Read Only project)
Steps To ReproduceAs Openbravo Admin go to Financial Account window
Select "Cuenta de Banco" and go to Transaction tab in grid mode
Clear the filters so the grid shows all the records.
Edit any processed record.
Verify Currency and Status columns can be edited. However these fields are set as Read Only in the Application Dictionary.
Open this record in form view and verify the Currency field is properly set as read only
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00322473.0PR16Q1 closed inigosanchez Read only logic doesn't work on some columns in grid view 
caused by design defect 0024319 closed inigosanchez Grid mode should hide field content as per display logic rule 
related to defect 0032147 closed nonofrancisco Payment field and Transaction Type fields of Financial Account Transaction tab should be read only once the record is processed 
Attached Filespng readonly_currency_status.png (49,540) 2016-02-15 18:52
https://issues.openbravo.com/file_download.php?file_id=9060&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-02-15 18:52vmromanosNew Issue
2016-02-15 18:52vmromanosAssigned To => platform
2016-02-15 18:52vmromanosFile Added: readonly_currency_status.png
2016-02-15 18:52vmromanosModules => Core
2016-02-15 18:52vmromanosTriggers an Emergency Pack => No
2016-02-15 18:54vmromanosRelationship addedrelated to 0032147
2016-02-16 15:02alostaleRegression level => Packaging and release
2016-02-16 15:02alostalePrioritynormal => immediate
2016-02-16 15:03alostaleStatusnew => acknowledged
2016-02-16 15:04alostaleStatusacknowledged => scheduled
2016-02-16 17:21inigosanchezAssigned Toplatform => inigosanchez
2016-02-23 13:27inigosanchezRegression date => 2015-11-23
2016-02-23 13:27inigosanchezRegression introduced in release => pi
2016-02-23 13:27inigosanchezRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/9f99e60411fcba42b78da7923bca7465ae71aa09 [^]
2016-02-24 09:45inigosanchezRelationship addedcaused by 0024319
2016-02-25 00:41inigosanchezDescription Updatedbug_revision_view_page.php?rev_id=11220#r11220
2016-02-25 00:43inigosanchezReview Assigned To => alostale
2016-02-25 00:47hgbotCheckin
2016-02-25 00:47hgbotNote Added: 0084477
2016-02-25 00:47hgbotStatusscheduled => resolved
2016-02-25 00:47hgbotResolutionopen => fixed
2016-02-25 00:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/50d727a061775e9b8522c7df5f274732c9414583 [^]
2016-02-25 00:48inigosanchezNote Added: 0084478
2016-02-26 09:17alostaleNote Added: 0084541
2016-02-26 09:17alostaleStatusresolved => closed
2016-02-26 09:17alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085167
2016-10-19 16:10hgbotCheckin
2016-10-19 16:10hgbotNote Added: 0090698
2016-10-19 16:10hgbotStatusclosed => resolved
2016-10-19 16:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/50d727a061775e9b8522c7df5f274732c9414583 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5066477d172a9a04149306642e088fdd41b6416c [^]
2016-10-19 16:59guilleaerNote Deleted: 0090698
2016-10-19 17:01guilleaerNote Added: 0090700
2016-10-19 17:01guilleaerStatusresolved => closed
2017-02-15 09:11hgbotCheckin
2017-02-15 09:11hgbotNote Added: 0094343

Notes
(0084477)
hgbot   
2016-02-25 00:47   
Repository: erp/devel/pi
Changeset: 50d727a061775e9b8522c7df5f274732c9414583
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Feb 24 15:43:32 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/50d727a061775e9b8522c7df5f274732c9414583 [^]

Fixes issue 32240: Read only doesn't work on some columns in grid view

The problem is caused because it was not take into account read only when other
logic (e.g. display logic) was being applied in an editing grid view.

In order to prevent this, it take into account when a field is checks as read
only. In this case, the field is show properly.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-form.js.ftl
---
(0084478)
inigosanchez   
2016-02-25 00:48   
Added a test case in TestLink > Platform > [GDL] Grid Display Logic > [GDLa] Display logic in Grid > [GDLa050] Read Only and Display Logic. This test is automated.
(0084541)
alostale   
2016-02-26 09:17   
code reviewed

tested:
- in grid view editing an existing record
- in grid view creating a new record
- in form view editing an existing record
- in form view creating a new record
(0085167)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0090700)
guilleaer   
2016-10-19 17:01   
Reclosed.

It was reopened by mistake by me.
(0094343)
hgbot   
2017-02-15 09:11   
Repository: tools/automation/int
Changeset: 142e8aab204c3deea259ee3e657055eab9948785
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Feb 25 00:56:35 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/142e8aab204c3deea259ee3e657055eab9948785 [^]

added automated test for regression issue 32240

---
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GridSuite.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/build.xml
A src-test/com/openbravo/test/integration/erp/modules/client/application/testsuites/standardview/grid/GDLa050_ReadOnlyAndDisplayLogic.java
---