Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032238Openbravo ERPB. User interfacepublic2016-02-15 14:032016-03-04 09:26
Reporterngarcia 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4.5Fixed in Version3.0PR15Q4.5 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket40643
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032238: Payment In and Payment Out lines are not exported to CSV
DescriptionPayment In and Payment Out lines are not exported to CSV
Steps To ReproduceAs group admin role:
   Go to Payment In window
   Select a record
   Go to Lines tab and click on Export to Spreadsheet
   Check the file does not have any line apart from the column names
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032233 closed inigosanchez Payment In and Payment Out lines are not exported to CSV 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-15 18:12inigosanchezTypedefect => backport
2016-02-15 18:12inigosanchezTarget Version => 3.0PR15Q4.4
2016-02-26 10:43alostaleSeveritymajor => minor
2016-02-26 10:47alostaleTarget Version3.0PR15Q4.4 => 3.0PR15Q4.5
2016-02-29 23:54inigosanchezTarget Version3.0PR15Q4.5 => 3.0PR15Q4.4
2016-03-01 00:08inigosanchezTarget Version3.0PR15Q4.4 => 3.0PR15Q4.5
2016-03-04 08:52hgbotCheckin
2016-03-04 08:52hgbotNote Added: 0084706
2016-03-04 08:52hgbotStatusscheduled => resolved
2016-03-04 08:52hgbotResolutionopen => fixed
2016-03-04 08:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.5/rev/869c7c4e3fc4414bdcef00b5a09a310fa9483a3d [^]
2016-03-04 08:53inigosanchezIssue Monitored: alostale
2016-03-04 08:53inigosanchezReview Assigned To => alostale
2016-03-04 09:26alostaleNote Added: 0084712
2016-03-04 09:26alostaleStatusresolved => closed
2016-03-04 09:26alostaleFixed in Version => 3.0PR15Q4.5

Notes
(0084706)
hgbot   
2016-03-04 08:52   
Repository: erp/backports/3.0PR15Q4.5
Changeset: 869c7c4e3fc4414bdcef00b5a09a310fa9483a3d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Mar 04 08:51:49 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.5/rev/869c7c4e3fc4414bdcef00b5a09a310fa9483a3d [^]

Fixes issue 32238: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that exports
to CSV to use the same Criteria run when displaying the tab. Now export to CSV uses
tabId property. Besides it has been refactored some piece of code related with export
data in DataSourceServlet to use "tabId" instead of "tab".

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0084712)
alostale   
2016-03-04 09:26   
code reviewed and tested in different windows