Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032237Openbravo ERPB. User interfacepublic2016-02-15 14:032016-03-04 09:27
Reporterngarcia 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1Fixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032237: Payment In and Payment Out lines are not exported to CSV
DescriptionPayment In and Payment Out lines are not exported to CSV
Steps To ReproduceAs group admin role:
   Go to Payment In window
   Select a record
   Go to Lines tab and click on Export to Spreadsheet
   Check the file does not have any line apart from the column names
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032233 closed inigosanchez Payment In and Payment Out lines are not exported to CSV 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-15 18:12inigosanchezTypedefect => backport
2016-02-15 18:12inigosanchezTarget Version => 3.0PR16Q1
2016-02-26 10:43alostaleSeveritymajor => minor
2016-03-01 00:14hgbotCheckin
2016-03-01 00:14hgbotNote Added: 0084611
2016-03-01 00:14hgbotStatusscheduled => resolved
2016-03-01 00:14hgbotResolutionopen => fixed
2016-03-01 00:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/f5044f52a09c5c63d5f1c8964b90fbce96f31d00 [^]
2016-03-01 00:14inigosanchezReview Assigned To => alostale
2016-03-04 09:27alostaleNote Added: 0084713
2016-03-04 09:27alostaleStatusresolved => closed
2016-03-04 09:27alostaleFixed in Version => 3.0PR16Q1

Notes
(0084611)
hgbot   
2016-03-01 00:14   
Repository: erp/backports/3.0PR16Q1
Changeset: f5044f52a09c5c63d5f1c8964b90fbce96f31d00
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Feb 29 23:51:51 2016 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1/rev/f5044f52a09c5c63d5f1c8964b90fbce96f31d00 [^]

Fixes issue 32237: Payment In and Payment Out lines are not exported to CSV.

The problem was that export to CSV does not work properly in some subtabs without
link to parent column (e.g.Lines subtab of Payment In/Out). Before, It was used
"tabId" to obtaing data for export to CSV and the value of the "tabId" was sent
in a variable called "tab". The Criteria that is run when it is displayed the tab
uses a property named "tabId" instead of "tab".

The solution for this case (and other related cases) is to adapt the code that
exports to CSV to use the same Criteria run when displaying the tab. Now export to
CSV uses tabId property. Besides it has been refactored some piece of code related
with export data in DataSourceServlet to use "tabId" instead of "tab".

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0084713)
alostale   
2016-03-04 09:27   
code reviewed and tested in different windows