Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032218Openbravo ERPA. Platformpublic2016-02-12 12:192016-03-17 10:56
Reporteralostale 
Assigned ToAtulOpenbravo 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2015-08-05
Regression introduced in release3.0PR15Q4
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/1f572104e426366ac67e9efc7bd74040f8142ac3 [^]
Triggers an Emergency PackNo
Summary0032218: Payment In > Order navigation fails
DescriptionWhen trying to navigate from Payment In > Lines > Order Payment In Plan to Sales Order window, an error is thrown and the order is not opened.

Looking at the request to ReferencedLink, value for inpEntityName is now FIN_Payment_Schedule which is the base entity of the view linked by the field. Before it was FIN_Payment_Sched_Ord_V.
Steps To Reproduce1. Open Payment In window
2. Select any record related to an order.
3. Open Lines tab
4. Click on the link of "Order Payment Schedule"
  * Sales Invoice window is opened -> it should open Sales Order
  * This error is shown: Argument is not a BaseOBObject and not a HibernateProxy it is NULL
Proposed SolutionAdd a navigation rule for the Order Payment Schedule, in order to force the navigation to the Payment Plan tab of the Sales Order window.

Note that for the moment is not possible to create this rule from the UI, as it is not allowed to select a tab which shows an entity different from the entity pointed by the field.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00322193.0PR16Q1 closed platform Payment In > Order navigation fails 
depends on backport 00322203.0PR15Q4.4 closed platform Payment In > Order navigation fails 
caused by feature request 0015379 closed gorkaion Extend navigation model 
Attached Filesdiff issue-32218-testcase.diff (2,226) 2016-02-12 12:43
https://issues.openbravo.com/file_download.php?file_id=9057&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-12 12:19alostaleNew Issue
2016-02-12 12:19alostaleAssigned To => platform
2016-02-12 12:19alostaleModules => Core
2016-02-12 12:19alostaleTriggers an Emergency Pack => No
2016-02-12 12:20alostaleRegression level => Production - QA Approved
2016-02-12 12:20alostaleRegression date => 2015-08-05
2016-02-12 12:20alostaleRegression introduced in release => 3.0PR15Q4
2016-02-12 12:20alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/1f572104e426366ac67e9efc7bd74040f8142ac3 [^]
2016-02-12 12:21alostaleRelationship addedcaused by 0015379
2016-02-12 12:22alostaleStatusnew => scheduled
2016-02-12 12:43alostaleFile Added: issue-32218-testcase.diff
2016-02-12 12:43alostaleNote Added: 0084152
2016-02-12 12:43alostaleAssigned Toplatform => caristu
2016-02-12 15:22caristuNote Added: 0084165
2016-02-17 13:56caristuAssigned Tocaristu => Triage Finance
2016-02-17 14:00caristuProposed Solution updated
2016-02-17 14:01caristuStatusscheduled => acknowledged
2016-02-18 09:15caristuStatusacknowledged => scheduled
2016-02-18 09:21vmromanosAssigned ToTriage Finance => AtulOpenbravo
2016-02-18 13:46AtulOpenbravoNote Added: 0084322
2016-02-19 12:05psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11181#r11181
2016-02-19 12:06psanjuanNote Added: 0084358
2016-02-19 12:09psanjuanNote Edited: 0084358bug_revision_view_page.php?bugnote_id=0084358#r11183
2016-02-19 13:16psanjuanNote Edited: 0084322bug_revision_view_page.php?bugnote_id=0084322#r11186
2016-02-19 13:17psanjuanNote Edited: 0084322bug_revision_view_page.php?bugnote_id=0084322#r11187
2016-02-19 13:18psanjuanNote Added: 0084368
2016-02-22 11:10hgbotCheckin
2016-02-22 11:10hgbotNote Added: 0084391
2016-02-22 11:10hgbotStatusscheduled => resolved
2016-02-22 11:10hgbotResolutionopen => fixed
2016-02-22 11:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bf8f775716f07ad9926ee9b0d4c1c85be1a8bba6 [^]
2016-02-22 11:10hgbotCheckin
2016-02-22 11:10hgbotNote Added: 0084394
2016-02-22 11:11vmromanosReview Assigned To => vmromanos
2016-02-22 11:11vmromanosNote Added: 0084398
2016-02-22 11:11vmromanosStatusresolved => closed
2016-02-25 09:31psanjuanRelationship addedrelated to 0032336
2016-02-25 11:15psanjuanRelationship deletedrelated to 0032336
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085160
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085161

Notes
(0084152)
alostale   
2016-02-12 12:43   
attached failing test case
(0084165)
caristu   
2016-02-12 15:22   
The problem is that before the extend navigation project the ReferencedLink class was able to select destination of the FIN_Payment_Schedule reference from Payment In or Payment Out depending on the source window. This was harcoded.

That code was removed. Also is not possible to define a navigation rule to navigate to the sales order in this case.

So currently the field has not a navigation defined to behaved like before. This causes the breaking of the navigation is this case.
(0084322)
AtulOpenbravo   
2016-02-18 13:46   
(edited on: 2016-02-19 13:17)
Test Plan A
1. Open Payment In window.
2. Select any record with Order No. information in description field.
3. Open Lines tab.
4. Click on the link in "Order Payment Schedule" field/Link".
5. Check that Sales Order window is opened in Payment Plan Tab.

Repeat same test for Invoice Payment Schedule field/link.

Test Plan B
1. Open Payment Out window.
2. Select any record with Order No. information in description field.
3. Open Lines tab.
4. Click on the link in "Order Payment Schedule" field/Link".
5. Check that Purchase Order window is opened in Payment Plan Tab.

Repeat same test for Invoice Payment Schedule field/link.
(0084358)
psanjuan   
2016-02-19 12:06   
(edited on: 2016-02-19 12:09)
Issue verifed. Same failure shown while navigating from Payment In and Payment Out.
(0084368)
psanjuan   
2016-02-19 13:18   
Test plan above verified. Issue can be code reviewed and closed.
(0084391)
hgbot   
2016-02-22 11:10   
Repository: erp/devel/pi
Changeset: bf8f775716f07ad9926ee9b0d4c1c85be1a8bba6
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Feb 18 17:47:53 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/bf8f775716f07ad9926ee9b0d4c1c85be1a8bba6 [^]

Fixes Issue 32218:Payment In & Out Window Lines Tab Order Payment Plan Field
navigation fails

Direct Navigation Rule applied to
- Window:Payment In, Tab:Lines, Field:Order Payment Plan navigate to
  Sales Order | Payment Plan Tab
- Window:Payment Out, Tab:Lines, Field:Order Payment Plan navigate to
  Purchase Order | Payment Plan Tab

---
M src-db/database/sourcedata/AD_TABLE_NAVIGATION.xml
---
(0084394)
hgbot   
2016-02-22 11:10   
Repository: erp/devel/pi
Changeset: 863208bb4993be5f83ced529157040032b5fd666
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Feb 22 10:43:16 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/863208bb4993be5f83ced529157040032b5fd666 [^]

Related to issue 32218: fixed db consistency

---
M src-db/database/sourcedata/AD_TABLE_NAVIGATION.xml
---
(0084398)
vmromanos   
2016-02-22 11:11   
Code review + testing OK
(0085160)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085161)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test