Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032202Openbravo ERPA. Platformpublic2016-02-11 12:492016-03-17 10:56
Reporteraferraz 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-01-25
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/69d968879453d377cda8501a1cf0a6c9772d3693 [^]
Triggers an Emergency PackNo
Summary0032202: Error in add payment when editing the amount of a record in order/invoice grid
DescriptionError in add payment when editing the amount of a record in order/invoice grid
Steps To Reproduce- Create a Sales Order and complete it.
- Click on Add Payment
  Edit amount of selected record in order/invoice grid
  Realize the following error is shown: "Value is not a valid number"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00230563.0MP21 closed shankarb Ordered Quantiy field of Sales Order is not properly auto filling the grouping separator 
caused by defect 0031901 closed caristu decimal value can't be changed by trigger/observer after manual edition in form view 
causes defect 0035658 closed inigosanchez Fields redraws in grid view when a numeric field is referenced by a read only logic 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-11 12:49aferrazNew Issue
2016-02-11 12:49aferrazAssigned To => caristu
2016-02-11 12:49aferrazModules => Core
2016-02-11 12:49aferrazRegression level => Pre packaging ( pi )
2016-02-11 12:49aferrazRegression introduced in release => pi
2016-02-11 12:49aferrazTriggers an Emergency Pack => No
2016-02-11 14:11caristuStatusnew => scheduled
2016-02-11 15:45caristuRelationship addedcaused by 0031901
2016-02-11 15:46caristuRelationship addedrelated to 0023056
2016-02-11 15:53caristuNote Added: 0084111
2016-02-11 15:54caristuRegression date => 2016-01-25
2016-02-11 15:54caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/69d968879453d377cda8501a1cf0a6c9772d3693 [^]
2016-02-11 16:00hgbotCheckin
2016-02-11 16:00hgbotNote Added: 0084112
2016-02-11 16:00hgbotStatusscheduled => resolved
2016-02-11 16:00hgbotResolutionopen => fixed
2016-02-11 16:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/670d9903e7053700dad4cd2321b3df166571e122 [^]
2016-02-11 16:01caristuReview Assigned To => alostale
2016-02-11 16:01caristuIssue Monitored: alostale
2016-02-11 16:01caristuNote Edited: 0084111bug_revision_view_page.php?bugnote_id=0084111#r11077
2016-02-12 08:44alostaleNote Added: 0084138
2016-02-12 08:44alostaleStatusresolved => closed
2016-02-12 08:44alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085128
2017-04-20 10:52inigosanchezRelationship addedcauses 0035658

Notes
(0084111)
caristu   
2016-02-11 15:53   
(edited on: 2016-02-11 16:01)
The error is fired by the orderInvoiceGridValidation() method because it is receiving the decimal value as a string.

This is caused because the value is being set every time it changes, with the entered value. This is done to solve issue 0023056 to make sure that the grouping separator is not placed in a wrong place. This problem only affects to standard windows.

Before solving issue 0031901 the value was not being set on change in pick and execute windows. So, to solve this issue we just need to avoid setting the value in that event for this kind of windows, as it was done before.
(0084112)
hgbot   
2016-02-11 16:00   
Repository: erp/devel/pi
Changeset: 670d9903e7053700dad4cd2321b3df166571e122
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 11 15:57:36 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/670d9903e7053700dad4cd2321b3df166571e122 [^]

fixes issue 32202: Error in add payment when editing the amount of a record

The entered value is being set on the changed method for number items. This is done in order to prevent placing the decimal separator in a wrong place. This problem only affects to standard windows.

To solve the problem we only set the number item value in the changed method when we are not in a pick and edit window but in a standard window.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-number.js
---
(0084138)
alostale   
2016-02-12 08:44   
code reviewed + tested
(0085128)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test