Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032190Openbravo ERP09. Financial managementpublic2016-02-10 13:202016-07-20 11:34
Reporteregoitz 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket40524
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032190: Performance problems on the PriceDifferenceBackground process
DescriptionThe process is taking long to calculate the differences on 7000 transactions.
Steps To ReproduceExecute the process on an environment with big amount of data having 7000 transactions to be corrected.

ask ECA for an enviroment.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00320233.0PR16Q2 closed aferraz CostingUtils.getCurrentValuedStock method consumes unneeded memory 
related to defect 00334113.0PR17Q1 closed dmiguelez Bad performance Costing Background process using 3 types of adjustments 
related to defect 0035959 closed markmm82 Performance problem in Costing Migration Process with high volume of records in m_transaction table 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-10 13:20egoitzNew Issue
2016-02-10 13:20egoitzAssigned To => Triage Finance
2016-02-10 13:20egoitzOBNetwork customer => Yes
2016-02-10 13:20egoitzModules => Core
2016-02-10 13:20egoitzSupport ticket => 40524
2016-02-10 13:20egoitzResolution time => 1455922800
2016-02-10 13:20egoitzTriggers an Emergency Pack => No
2016-02-11 17:40aferrazStatusnew => scheduled
2016-02-11 17:40aferrazAssigned ToTriage Finance => aferraz
2016-02-12 13:53aferrazRelationship addedrelated to 0032023
2016-02-16 10:01aferrazSummaryProblemas performen on the PriceDifferenceBackground process => Performance problems on the PriceDifferenceBackground process
2016-02-19 12:39hgbotCheckin
2016-02-19 12:39hgbotNote Added: 0084362
2016-02-19 12:39hgbotStatusscheduled => resolved
2016-02-19 12:39hgbotResolutionopen => fixed
2016-02-19 12:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ca36991325a4e9680fbbb9fd36c755ae3f5500de [^]
2016-02-19 12:39dmiguelezReview Assigned To => dmiguelez
2016-02-19 12:39dmiguelezNote Added: 0084364
2016-02-19 12:39dmiguelezStatusresolved => closed
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085156
2016-07-20 11:32aferrazRelationship addedrelated to 0033411
2016-07-20 11:33aferrazFixed in Version => 3.0PR16Q2
2016-07-20 11:34aferrazTarget Version => 3.0PR16Q2
2017-05-09 12:31aferrazRelationship addedrelated to 0035959

Notes
(0084362)
hgbot   
2016-02-19 12:39   
Repository: erp/devel/pi
Changeset: ca36991325a4e9680fbbb9fd36c755ae3f5500de
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Feb 15 19:53:12 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ca36991325a4e9680fbbb9fd36c755ae3f5500de [^]

Fixes issue 32023 & Fixes issue 32190: Improve PriceDifference performance

Some improvements have been done in CostingUtils.getCurrentValuedStock, CostAdjustmentUtils.getValuedStockOnMovementDateByAttrAndLocator, CostAdjustmentUtils.getValuedStockOnTransactionDate and CostingMigrationProcess.getCurrentValuedStock methods:
- Use TransactionCost.PROPERTY_ACCOUNTINGDATE field instead of coalesce(ShipmentInOut.PROPERTY_ACCOUNTINGDATE, MaterialTransaction.PROPERTY_MOVEMENTDATE) to avoid join with ShipmentInOutLine and ShipmentInOut tables.
- Use a scroll instead of looping through a list.
- Loop can not be avoid due to the need of calculate conversion rate recursively.
- Clear every 100 loops will not be done as DAL objects will not be loaded in memory and to avoid session cleared errors.
Retrieve only one or two results in some queries where more results were not needed.
Use isEmpty() instead of size().
Retrieve only lineno field instead of full object in CostAdjustmentUtils.getNewLineNo method.
Improve CostAdjustmentUtils.getTrxCost method.
Do a clear every 100 loops in PriceDifferenceProcess.processPriceDifference method to improve performance.

---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingMigrationProcess.java
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/costing/PriceDifferenceProcess.java
---
(0084364)
dmiguelez   
2016-02-19 12:39   
Code Review + Testing Ok
(0085156)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test