Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032185Openbravo ERP09. Financial managementpublic2016-02-08 13:302016-02-11 17:08
Reportercaristu 
Assigned ToAtulOpenbravo 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR15Q4.3Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-11-20
Regression introduced in release3.0PR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/289b897908c3 [^]
Triggers an Emergency PackNo
Summary0032185: Not possible to sort by unit price in Return from Customer p&e
DescriptionIs not possible to sort by unit price in Return from Customer p&e.

The following error is displayed in the log after that:

867946fe 562280 [http-8082-5] ERROR org.hibernate.util.JDBCExceptionReporter - ERROR: invalid input syntax for type numeric: ""
  Position: 20857
867946fe 562280 [http-8082-5] ERROR org.openbravo.service.datasource.DataSourceServlet - could not execute query
org.hibernate.exception.DataException: could not execute query
    at org.hibernate.exception.SQLStateConverter.convert(SQLStateConverter.java:102)
    at org.hibernate.exception.JDBCExceptionHelper.convert(JDBCExceptionHelper.java:66)
    at org.hibernate.loader.Loader.doList(Loader.java:2536)
...
Steps To Reproduce1) Go to the [Return From Customer] window.
2) Create a new record in the header
3) Launch the Pick/Edit lines process
4) Sort by unit price. No results are shown.
Proposed SolutionIt seems that the problem is caused in the order by clause injected by ReturnToFromCustomerVendorHQLTransformer
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032157 closed AtulOpenbravo Not possible to sort by unit price in Return from Customer p&e 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-10 10:21AtulOpenbravoTypedefect => backport
2016-02-10 10:21AtulOpenbravoTarget Version => 3.0PR15Q4.3
2016-02-10 10:25AtulOpenbravoNote Added: 0084077
2016-02-11 17:07hgbotCheckin
2016-02-11 17:07hgbotNote Added: 0084117
2016-02-11 17:07hgbotStatusscheduled => resolved
2016-02-11 17:07hgbotResolutionopen => fixed
2016-02-11 17:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.3/rev/b7e118f4f8a72396d9167cc20a8f33049226395b [^]
2016-02-11 17:08vmromanosReview Assigned To => vmromanos
2016-02-11 17:08vmromanosNote Added: 0084121
2016-02-11 17:08vmromanosStatusresolved => closed

Notes
(0084077)
AtulOpenbravo   
2016-02-10 10:25   
Test Plan
- Go to the [Return From Customer] window.
- Create a new record in the header
- Launch the Pick/Edit lines process
- Sort by unit price. Proper sorting is done.
(0084117)
hgbot   
2016-02-11 17:07   
Repository: erp/backports/3.0PR15Q4.3
Changeset: b7e118f4f8a72396d9167cc20a8f33049226395b
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Feb 11 16:16:57 2016 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.3/rev/b7e118f4f8a72396d9167cc20a8f33049226395b [^]

Fixes Issue 0032185: Not possible to sort by unit price in Return from
Customer p&e

In case of the Return From Customer for a numeric value of unit Price COALESCE
was being use with '' which should have been 0 instead, COALESCE for order no
was missing for RTC, additonal ReturnReasonLeftClause2 added to replace
EntityAlias.name in the transformeredHQL Query.

---
M src/org/openbravo/common/datasource/ReturnToFromCustomerVendorHQLTransformer.java
---
(0084121)
vmromanos   
2016-02-11 17:08   
Code review + testing OK