Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032152Openbravo ERPA. Platformpublic2016-02-05 15:002016-03-17 10:56
ReporterAugustoMauch 
Assigned ToNaroaIriarte 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032152: Some columns of tables that belong to the AD dataset can be modified even if their module is not in development
DescriptionFor most of the columns that belong to AD tables it makes sense to show an error message if their are modified if their module is not in development.

There are some columns that are not taking this into account (i.e. Allow Sorting and Allow Filtering in the Columns tab, or the Is Tree flag in the Tables tab).
Steps To ReproduceAs System Admin, with no modules in development:
- Open the Tables and Column tab
- Select any table and change of the value of its Is Tree flag. The record can be saved (this is wrong)
- Select any record in the Columns tab, and change the value of the Allow Sorting and Allow Filtering flag. The record can be saved (this is wrong)
Proposed SolutionMaybe implement an event handler to centralize this, instead of having to modify a database trigger each time a column is added to an AD table
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031468 closed NaroaIriarte It would be nice to prevent sorting and filtering some columns. 
related to defect 0026557 acknowledged Triage Platform Base The editable field on the tab of parameters on the processdefinition window can be changed having modules indevelopment 
related to defect 00321513.0PR16Q2 closed NaroaIriarte The Allow Filtering flag is not working for columns that use the Text reference 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-05 15:00AugustoMauchNew Issue
2016-02-05 15:00AugustoMauchAssigned To => platform
2016-02-05 15:00AugustoMauchModules => Core
2016-02-05 15:00AugustoMauchTriggers an Emergency Pack => No
2016-02-05 15:00AugustoMauchRelationship addedrelated to 0032151
2016-02-25 14:43alostaleRelationship addedrelated to 0031468
2016-02-25 14:44alostaleTarget Version => 3.0PR16Q2
2016-02-25 14:44alostaleStatusnew => acknowledged
2016-02-25 14:46alostaleRelationship addedrelated to 0026557
2016-03-04 11:21NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-03-08 14:19hgbotCheckin
2016-03-08 14:19hgbotNote Added: 0084823
2016-03-08 14:19hgbotStatusacknowledged => resolved
2016-03-08 14:19hgbotResolutionopen => fixed
2016-03-08 14:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f4eb6b0d41e04a6f09147e93377a0b15fb7e3e27 [^]
2016-03-11 08:23alostaleReview Assigned To => alostale
2016-03-11 08:23alostaleNote Added: 0084896
2016-03-11 08:23alostaleStatusresolved => closed
2016-03-11 08:23alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085192

Notes
(0084823)
hgbot   
2016-03-08 14:19   
Repository: erp/devel/pi
Changeset: f4eb6b0d41e04a6f09147e93377a0b15fb7e3e27
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Tue Mar 08 10:56:37 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f4eb6b0d41e04a6f09147e93377a0b15fb7e3e27 [^]

fixed issue 32152: Some colums were modified even with no modules in devel.

The AllowSorting and AllowFiltering columns were modified even with no module in development.
That behavior is not correct and the AD_COLUMN_MOD_TRG.xml trigger has been modified to handle
this situation. Now if there is no module in development and the old value of these columns is
not the same as the new one (if it has been modified) an error is shown.

---
M src-db/database/model/triggers/AD_COLUMN_MOD_TRG.xml
---
(0084896)
alostale   
2016-03-11 08:23   
code reviewed
(0085192)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test