Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032151Openbravo ERPA. Platformpublic2016-02-05 14:512016-03-17 10:56
ReporterAugustoMauch 
Assigned ToNaroaIriarte 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032151: The Allow Filtering flag is not working for columns that use the Text reference
DescriptionThe Allow Filtering flag, placed in the Columns tab of the Tables and Columns window, is not being taken into consideration in columns that use the Text reference
Steps To ReproduceAs System Admin
- Open the Tables and Columns window
- Select the ADModule table
- Set to false the flag Allow Filtering and Allow sorting of the columns Help and Description
- Open the Module window. Check that both the Description and Help/Comment columns are not sortable (this is OK) and that the Help/Comment columns is filterable (this is WRONG)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032150 closed Triage Finance Allow sorting and allow filtering columns should be placed together 
related to defect 00321523.0PR16Q2 closed NaroaIriarte Some columns of tables that belong to the AD dataset can be modified even if their module is not in development 
related to feature request 0031468 closed NaroaIriarte It would be nice to prevent sorting and filtering some columns. 
related to defect 0032413 closed platform The "help" column of the "module" window is not sortable 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-05 14:51AugustoMauchNew Issue
2016-02-05 14:51AugustoMauchAssigned To => platform
2016-02-05 14:51AugustoMauchModules => Core
2016-02-05 14:51AugustoMauchTriggers an Emergency Pack => No
2016-02-05 15:00AugustoMauchRelationship addedrelated to 0032150
2016-02-05 15:00AugustoMauchRelationship addedrelated to 0032152
2016-02-25 14:45alostaleRelationship addedrelated to 0031468
2016-02-25 14:45alostaleStatusnew => acknowledged
2016-02-25 14:45alostaleTarget Version => 3.0PR16Q2
2016-03-04 11:20NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-03-04 11:53NaroaIriarteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=11352#r11352
2016-03-04 12:34NaroaIriarteNote Added: 0084727
2016-03-04 15:27NaroaIriarteNote Edited: 0084727bug_revision_view_page.php?bugnote_id=0084727#r11361
2016-03-04 15:28NaroaIriarteRelationship addedrelated to 0032413
2016-03-07 09:22hgbotCheckin
2016-03-07 09:22hgbotNote Added: 0084753
2016-03-07 09:22hgbotStatusacknowledged => resolved
2016-03-07 09:22hgbotResolutionopen => fixed
2016-03-07 09:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/07970979e44dac06aecb45ae2a4cdab9fe693647 [^]
2016-03-11 08:55alostaleReview Assigned To => alostale
2016-03-11 08:55alostaleNote Added: 0084898
2016-03-11 08:55alostaleStatusresolved => closed
2016-03-11 08:55alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085184

Notes
(0084727)
NaroaIriarte   
2016-03-04 12:34   
(edited on: 2016-03-04 15:27)
If you configure the Help/Comment column to be sortable but not filterable it does not work properly neither. It is filterable, which is wrong and it is not sortable, which is also wrong.

This seems to be another issue:

https://issues.openbravo.com/view.php?id=32413 [^]
(0084753)
hgbot   
2016-03-07 09:22   
Repository: erp/devel/pi
Changeset: 07970979e44dac06aecb45ae2a4cdab9fe693647
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Mar 04 14:37:26 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/07970979e44dac06aecb45ae2a4cdab9fe693647 [^]

Fixed issue 32151: It wasnt possible configure text referenced cols. properly.

It was not possible to configure the Allow Filtering property in colums that used Text reference.
The problem was in the UIDefinition.removeAttributeFromString.

Here the canSort and canFilter properties were being deleted and that was not correct, because in the case of
the "help" column of the Module window, for example, when the method was invoked, it was only desired to remove
the "canSort" property and not the canFilter.
The method has been changed, now, the passed String argument is the one which will be deleted instead of deleting
canSort or canFilter directly.

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
---
(0084898)
alostale   
2016-03-11 08:55   
code reviewed

tested with all combinations of allow/prevent sort/filter
(0085184)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test