Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032137Retail ModulesWeb POSpublic2016-02-04 18:282016-02-29 09:03
Reporterdbaz 
Assigned Toaaroncalero 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Todbaz
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032137: [UX] Undesired global scrolls when popups are shown in portrait mode
DescriptionUndesired global scrolls when popups are shown in portrait mode.

See attached "ScrollPortraitPopup_wrong.png".
Steps To ReproduceFollow this guide to set the 393x700 resolution in the browser:

http://wiki.openbravo.com/wiki/Retail:Developers_Guide/How-to/How_to_test_screen_resolutions [^]

Open any popup.

Note: not following the guide and use Chrome Developer Tools to change the screen resolution will cause that the issue could not be reproduced ("ScrollPortraitPopup_false_ok.png") since the touch screen emulation removes, among other things, the global scrolls, which are actually the issue itself.
Proposed SolutionIt should look like "ScrollPortraitPopup_ok.png".

Change this line:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/dd6b8ce938c7/web/org.openbravo.mobile.core/assets/css/ob-standard.css#l160 [^]

with this one:
  width: calc(100% - 24px);
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng ScrollPortraitPopup_wrong.png (24,172) 2016-02-04 18:28
https://issues.openbravo.com/file_download.php?file_id=9028&type=bug
png

png ScrollPortraitPopup_false_ok.png (43,705) 2016-02-04 18:28
https://issues.openbravo.com/file_download.php?file_id=9029&type=bug
png

png ScrollPortraitPopup_ok.png (24,565) 2016-02-04 18:28
https://issues.openbravo.com/file_download.php?file_id=9030&type=bug
png

diff FixIssue32137.diff (741) 2016-02-05 15:01
https://issues.openbravo.com/file_download.php?file_id=9031&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-04 18:28dbazNew Issue
2016-02-04 18:28dbazAssigned To => Retail
2016-02-04 18:28dbazFile Added: ScrollPortraitPopup_wrong.png
2016-02-04 18:28dbazOBNetwork customer => No
2016-02-04 18:28dbazTriggers an Emergency Pack => No
2016-02-04 18:28dbazFile Added: ScrollPortraitPopup_false_ok.png
2016-02-04 18:28dbazFile Added: ScrollPortraitPopup_ok.png
2016-02-05 15:01aaroncaleroFile Added: FixIssue32137.diff
2016-02-05 15:02aaroncaleroNote Added: 0083978
2016-02-08 09:22aaroncaleroStatusnew => scheduled
2016-02-08 09:22aaroncaleroAssigned ToRetail => aaroncalero
2016-02-08 16:50hgbotCheckin
2016-02-08 16:50hgbotNote Added: 0084008
2016-02-08 16:50hgbotCheckin
2016-02-08 16:50hgbotNote Added: 0084009
2016-02-08 16:50hgbotStatusscheduled => resolved
2016-02-08 16:50hgbotResolutionopen => fixed
2016-02-08 16:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c0d24d3b1d1ede5ef1f323a48552bdfd5f1be319 [^]
2016-02-26 08:46aaroncaleroReview Assigned To => dbaz
2016-02-26 10:06dmitry_mezentsevNote Added: 0084556
2016-02-29 09:03dbazNote Added: 0084581
2016-02-29 09:03dbazStatusresolved => closed
2016-02-29 09:03dbazFixed in Version => RR16Q2

Notes
(0083978)
aaroncalero   
2016-02-05 15:02   
Attached possible solution
(0084008)
hgbot   
2016-02-08 16:50   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e8bdb14a9320c47f41a6236517117d298034a610
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Feb 08 09:24:47 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e8bdb14a9320c47f41a6236517117d298034a610 [^]

Related to issue 32137: Fixed typo in css class definition

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
---
(0084009)
hgbot   
2016-02-08 16:50   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c0d24d3b1d1ede5ef1f323a48552bdfd5f1be319
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Mon Feb 08 09:26:11 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c0d24d3b1d1ede5ef1f323a48552bdfd5f1be319 [^]

Fixed issue 32137: [UX] Undesired global scrolls when popups are shown in portrait mode

---
M web/org.openbravo.mobile.core/assets/css/ob-standard.css
---
(0084556)
dmitry_mezentsev   
2016-02-26 10:06   
Not closed for 18 days!
(0084581)
dbaz   
2016-02-29 09:03   
Reviewed @ changeset: 1936 - 4556c6a80aeb