Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032105Retail ModulesWeb POSpublic2016-02-03 15:272016-06-20 19:05
Reporterdbaz 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032105: [UX] Wrong 'minus' character use in WebPOS
DescriptionThere are several places where the 'minus' character "-" is being used, where it should be proper to use this one "−"

http://www.fileformat.info/info/unicode/char/2212/index.htm [^]

https://en.wikipedia.org/wiki/Hyphen-minus [^]

There are several places identified where the wrong minus character is being used:
* Keypad: minus button
* Open till window: minus button in the left side rows (in the 'Quantity' column) to lower the input value
* Cash up: minus button in the left side rows (in the 'Quantity' column) to lower the input value

PS: I have set the priority to 'high', because each time these buttons are 'cloned' in new developments, the defect is propagated.
Steps To ReproduceSee attached screenshot
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032106 new Retail [UX] 'Cash Up' and 'Open Till' visual defects 
related to defect 0034313 closed mario_castello [RR16Q4] Split lines pop up shows 'â' character instead of minus sign 
causes defect 0033106 closed ranjith_qualiantech_com Not properly encoded minus sign ( - ) shown as "â" in the webPOS keypad 
Attached Filespng KeyPad_Buttons.png (4,318) 2016-02-03 15:27
https://issues.openbravo.com/file_download.php?file_id=9009&type=bug
png

patch issue 32105 source mobile.core 2182.patch (2,295) 2016-06-13 11:13
https://issues.openbravo.com/file_download.php?file_id=9514&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-03 15:27dbazNew Issue
2016-02-03 15:27dbazAssigned To => Retail
2016-02-03 15:27dbazFile Added: KeyPad_Buttons.png
2016-02-03 15:27dbazTriggers an Emergency Pack => No
2016-02-03 15:46dbazRelationship addedrelated to 0032106
2016-02-08 15:44marvintmAssigned ToRetail => christiangoni
2016-05-18 15:03dbazDescription Updatedbug_revision_view_page.php?rev_id=12147#r12147
2016-05-19 10:17OrekariaStatusnew => acknowledged
2016-05-19 10:17OrekariaAssigned Tochristiangoni => Retail
2016-05-19 15:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-05-19 15:43ranjith_qualiantech_comStatusacknowledged => scheduled
2016-05-25 09:27hgbotCheckin
2016-05-25 09:27hgbotNote Added: 0086717
2016-05-25 09:27hgbotStatusscheduled => resolved
2016-05-25 09:27hgbotResolutionopen => fixed
2016-05-25 09:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5bfd72e192293bcc82a05e76008af9db4b67971e [^]
2016-05-30 22:16guilleaerReview Assigned To => guilleaer
2016-05-30 22:16guilleaerStatusresolved => closed
2016-05-30 22:16guilleaerFixed in Version => RR16Q3
2016-06-01 16:49OrekariaRelationship addedcauses 0033106
2016-06-09 16:33marvintmNote Added: 0087138
2016-06-09 16:33marvintmStatusclosed => new
2016-06-09 16:33marvintmResolutionfixed => open
2016-06-09 16:33marvintmFixed in VersionRR16Q3 =>
2016-06-09 16:33marvintmStatusnew => scheduled
2016-06-13 11:13ranjith_qualiantech_comFile Added: issue 32105 source mobile.core 2182.patch
2016-06-14 09:38hgbotCheckin
2016-06-14 09:38hgbotNote Added: 0087227
2016-06-14 09:38hgbotStatusscheduled => resolved
2016-06-14 09:38hgbotResolutionopen => fixed
2016-06-14 09:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5bfd72e192293bcc82a05e76008af9db4b67971e [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1f51773601a126121fd4f7a05174be96a2369a65 [^]
2016-06-14 09:41hgbotCheckin
2016-06-14 09:41hgbotNote Added: 0087229
2016-06-20 19:05guilleaerStatusresolved => closed
2016-06-20 19:05guilleaerFixed in Version => RR16Q3
2016-10-27 12:35plujanRelationship addedrelated to 0034313

Notes
(0086717)
hgbot   
2016-05-25 09:27   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5bfd72e192293bcc82a05e76008af9db4b67971e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 23 12:49:31 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5bfd72e192293bcc82a05e76008af9db4b67971e [^]

Fixes issue 32105 : Replacing Keyboard minus label

Replacing keyboard minus label from "-" to "−"

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0087138)
marvintm   
2016-06-09 16:33   
The original fix was reverted due to a visualization regression that it caused:

https://issues.openbravo.com/view.php?id=33106 [^]

The fix needs to be implemented slightly differently. Instead of hardcoding the character, it needs to be read from a special AD_MESSAGE entry we defined for special characters which need to be used in our components. An example of this can be found in this issue:

https://issues.openbravo.com/view.php?id=31300 [^]
(0087227)
hgbot   
2016-06-14 09:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1f51773601a126121fd4f7a05174be96a2369a65
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 14 13:07:58 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1f51773601a126121fd4f7a05174be96a2369a65 [^]

Fixes issue 32105 : Replacing Keyboard minus label with AD_Message value

- Added Minus char to "OBMOBC_Character"

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0087229)
hgbot   
2016-06-14 09:41   
Repository: tools/automation/pi-mobile
Changeset: 6a40605646c4f57d4380e71e81dfbf665ffeb2f3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 14 13:08:08 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6a40605646c4f57d4380e71e81dfbf665ffeb2f3 [^]

Verifies issue 32105 : Added Minus char to OBMOBC_Character AD Msg

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/VerifySpecialCharactersString.java
---