Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032092Openbravo ERPA. Platformpublic2016-02-02 13:432016-03-17 10:56
Reporterlorenzofidalgo 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032092: [RR16Q1] "Automate Movement to Other Account" checkbox hides "Cash Management" section from POS Terminal Type || Payment Method
DescriptionAfter clicking "Automate Movement to Other Account" checkbox, "Cash Management" is hidden. User has to click Cash Management section twice to be able to see Cash Management's fields again. This is placed in "POS Terminal Type" window, "Payment Method" tab.
This issue has been reproduced in RR16Q1 and RR15Q4.1. This issue has not been reproduced in RR15Q3.4 and RR15Q2.5.
Steps To Reproduce0-Login POS backend.
1-Using "The White Valley Group Admin" role, go to "POS Terminal Type" window.
2-Select "CMS POS Terminal Type" record and click "Payment Method" tab.
3-Click "Create a new record in a form" button.
4-Cancel Edition and Click "Create a new record in a form" again.
5-Scroll down and watch "Cash Management" section. Now click "Automate Movement to Other Account" checkbox to check off it.
6-Realise that "Cash Management" section is not visible now. Scroll up/down and it is still not visible. User has to click several times "Cash Management" section to be able to see "Cash Management"'s fields again.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0019378 closed dbaz Hidden sections take space 
related to defect 0033576 acknowledged Triage Platform Base "Service Product" section in "Product" window performs a wrong expansion behaviour 
Attached Filespng CashManagementNotVisible.png (162,820) 2016-02-02 13:43
https://issues.openbravo.com/file_download.php?file_id=8997&type=bug
png

diff issue32092.diff (1,556) 2016-02-03 09:10
https://issues.openbravo.com/file_download.php?file_id=9003&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-02-02 13:43lorenzofidalgoNew Issue
2016-02-02 13:43lorenzofidalgoAssigned To => platform
2016-02-02 13:43lorenzofidalgoFile Added: CashManagementNotVisible.png
2016-02-02 13:43lorenzofidalgoOBNetwork customer => No
2016-02-02 13:43lorenzofidalgoWeb browser => Google Chrome
2016-02-02 13:43lorenzofidalgoModules => Core
2016-02-02 13:43lorenzofidalgoRegression level => Production - QA Approved
2016-02-02 13:43lorenzofidalgoRegression introduced in release => 3.0PR15Q4.1
2016-02-02 13:43lorenzofidalgoTriggers an Emergency Pack => No
2016-02-02 13:46lorenzofidalgoWeb browserGoogle Chrome => Google Chrome
2016-02-02 13:46lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10853#r10853
2016-02-02 13:46lorenzofidalgoWeb browserGoogle Chrome => Google Chrome
2016-02-02 13:46lorenzofidalgoSeveritytrivial => minor
2016-02-02 14:34alostaleNote Added: 0083849
2016-02-02 14:34alostaleStatusnew => acknowledged
2016-02-02 18:42caristuWeb browserGoogle Chrome => Google Chrome
2016-02-02 18:42caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10858#r10858
2016-02-02 18:43caristuStatusacknowledged => scheduled
2016-02-02 18:43caristuAssigned Toplatform => caristu
2016-02-02 18:43caristuFile Added: issue32092.diff
2016-02-02 18:50caristuNote Added: 0083861
2016-02-02 18:50caristuWeb browserGoogle Chrome => Google Chrome
2016-02-02 18:50caristuRegression levelProduction - QA Approved =>
2016-02-02 18:50caristuRegression introduced in release3.0PR15Q4.1 =>
2016-02-03 09:10caristuFile Deleted: issue32092.diff
2016-02-03 09:10caristuFile Added: issue32092.diff
2016-02-03 09:13caristuRelationship addedrelated to 0019378
2016-02-03 19:43hgbotCheckin
2016-02-03 19:43hgbotNote Added: 0083904
2016-02-03 19:43hgbotStatusscheduled => resolved
2016-02-03 19:43hgbotResolutionopen => fixed
2016-02-03 19:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/010420803d1c5d4c1397a7fbcd5b02d072e208c7 [^]
2016-02-03 19:44caristuReview Assigned To => alostale
2016-02-03 19:44caristuWeb browserGoogle Chrome => Google Chrome
2016-02-03 19:44caristuIssue Monitored: alostale
2016-02-04 10:15hgbotCheckin
2016-02-04 10:15hgbotNote Added: 0083917
2016-02-05 08:50alostaleNote Added: 0083945
2016-02-05 08:50alostaleStatusresolved => closed
2016-02-05 08:50alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:55hudsonbotCheckin
2016-03-17 10:55hudsonbotNote Added: 0085103
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085104
2016-08-01 13:18lorenzofidalgoRelationship addedrelated to 0033576

Notes
(0083849)
alostale   
2016-02-02 14:34   
Note in previous releases space for hidden fields by display logic was preserved whereas starting from 3.0PR15Q4 it is not. When they are shown again the space is filled again bug scroll bar is not taking new page size into consideration so it does not get refreshed.

This change is not intended so space should be preserved as it was previously.
(0083861)
caristu   
2016-02-02 18:50   
The problem can be reproduced always after canceling the edition and reopening edition in form. (Updated step 3)

In this case the fields are marked to not keep the space after canceling, but they are not restored again to keep the space when reopening.

The problem can not be reproduced the first time because in this case the fields are indeed marked to keep the space.

Attached proposed solution.
(0083904)
hgbot   
2016-02-03 19:43   
Repository: erp/devel/pi
Changeset: 010420803d1c5d4c1397a7fbcd5b02d072e208c7
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Feb 03 19:42:14 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/010420803d1c5d4c1397a7fbcd5b02d072e208c7 [^]

fixes issue 32092: hidden fields space not restored after reopening form view

The alwaysTakeSpace property of the form items was only being set after opening the form view the first time. This property is used to keep space for the displayed field (including the hidden ones by display logic). This property is being set to false when closing form view, and then, never restored again.

Now this property is set every time the UI switches into the form view.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0083917)
hgbot   
2016-02-04 10:15   
Repository: erp/devel/pi
Changeset: 09569ec4f2f0d6d47b4ab3753cf6244ffaba09d5
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Feb 04 10:14:27 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/09569ec4f2f0d6d47b4ab3753cf6244ffaba09d5 [^]

related to issue 32092: updated copyright year

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0083945)
alostale   
2016-02-05 08:50   
code reviewed + tested
(0085103)
hudsonbot   
2016-03-17 10:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085104)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test