Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032091Openbravo ERP09. Financial managementpublic2016-02-02 13:322016-03-17 10:56
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032091: The Order/Invoices grid in Add Details must always sort by selected records first
DescriptionThe Order/Invoices grid in Add Details must ensure that the selected records are always displayed first. This is the way to ensure that the selection is never lost as it always be displayed in the first page.

The same applies for all the P&E grids within the application.
Steps To ReproduceUsing an environment where more than 100 records can be displayed
1. Access [Payment In] window and create header record
2. Run "Add details" process and select the first record. Change the sorting criteria making the selected record leave the first page, i.e., the selected record should appear after position 100th.
3. Notice that the grids starts to not filter/sorting properly. The following error is displayed in the console: Uncaught BigDecimal(): Not a number: u,n,d,e,f,i,n,e,d
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00319893.0PR16Q2 closed caristu Wrong behavior in order/invoices grid in Add Payment process definition when having >100 records selected 
related to defect 0029560 closed caristu The addDetails popup does not respond after several seachs on grid with big amout of data. 
related to defect 0032113 new Triage Omni OMS Review application pick and edit windows to ensure that they always sorting by selected records first 
related to defect 0032145 closed caristu API Change required for AddPaymentOrderInvoicesTransformer 
related to defect 0032193 closed caristu Selection is not working properly in P&E grids having filter on change option set to N 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-02 13:32caristuNew Issue
2016-02-02 13:32caristuAssigned To => caristu
2016-02-02 13:32caristuModules => Core
2016-02-02 13:32caristuTriggers an Emergency Pack => No
2016-02-02 13:33caristuRelationship addedrelated to 0031989
2016-02-02 13:33caristuRelationship addedrelated to 0029560
2016-02-02 13:33caristuTarget Version => 3.0PR16Q2
2016-02-02 13:33caristuStatusnew => scheduled
2016-02-03 19:31hgbotCheckin
2016-02-03 19:31hgbotNote Added: 0083903
2016-02-03 19:31hgbotStatusscheduled => resolved
2016-02-03 19:31hgbotResolutionopen => fixed
2016-02-03 19:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fc90763f8bed6edd34f518bdf95165ca12ffc429 [^]
2016-02-03 19:33caristuIssue Monitored: alostale
2016-02-03 19:33caristuReview Assigned To => alostale
2016-02-03 19:56caristuRelationship addedrelated to 0032113
2016-02-05 08:33alostaleNote Added: 0083943
2016-02-05 08:33alostaleStatusresolved => new
2016-02-05 08:33alostaleResolutionfixed => open
2016-02-05 12:25caristuStatusnew => scheduled
2016-02-05 12:28caristuRelationship addedrelated to 0032145
2016-02-08 09:12hgbotCheckin
2016-02-08 09:12hgbotNote Added: 0083993
2016-02-08 09:13caristuStatusscheduled => resolved
2016-02-08 09:13caristuResolutionopen => fixed
2016-02-08 09:37hgbotCheckin
2016-02-08 09:37hgbotNote Added: 0083995
2016-02-08 13:12hgbotCheckin
2016-02-08 13:12hgbotNote Added: 0084002
2016-02-11 11:54caristuRelationship addedrelated to 0032193
2016-02-12 08:41alostaleNote Added: 0084137
2016-02-12 08:41alostaleStatusresolved => closed
2016-02-12 08:41alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:55hudsonbotCheckin
2016-03-17 10:55hudsonbotNote Added: 0085102
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085111
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085112
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085113

Notes
(0083903)
hgbot   
2016-02-03 19:31   
Repository: erp/devel/pi
Changeset: fc90763f8bed6edd34f518bdf95165ca12ffc429
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Feb 03 19:29:23 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fc90763f8bed6edd34f518bdf95165ca12ffc429 [^]

fixes issue 32091: The Order/Invoices grid now sorts by selected records first

Now the AddPaymentOrderInvoicesTransformer places first the selected record criteria for ordering, put it just before the ordering criteria selected by the user in the grid.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
---
(0083943)
alostale   
2016-02-05 08:33   
reopened, see review: https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0083993)
hgbot   
2016-02-08 09:12   
Repository: erp/devel/pi
Changeset: 5f989d9923384cfea1548782ed85aff8dae3c71c
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Feb 08 09:06:40 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5f989d9923384cfea1548782ed85aff8dae3c71c [^]

related to issue 32091: code review improvements

After sorting the grid without having any filter applied, the selection was not being kept on top. To solve this, now we check if there is a criteria present in the request and also if there are selected records. In that case, a new criteria is included in the request with the ids of the selected records.

Besides, two methods are deleted from AddPaymentOrderInvoicesTransformer as they are no longer needed. And a new check is added when retrieving the selected records in the backend, in order to avoid a possible JSONException.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/hqlinjections/AddPaymentOrderInvoicesTransformer.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
---
(0083995)
hgbot   
2016-02-08 09:37   
Repository: erp/devel/pi
Changeset: d55a1773427b7084ed5c561f786b6859a2a72295
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Feb 08 09:33:15 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d55a1773427b7084ed5c561f786b6859a2a72295 [^]

related to issue 32091: Added missing comparator

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0084002)
hgbot   
2016-02-08 13:12   
Repository: erp/devel/pi
Changeset: ee2964a9b5659222eb75ef45138cb331812da2aa
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Feb 08 13:04:07 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ee2964a9b5659222eb75ef45138cb331812da2aa [^]

related to issue 32091: Covered case when window is opened with a a pre-filter

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0084137)
alostale   
2016-02-12 08:41   
code reviewed and tested
(0085102)
hudsonbot   
2016-03-17 10:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085111)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085112)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085113)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test