Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032045Retail ModulesWeb POSpublic2016-01-28 18:032016-03-14 09:57
Reportermigueldejuana 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032045: Ensure stable ids in docs send from WebPOS to the server (External Modules)
DescriptionSee wiki page:
http://wiki.openbravo.com/wiki/Projects:WebPOS_Store_Server_ensure_Same_Ids [^] [^] [^]

Do that for External Modules.

Gift Cards
Discounts
...
Steps To ReproduceSee Description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031654 closed migueldejuana Ensure stable ids in docs send from WebPOS to the server 
depends on defect 0032044 closed migueldejuana Ensure stable ids in docs send from WebPOS to the server (Payment API) 
related to design defect 0032402 new Retail Warehouse Physical Inventory and Picking have to be compatible with multiserver 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-28 18:03migueldejuanaNew Issue
2016-01-28 18:03migueldejuanaAssigned To => migueldejuana
2016-01-28 18:03migueldejuanaTriggers an Emergency Pack => No
2016-01-28 18:04migueldejuanaRelationship addedrelated to 0031654
2016-01-28 18:04migueldejuanaRelationship addeddepends on 0032044
2016-03-03 09:18hgbotCheckin
2016-03-03 09:18hgbotNote Added: 0084672
2016-03-03 09:18hgbotStatusnew => resolved
2016-03-03 09:18hgbotResolutionopen => fixed
2016-03-03 09:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/7a9b8832911a973d557380faaa60a208f26d88a4 [^]
2016-03-03 09:18hgbotCheckin
2016-03-03 09:18hgbotNote Added: 0084673
2016-03-03 09:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/7a9b8832911a973d557380faaa60a208f26d88a4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/3692200217544aa07a0adbd56b5dfc3d5ac960a8 [^]
2016-03-03 17:25migueldejuanaReview Assigned To => mtaal
2016-03-03 17:27migueldejuanaNote Added: 0084695
2016-03-03 17:31migueldejuanaRelationship addedrelated to 0032402
2016-03-07 16:00hgbotCheckin
2016-03-07 16:00hgbotNote Added: 0084784
2016-03-07 16:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/3692200217544aa07a0adbd56b5dfc3d5ac960a8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/ccc57f17cae50660c828c5c0a5d019dd98846336 [^]
2016-03-11 09:56mtaalNote Added: 0084899
2016-03-11 09:56mtaalNote Added: 0084900
2016-03-11 09:56mtaalStatusresolved => new
2016-03-11 09:56mtaalResolutionfixed => open
2016-03-11 10:41mtaalNote Added: 0084903
2016-03-11 10:47mtaalNote Added: 0084904
2016-03-11 11:35hgbotCheckin
2016-03-11 11:35hgbotNote Added: 0084906
2016-03-11 11:35hgbotStatusnew => resolved
2016-03-11 11:35hgbotResolutionopen => fixed
2016-03-11 11:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/ccc57f17cae50660c828c5c0a5d019dd98846336 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/be34026dd2e35f26f48c0369226065d86b8b7677 [^]
2016-03-14 00:36hgbotCheckin
2016-03-14 00:36hgbotNote Added: 0084928
2016-03-14 09:04mtaalNote Added: 0084933
2016-03-14 09:57migueldejuanaAssigned Tomigueldejuana => mtaal
2016-03-14 09:57migueldejuanaReview Assigned Tomtaal => migueldejuana
2016-03-14 09:57migueldejuanaNote Added: 0084936
2016-03-14 09:57migueldejuanaStatusresolved => closed

Notes
(0084672)
hgbot   
2016-03-03 09:18   
Repository: erp/pmods/org.openbravo.mobile.warehouse
Changeset: 7a9b8832911a973d557380faaa60a208f26d88a4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 03 09:16:56 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/7a9b8832911a973d557380faaa60a208f26d88a4 [^]

Fixed issue 0032045: Ensure stable ids in docs send from WebPOS to the server (External Modules)

- Set Id and go through Import Entry to work with Multiserver

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/mobile/warehouse/goodmovement/ProcessDocument.java
M web/org.openbravo.mobile.warehouse/source/goodsMovement/wh-movement-model.js
A src/org/openbravo/mobile/warehouse/WHDataSynchronizationProcess.java
A src/org/openbravo/mobile/warehouse/goodmovement/ProcessDocumentEntryProcessor.java
---
(0084673)
hgbot   
2016-03-03 09:18   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 3692200217544aa07a0adbd56b5dfc3d5ac960a8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Mar 03 09:12:25 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/3692200217544aa07a0adbd56b5dfc3d5ac960a8 [^]

Fixed issue 0032045: Ensure stable ids in docs send from WebPOS to the server (External Modules)

- Set Id and go through Import Entry to work with Multiserver
- Remove quotation success message. There are no quotations in procurement

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/mobile/procurement/sync/POrderLoader.java
M src/org/openbravo/mobile/procurement/sync/SetBusinessPartner.java
M web/org.openbravo.mobile.procurement/source/data/mpr-dataordersave.js
M web/org.openbravo.mobile.procurement/source/data/mpr-datasetbp.js
M web/org.openbravo.mobile.procurement/source/model/mpr-order.js
A src/org/openbravo/mobile/procurement/OBMPRDataSynchronizationProcess.java
A src/org/openbravo/mobile/procurement/sync/POrderLoaderEntryProcessor.java
A src/org/openbravo/mobile/procurement/sync/SetBusinessPartnerEntryProcessor.java
---
(0084695)
migueldejuana   
2016-03-03 17:27   
Warehouse Physical Inventory and Picking have servlets not supported by actual MultiserverAPI. An issue will be created for them.
(0084784)
hgbot   
2016-03-07 16:00   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: ccc57f17cae50660c828c5c0a5d019dd98846336
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Mar 07 16:00:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/ccc57f17cae50660c828c5c0a5d019dd98846336 [^]

Fixed issue 0032045: Ensure stable ids in docs send from WebPOS to the server (External Modules)

- Remove waiting to other servlet entries, in this case is not needed.

---
M src/org/openbravo/mobile/procurement/sync/POrderLoaderEntryProcessor.java
M src/org/openbravo/mobile/procurement/sync/SetBusinessPartnerEntryProcessor.java
---
(0084899)
mtaal   
2016-03-11 09:56   
Reviewing, the setbusinesspartner call should not go through import entry, the set business partner sets the session id. The service should still be a transactional call but not through importentry. Going through importentry means going through another thread then the request thread, setting the session then won't change the user-session but the import entry processing thread http session (which is fake).
(0084900)
mtaal   
2016-03-11 09:56   
See previous remark
(0084903)
mtaal   
2016-03-11 10:41   
Tested procurement id setting with queries below on multi-server, works fine.

select c_order_id from c_order order by updated desc limit 2
--"7E933D63C3AFB0041603C1C0A174DBBE"
-- "74F48DBC3E89CFD992A0A999D077B78E"

select c_orderline_id from c_orderline order by updated desc limit 2
-- "7733D85E66C8EF7A605B5C78ECE406DB"
-- "3BF2E701A14A099A4EFF52FAF638E8DB"

select c_orderlinetax_id from c_orderlinetax order by updated desc limit 2
-- "416190CECD2C3D4BAEE312505218959B"
-- "55072A27AD15377DBC086D9673F30ACB"

select c_ordertax_id from c_ordertax order by updated desc limit 2
-- "936506D641DC38549C1B68CC4DD61E38"
-- "D7EC2145E3103B8DA2E610988B86C411"
(0084904)
mtaal   
2016-03-11 10:47   
Check warehouse ids, are fine to:

select m_inout_id from m_inout order by updated desc limit 2
-- "DFC7A0A5E100EB9B576141B264F834C8"
-- "BED864300639E6E44FADABF28B4448C1"

select m_inoutline_id from m_inoutline order by updated desc limit 2
-- "4EBEDC30C85F3926B07A7509482B8C73"
-- "CC4862CC34EB38D694A333266125C32A"
(0084906)
hgbot   
2016-03-11 11:35   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: be34026dd2e35f26f48c0369226065d86b8b7677
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Mar 11 11:34:51 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/be34026dd2e35f26f48c0369226065d86b8b7677 [^]

Fixed issue 0032045: Ensure stable ids in docs send from WebPOS to the server (External Modules)

- Set Business Partner must not use Import Entry

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/mobile/procurement/sync/SetBusinessPartner.java
R src/org/openbravo/mobile/procurement/sync/SetBusinessPartnerEntryProcessor.java
---
(0084928)
hgbot   
2016-03-14 00:36   
Repository: erp/pmods/org.openbravo.mobile.procurement
Changeset: 60375400063227d79b3f8f43f229d072b1b7245a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 14 00:32:44 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.procurement/rev/60375400063227d79b3f8f43f229d072b1b7245a [^]

Related to issue 32045: Ensure stable ids in docs send from WebPOS to the server (External Modules)
Change the way the BP set message is processed, json is different from before because is now a
transactional message.

---
M src/org/openbravo/mobile/procurement/sync/SetBusinessPartner.java
---
(0084933)
mtaal   
2016-03-14 09:04   
Asking Miguel to review my change, other changes are fine and working
(0084936)
migueldejuana   
2016-03-14 09:57   
Tested and reviewed