Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032039Openbravo ERPA. Platformpublic2016-01-28 12:532016-03-17 10:56
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032039: Add generic mechanism to have multiple cached preferences
DescriptionIt would be nice to have a generic class which allows to have multiple cached preferences.

Currently the UnpagedRequestCachedPreference class caches the "Allow Unpaged Datasource Manual Request" preference.

This new class will allow to keep multiple preferences in cache.
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00302043.0PR15Q4 closed caristu prevent unpaged datsource request from manual sources 
related to defect 0032041 closed caristu API change required for cached preference mechanism 
related to defect 0034499 closed caristu [clustering] CachedPreference feature is not supported on clustered environments 
Attached Filesdiff issue32039.diff (12,007) 2016-01-28 16:02
https://issues.openbravo.com/file_download.php?file_id=8980&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-28 12:53caristuNew Issue
2016-01-28 12:53caristuAssigned To => caristu
2016-01-28 12:53caristuModules => Core
2016-01-28 12:53caristuTriggers an Emergency Pack => No
2016-01-28 12:54caristuRelationship addedrelated to 0030204
2016-01-28 13:59caristuRelationship addedrelated to 0032041
2016-01-28 14:00caristuFile Added: issue32039.diff
2016-01-28 14:00caristuNote Added: 0083661
2016-01-28 14:13caristuFile Deleted: issue32039.diff
2016-01-28 14:13caristuFile Added: issue32039.diff
2016-01-28 14:14caristuFile Deleted: issue32039.diff
2016-01-28 14:14caristuFile Added: issue32039.diff
2016-01-28 16:02caristuFile Deleted: issue32039.diff
2016-01-28 16:02caristuFile Added: issue32039.diff
2016-01-29 13:39hgbotCheckin
2016-01-29 13:39hgbotNote Added: 0083729
2016-01-29 13:39hgbotStatusnew => resolved
2016-01-29 13:39hgbotResolutionopen => fixed
2016-01-29 13:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a67a1b567591904aa8a132573a72fab119ebe062 [^]
2016-01-29 13:41caristuIssue Monitored: alostale
2016-01-29 13:41caristuReview Assigned To => alostale
2016-02-05 08:53alostaleNote Added: 0083946
2016-02-05 08:53alostaleStatusresolved => closed
2016-02-05 08:53alostaleFixed in Version => 3.0PR16Q2
2016-02-05 08:58hgbotCheckin
2016-02-05 08:58hgbotNote Added: 0083947
2016-03-17 10:55hudsonbotCheckin
2016-03-17 10:55hudsonbotNote Added: 0085090
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085105
2016-11-14 17:07caristuRelationship addedrelated to 0034499

Notes
(0083661)
caristu   
2016-01-28 14:00   
Attached proposed fix. It has been pushed to try
(0083729)
hgbot   
2016-01-29 13:39   
Repository: erp/devel/pi
Changeset: a67a1b567591904aa8a132573a72fab119ebe062
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 29 13:34:12 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a67a1b567591904aa8a132573a72fab119ebe062 [^]

fixes issue 32039: Add generic mechanism to have multiple cached preferences

The new CachedPreference class can be used to keep the value of a preference defined at system level. The value of the 'Allow Unpaged Datasource Manual Request' preference is already handled by this class. So the UnpagedRequestCachedPreference is not needed anymore.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/PreferenceEventHandler.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
A modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
R modules/org.openbravo.service.json/src/org/openbravo/service/json/UnpagedRequestCachedPreference.java
---
(0083946)
alostale   
2016-02-05 08:53   
code reviewed
(0083947)
hgbot   
2016-02-05 08:58   
Repository: erp/devel/pi
Changeset: 991ea0215b59919614d19dd8eb19c5634a1c9ca3
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Feb 05 08:58:12 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/991ea0215b59919614d19dd8eb19c5634a1c9ca3 [^]

related to issue 32039: reuse constant for upaged ds requests

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
---
(0085090)
hudsonbot   
2016-03-17 10:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085105)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test