Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032021Retail ModulesWeb POSpublic2016-01-27 12:402016-02-15 08:55
Reporterguillermogil 
Assigned Toranjith_qualiantech_com 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032021: Payment methods on "More" gets duplicated
DescriptionThe payment methods that are on "More..." button gets duplicated every time you go to cash management or cash up window.
See attached screenshot
Steps To ReproduceHaving 6 or more payment methods defined

1.- Create a ticket
2.- Verify that on more button appears the properly payment method
3.- Go to cash up and cancel it
4.- Go to pay a ticket and verify that the payment methods got duplicated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 0031718 closed ranjith_qualiantech_com [SERQA 486]payment type "gift card" is not displayed when there is 6 payment methods 
related to defect 0028629 closed marvintm Gifts and vouched payment method duplicate after a Cashup 
depends on backport 0032122RR16Q1 closed guilleaer Payment methods on "More" gets duplicated 
causes defect 0033700 closed ranjith_qualiantech_com Payments from More Button are throwing JS Errors. 
Attached Filespng Screenshot from 2016-01-27 12:34:54.png (149,409) 2016-01-27 12:40
https://issues.openbravo.com/file_download.php?file_id=8971&type=bug
png

png Screenshot from 2016-01-27 12:35:14.png (147,572) 2016-01-27 12:40
https://issues.openbravo.com/file_download.php?file_id=8972&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-01-27 12:40guillermogilNew Issue
2016-01-27 12:40guillermogilAssigned To => Retail
2016-01-27 12:40guillermogilTriggers an Emergency Pack => No
2016-01-27 12:40guillermogilFile Added: Screenshot from 2016-01-27 12:34:54.png
2016-01-27 12:40guillermogilFile Added: Screenshot from 2016-01-27 12:35:14.png
2016-01-27 12:45guillermogilResolution time => 1454022000
2016-01-27 12:59lorenzofidalgoRelationship addedrelated to 0028629
2016-01-27 17:20dmitry_mezentsevNote Added: 0083640
2016-01-27 17:20dmitry_mezentsevSeveritymajor => minor
2016-01-28 12:43OrekariaReview Assigned To => Orekaria
2016-01-28 12:43OrekariaStatusnew => closed
2016-01-28 12:43OrekariaFixed in Version => RR16Q2
2016-01-28 12:44OrekariaNote Added: 0083657
2016-01-28 12:44OrekariaRelationship addedduplicate of 0031718
2016-01-28 13:40marvintmNote Added: 0083659
2016-01-28 13:40marvintmStatusclosed => new
2016-01-28 13:40marvintmFixed in VersionRR16Q2 =>
2016-01-28 13:41marvintmRelationship deleted0031718
2016-01-28 13:50OrekariaStatusnew => acknowledged
2016-02-01 13:53ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-02-01 13:53ranjith_qualiantech_comStatusacknowledged => scheduled
2016-02-03 08:23hgbotCheckin
2016-02-03 08:23hgbotNote Added: 0083869
2016-02-03 08:23hgbotStatusscheduled => resolved
2016-02-03 08:23hgbotResolutionopen => fixed
2016-02-03 08:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1dd3c5f179c200f029b83750826e56a4f49b70e3 [^]
2016-02-03 08:23hgbotCheckin
2016-02-03 08:23hgbotNote Added: 0083870
2016-02-03 19:55marvintmReview Assigned ToOrekaria => marvintm
2016-02-03 19:55marvintmStatusresolved => closed
2016-02-03 19:55marvintmFixed in Version => RR16Q2
2016-02-04 12:18OrekariaStatusclosed => new
2016-02-04 12:18OrekariaResolutionfixed => open
2016-02-04 12:18OrekariaFixed in VersionRR16Q2 =>
2016-02-04 12:18OrekariaStatusnew => scheduled
2016-02-04 12:18OrekariaRelationship addedduplicate of 0031718
2016-02-04 12:18OrekariaStatusscheduled => resolved
2016-02-04 12:18OrekariaFixed in Version => RR16Q2
2016-02-04 12:18OrekariaResolutionopen => fixed
2016-02-04 12:19OrekariaStatusresolved => closed
2016-02-04 12:59guillermogilNote Added: 0083925
2016-02-04 12:59guillermogilStatusclosed => new
2016-02-04 12:59guillermogilResolutionfixed => open
2016-02-04 12:59guillermogilFixed in VersionRR16Q2 =>
2016-02-04 12:59guillermogilStatusnew => scheduled
2016-02-05 07:12hgbotCheckin
2016-02-05 07:12hgbotNote Added: 0083935
2016-02-05 07:12hgbotStatusscheduled => resolved
2016-02-05 07:12hgbotResolutionopen => fixed
2016-02-05 07:12hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1dd3c5f179c200f029b83750826e56a4f49b70e3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/113a53cabe0aa980ee441494f88914687f026582 [^]
2016-02-05 13:27guillermogilNote Added: 0083966
2016-02-05 13:27guillermogilNote Edited: 0083966bug_revision_view_page.php?bugnote_id=0083966#r10964
2016-02-05 13:28guillermogilNote Edited: 0083966bug_revision_view_page.php?bugnote_id=0083966#r10965
2016-02-08 11:30marvintmNote Added: 0083998
2016-02-08 11:30marvintmStatusresolved => new
2016-02-08 11:30marvintmResolutionfixed => open
2016-02-08 11:31marvintmStatusnew => scheduled
2016-02-09 10:10hgbotCheckin
2016-02-09 10:10hgbotNote Added: 0084032
2016-02-09 10:10hgbotStatusscheduled => resolved
2016-02-09 10:10hgbotResolutionopen => fixed
2016-02-09 10:10hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/113a53cabe0aa980ee441494f88914687f026582 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dee7a4bdfa2b7551266f699c6c233ad7d8689396 [^]
2016-02-15 08:55marvintmStatusresolved => closed
2016-02-15 08:55marvintmFixed in Version => RR16Q2
2016-08-12 12:24simbu94Relationship addedcauses 0033700

Notes
(0083640)
dmitry_mezentsev   
2016-01-27 17:20   
Not a big deal, but just to be aligned http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^]
(0083657)
Orekaria   
2016-01-28 12:44   
Fixed in https://issues.openbravo.com/view.php?id=31718 [^]
(0083659)
marvintm   
2016-01-28 13:40   
The fix for issue 31718 did not fix this problem, it is still happening.
(0083869)
hgbot   
2016-02-03 08:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1dd3c5f179c200f029b83750826e56a4f49b70e3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 03 12:52:36 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1dd3c5f179c200f029b83750826e56a4f49b70e3 [^]

Fixes issue 32021 : Overwrite Payment Method Side button List if already exists in list

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0083870)
hgbot   
2016-02-03 08:23   
Repository: tools/automation/pi-mobile
Changeset: 551bc1587541d05881316dbc2bc9fb78086563e4
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Feb 03 12:51:51 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/551bc1587541d05881316dbc2bc9fb78086563e4 [^]

Verifies issue 32021: Added automated test 'I32021_VerifyPaymentMethodWithMoreButton'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32021_VerifyPaymentMethodWithMoreButton.java
---
(0083925)
guillermogil   
2016-02-04 12:59   
The fix should not add the new button instead of removing the newly added button. Also a function should be created in order to avoid duplicated code.
(0083935)
hgbot   
2016-02-05 07:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 113a53cabe0aa980ee441494f88914687f026582
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Feb 05 11:41:39 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/113a53cabe0aa980ee441494f88914687f026582 [^]

Fixes issue 32021 : Discard Payment Method Side button List if already exists in list

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0083966)
guillermogil   
2016-02-05 13:27   
(edited on: 2016-02-05 13:28)
Why do you compare integers if they are not used? It should be a boolean filter
(0083998)
marvintm   
2016-02-08 11:30   
The call to _.find needs to be changed because now as it is defined is a bit confusing. Maybe it can be replaced by a normal for/while with an early exit via a break.
(0084032)
hgbot   
2016-02-09 10:10   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dee7a4bdfa2b7551266f699c6c233ad7d8689396
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 09 14:39:40 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dee7a4bdfa2b7551266f699c6c233ad7d8689396 [^]

Fixed issue 32021 : Discard Payment Method Side button List if already exists in list

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---