Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032008ModulesMulti-Dimensional Profit And Losspublic2016-01-26 10:262019-04-10 16:12
Reporterngarcia 
Assigned ToTriage Omni OMS 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket
OBNetwork customer
Regression introduced in release
Summary0032008: Generate Profit And Loss Fact Acct should be incremental
DescriptionGenerate Profit And Loss Fact Acct should be incremental. Currently it deletes all the entries from the OBDPL_FACT_ACCT_PL table and recalculates them again. As the records are obtained from the FACT_ACCT table that can have a big amount of data that is not going to be modified, it should only update the modified records
Steps To ReproduceIn an environment with a big amount of records in the FACT_ACCT table:
   Generate the cube and configure the accounts on it
   Launch the Generate Profit And Loss Fact Acct process and check it takes long
   Check it finishes
   Launch the Generate Profit And Loss Fact Acct process again and check it takes the same time
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0032010 new Triage Omni OMS Generate Profit And Loss Fact Acct takes too long with big amount of data in the FACT_ACCT table 
related to defect 0032840 closed AtulOpenbravo Generate Profit and Loss Fact Acct process creates records in obdpl_fact_acct_pl although there are no accounts defined in cube 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-26 10:26ngarciaNew Issue
2016-01-26 10:26ngarciaAssigned To => Triage Finance
2016-01-26 11:29ngarciaRelationship addedrelated to 0032010
2016-04-19 09:43ngarciaIssue Monitored: networkb
2016-05-03 14:17ngarciaRelationship addedrelated to 0032840
2019-04-10 16:01dmiguelezNote Added: 0111058
2019-04-10 16:03hgbotCheckin
2019-04-10 16:03hgbotNote Added: 0111059
2019-04-10 16:03hgbotStatusnew => resolved
2019-04-10 16:03hgbotResolutionopen => fixed
2019-04-10 16:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.financial.dimensionalpandlreport/rev/2d8ebc54b302492bee29984f1b5c4942576a9ae8 [^]
2019-04-10 16:03hgbotCheckin
2019-04-10 16:03hgbotNote Added: 0111060
2019-04-10 16:12vmromanosReview Assigned To => vmromanos
2019-04-10 16:12vmromanosNote Added: 0111061
2019-04-10 16:12vmromanosStatusresolved => closed

Notes
(0111058)
dmiguelez   
2019-04-10 16:01   
Tested in client's environment:
- Before, it took 8 hours for each execution
- Afterwards it takes 8 hours the first time and then 20 mins per each execution without data

Data shows the same values before and after the change.
(0111059)
hgbot   
2019-04-10 16:03   
Repository: erp/pmods/org.openbravo.financial.dimensionalpandlreport
Changeset: 2d8ebc54b302492bee29984f1b5c4942576a9ae8
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Apr 10 11:59:10 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.financial.dimensionalpandlreport/rev/2d8ebc54b302492bee29984f1b5c4942576a9ae8 [^]

Fixes Issue 32008. Process to fill fact table is incremental

* Added new flags in original and fact table to check if the records
  have been aggregated or if the aggregated information has been
  modified
* Added triggers in both tables to change the value of the new
  flags accordingly if the records are updated or deleted
* The new flags are null by default and 'Y' when the records
  have been aggregated or modified
* The process to generate the Fact table has been modified to
  use the new flags in the insert query and to update the new
  flags when the records have been aggregated

---
M src-db/database/model/tables/OBDPL_FACT_ACCT_PL.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src/org/openbravo/financial/dimensionalpandlreport/GenerateProfitAndLossFactAcctTable.java
A src-db/database/model/modifiedTables/FACT_ACCT.xml
A src-db/database/model/triggers/OBDPL_FACT_ACCT_PL_TRG.xml
A src-db/database/model/triggers/OBDPL_FACT_ACCT_TRG.xml
---
(0111060)
hgbot   
2019-04-10 16:03   
Repository: erp/pmods/org.openbravo.financial.dimensionalpandlreport
Changeset: 44fbabee37f9e980271988de0a6129d73da25618
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Apr 10 09:32:01 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.financial.dimensionalpandlreport/rev/44fbabee37f9e980271988de0a6129d73da25618 [^]

Related to Issue 32008: Updated module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0111061)
vmromanos   
2019-04-10 16:12   
Code review OK