Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031989Openbravo ERPA. Platformpublic2016-01-22 11:032016-08-25 15:08
Reportermaite 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031989: Wrong behavior in order/invoices grid in Add Payment process definition when having >100 records selected
DescriptionWhen you select >100 records, different inconsistent behavior is observed:

- only first 100 records are selected
- no proper filtering is performed
- when sorting, "loading data" infinite message is shown
Steps To Reproduce1. Access as System Administrator and configure "Grid filtering at window/tab/field level" to obtain better performance experience:
  * Tab: Order Invoices - Order Invoice P&E
  * Filter on change= no
2. Access Payment In window and create header record
3. Run Add details process and select 103 records, for example. Process and realize that all details have been properly added
4. Run reactivate selecting "Reactivate" option
5. Run Add details process again. Your 100 first records are loaded and selected. Scroll down and realize that next page is loaded but only 100 are selected instead of 103 (ERROR 1)
6. At this point, try to filter by an invoice document number (for example) which will return several results (you will need to change focus to execute filtering) and realize that only 2 records are obtained (ERROR 2)
7. Click on Invoice field to sort grid and realize that more values matching previous filtering criteria are obtained (ERROR 3)
8. Modify invoice document number value to run different filtering and "loading data" message will be shown (ERROR 4)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00320913.0PR16Q2 closed caristu The Order/Invoices grid in Add Details must always sort by selected records first 
related to defect 0032193 closed caristu Selection is not working properly in P&E grids having filter on change option set to N 
related to defect 0033622 closed caristu Wrong behavior in Select Payment Pick/Execute Window when having >100 records selected 
related to design defect 0036140 new Triage Platform Base Pick/edit grid is not compatible with high volumes: number of selected records is limited by MAX_PAGE_SIZE_INCREASE 
related to defect 0040381 closed alostale incorrect warn message logged by ReadOnlyDataSourceService for P&E  
causes defect 0035396 closed mcobas Cannot remove an orphan line from a return to vendor or a return from customer document 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-22 11:03maiteNew Issue
2016-01-22 11:03maiteAssigned To => platform
2016-01-22 11:03maiteWeb browser => Apple Safari
2016-01-22 11:03maiteModules => Core
2016-01-22 11:03maiteResolution time => 1455404400
2016-01-22 11:03maiteTriggers an Emergency Pack => No
2016-01-22 11:16maiteIssue Monitored: networkb
2016-01-22 11:16maiteWeb browserApple Safari => Apple Safari
2016-01-22 11:16maiteNote Added: 0083534
2016-01-22 12:30heccamIssue Monitored: heccam
2016-01-22 14:54maiteWeb browserApple Safari =>
2016-01-29 10:06alostaleStatusnew => acknowledged
2016-01-29 14:23caristuStatusacknowledged => scheduled
2016-01-29 14:23caristuAssigned Toplatform => caristu
2016-02-02 13:33caristuRelationship addedrelated to 0032091
2016-02-03 19:31hgbotCheckin
2016-02-03 19:31hgbotNote Added: 0083902
2016-02-03 19:31hgbotStatusscheduled => resolved
2016-02-03 19:31hgbotResolutionopen => fixed
2016-02-03 19:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/905bb6ff4ee73e47c6fe246490ba5fb6df11b7ea [^]
2016-02-03 19:32caristuReview Assigned To => alostale
2016-02-03 19:33caristuIssue Monitored: alostale
2016-02-05 08:46alostaleNote Added: 0083944
2016-02-05 08:46alostaleStatusresolved => closed
2016-02-05 08:46alostaleFixed in Version => 3.0PR16Q2
2016-02-11 11:55caristuRelationship addedrelated to 0032193
2016-03-17 10:55hudsonbotCheckin
2016-03-17 10:55hudsonbotNote Added: 0085101
2016-08-12 15:20caristuRelationship addedrelated to 0033622
2016-08-25 10:24hgbotCheckin
2016-08-25 10:24hgbotNote Added: 0089376
2016-08-25 10:48caristuNote Deleted: 0089376
2016-08-25 15:08hudsonbotCheckin
2016-08-25 15:08hudsonbotNote Added: 0089400
2016-08-25 15:08caristuNote Deleted: 0089400
2017-03-02 20:24markmm82Relationship addedcauses 0035396
2017-05-31 12:41caristuRelationship addedrelated to 0036140
2019-03-22 10:06alostaleRelationship addedrelated to 0040381

Notes
(0083534)
maite   
2016-01-22 11:16   
I can provide environment where problem is reproducible
(0083902)
hgbot   
2016-02-03 19:31   
Repository: erp/devel/pi
Changeset: 905bb6ff4ee73e47c6fe246490ba5fb6df11b7ea
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Feb 03 19:26:25 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/905bb6ff4ee73e47c6fe246490ba5fb6df11b7ea [^]

fixes issue 31989: Wrong behavior in P&E grids having > 100 records selected
After performing a filter/ordering action, the selected records could go out of the first page, causing the Add Payment process crash inside updateInvOrderTotal function (executed on grid load), because the selected record could not be found on the local data.
To avoid the problem now the ReadOnlyDataSource fetches all the selected records in the first page, increasing the page size if necessary. Together with this, all the P&E processes must ensure that the data is always ordered by showing first the selected records.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ReadOnlyDataSourceService.java
---
(0083944)
alostale   
2016-02-05 08:46   
code reviewed + tested
(0085101)
hudsonbot   
2016-03-17 10:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test