Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031965Openbravo ERPY. DBSourceManagerpublic2016-01-20 12:592016-03-17 10:55
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031965: Allow to load the model without standardizing the PLSQL code
DescriptionNow, when the database model is loaded using the platform.loadModelFromDatabase method using PostgreSQL database, the PLSQL code is standardized. This step is essential if the model is going to be exported, because otherwise changes would appear in the XML files that store ethe PLSQL code, even though they have not been changed by the user.

The standarization of the PLSQL code takes most of the time of the database model load. With the standarization loading the model takes around 24 seconds in a database with 563 tables, without it it takes around 8 seconds (66% faster).

It would be great if it were possible to decide whether the PLSQL code standardization should be done when loading the database model
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-20 12:59AugustoMauchNew Issue
2016-01-20 12:59AugustoMauchAssigned To => AugustoMauch
2016-01-20 12:59AugustoMauchOBNetwork customer => No
2016-01-20 12:59AugustoMauchModules => Core
2016-01-20 12:59AugustoMauchTriggers an Emergency Pack => No
2016-01-20 12:59AugustoMauchStatusnew => scheduled
2016-01-21 09:40AugustoMauchReview Assigned To => alostale
2016-01-21 09:40hgbotCheckin
2016-01-21 09:40hgbotNote Added: 0083487
2016-01-21 09:40hgbotStatusscheduled => resolved
2016-01-21 09:40hgbotResolutionopen => fixed
2016-01-21 09:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c6ee63dab444827f8593a1292e923bd351114378 [^]
2016-01-21 09:41hgbotCheckin
2016-01-21 09:41hgbotNote Added: 0083488
2016-01-21 09:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c6ee63dab444827f8593a1292e923bd351114378 [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/07a08db4cf3ae50659fa6ca74d6524a9c5ab6ad1 [^]
2016-01-21 09:41hgbotCheckin
2016-01-21 09:41hgbotNote Added: 0083489
2016-01-21 09:42AugustoMauchNote Added: 0083490
2016-01-25 10:21hgbotCheckin
2016-01-25 10:21hgbotNote Added: 0083577
2016-01-29 10:02alostaleNote Added: 0083719
2016-01-29 10:02alostaleStatusresolved => closed
2016-01-29 10:02alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085061
2016-03-17 10:55hudsonbotCheckin
2016-03-17 10:55hudsonbotNote Added: 0085078

Notes
(0083487)
hgbot   
2016-01-21 09:40   
Repository: erp/devel/pi
Changeset: c6ee63dab444827f8593a1292e923bd351114378
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jan 21 09:37:12 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c6ee63dab444827f8593a1292e923bd351114378 [^]

Fixes issue 31965: Enables loading the model without standardizing PLSQL code

The platform interface has now a method, loadModelFromDatabase(ExcludeFilter filter, boolean doPlSqlStandardization), that accepts a parameter to specify whether the PLSQL code standardization should be done when the database model is loaded. This method would be useful for those who want to load the model but that don't need to do anything related with the PLSQL code (for instance if they just want to use the model to disable/enable foreign keys and constraints).

Adds also tests to check that it is possible to load the database model with and without doing the PLSQL code standardization.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0083488)
hgbot   
2016-01-21 09:41   
Repository: erp/devel/dbsm-main
Changeset: 07a08db4cf3ae50659fa6ca74d6524a9c5ab6ad1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jan 21 09:19:56 2016 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/07a08db4cf3ae50659fa6ca74d6524a9c5ab6ad1 [^]

Fixes issue 31965: Enables loading the model without standardizing PLSQL code

The platform interface has now a method, loadModelFromDatabase(ExcludeFilter filter, boolean doPlSqlStandardization), that accepts a parameter to specify whether the PLSQL code standardization should be done when the database model is loaded. This method would be useful for those who want to load the model but that don't need to do anything related with the PLSQL code (for instance if they just want to use the model to disable/enable foreign keys and constraints).

---
M src/org/apache/ddlutils/Platform.java
M src/org/apache/ddlutils/platform/ModelLoader.java
M src/org/apache/ddlutils/platform/ModelLoaderBase.java
M src/org/apache/ddlutils/platform/PlatformImplBase.java
M src/org/apache/ddlutils/platform/postgresql/PostgreSqlModelLoader.java
---
(0083489)
hgbot   
2016-01-21 09:41   
Repository: erp/devel/dbsm-main
Changeset: b9fb3f1fc1d7312be377f6116fb8b5d237833453
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jan 21 09:26:05 2016 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/b9fb3f1fc1d7312be377f6116fb8b5d237833453 [^]

Related with issue 31965: Adds automated tests

The tests check that it is possible to load the database model with and without doing the PLSQL code standardization.

---
M src-test/src/org/openbravo/dbsm/test/base/DbsmTest.java
M src-test/src/org/openbravo/dbsm/test/model/ModelSuite.java
A src-test/model/plSqlStandardization/BASE_MODEL_WITH_FUNCTION.xml
A src-test/model/plSqlStandardization/BASE_MODEL_WITH_FUNCTION_NOT_STANDARDIZED.xml
A src-test/src/org/openbravo/dbsm/test/model/CheckPlSqlStandardizationOnModelLoad.java
---
(0083490)
AugustoMauch   
2016-01-21 09:42   
The fix has passed Try
(0083577)
hgbot   
2016-01-25 10:21   
Repository: erp/devel/pi
Changeset: 0171ef423986fd86378dc6d386bd918451f86df2
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jan 25 10:17:14 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0171ef423986fd86378dc6d386bd918451f86df2 [^]

Related with issue 31965: It is possible to skip the PLSQL standardization

A parameter has been added to SystemService.getModelFromDatabase to specify whether the PLSQL code standardization should be done.

---
M src/org/openbravo/service/system/SystemService.java
---
(0083719)
alostale   
2016-01-29 10:02   
code reviewed + tested
(0085061)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085078)
hudsonbot   
2016-03-17 10:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test