Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031952ModulesWarehouse Pickingpublic2016-01-19 17:262016-03-17 10:56
Reporterngarcia 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customer
Regression introduced in release
Summary0031952: Negative reservations are created when a picking list line is deleted if the reservation quantity is decreased before
DescriptionNegative reservations are created when a picking list line is deleted if the reservation quantity is decreased before
Steps To ReproduceAs group admin role:
   Create the Enable Stock Reservations preference
   Create a Sales Order
   Add 10 units for a product with stock to it and complete it
   Click on Manage Reservation and reserve the whole quantity as allocated
   Generate the Picking List but do not process it
   Go to the Sales Order an decrease the reserved amount
   Go to the Picking list and delete the line
   Go to the Sales order Reservation and check the reserved amount is negative
   
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0030027 new Triage Omni WMS Reservation related to a not processed Warehouse Picking should not be editable apart from Warehouse Picking flows. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-19 17:26ngarciaNew Issue
2016-01-19 17:26ngarciaAssigned To => Triage Finance
2016-01-19 17:26ngarciaResolution time => 1455836400
2016-01-19 17:27ngarciaRelationship addedrelated to 0030027
2016-01-19 17:27ngarciaIssue Monitored: networkb
2016-02-05 12:28aferrazStatusnew => scheduled
2016-02-05 12:28aferrazAssigned ToTriage Finance => aferraz
2016-02-05 14:00aferrazNote Added: 0083975
2016-02-05 14:01aferrazNote Added: 0083976
2016-02-05 14:34aferrazNote Edited: 0083975bug_revision_view_page.php?bugnote_id=0083975#r10971
2016-02-05 14:34aferrazNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10973
2016-02-08 14:16psanjuanNote Added: 0084003
2016-02-08 15:28psanjuanNote Edited: 0083975bug_revision_view_page.php?bugnote_id=0083975#r10984
2016-02-08 15:29psanjuanNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10985
2016-02-08 15:31psanjuanNote Edited: 0083975bug_revision_view_page.php?bugnote_id=0083975#r10986
2016-02-08 15:32psanjuanNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10987
2016-02-08 15:33psanjuanNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10988
2016-02-08 15:34psanjuanNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10989
2016-02-08 15:35psanjuanNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10990
2016-02-08 15:42psanjuanNote Edited: 0083975bug_revision_view_page.php?bugnote_id=0083975#r10991
2016-02-08 15:46psanjuanNote Added: 0084006
2016-02-08 15:47psanjuanNote Edited: 0083976bug_revision_view_page.php?bugnote_id=0083976#r10992
2016-02-08 15:48psanjuanNote Edited: 0084006bug_revision_view_page.php?bugnote_id=0084006#r10994
2016-02-15 19:20hgbotCheckin
2016-02-15 19:20hgbotNote Added: 0084220
2016-02-15 19:20hgbotStatusscheduled => resolved
2016-02-15 19:20hgbotResolutionopen => fixed
2016-02-15 19:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0301db6b51d57e7b804d5d0f8fff5259b87d4f94 [^]
2016-02-15 19:21dmiguelezReview Assigned To => dmiguelez
2016-02-15 19:21dmiguelezNote Added: 0084221
2016-02-15 19:21dmiguelezStatusresolved => closed
2016-03-17 10:56hudsonbotCheckin
2016-03-17 10:56hudsonbotNote Added: 0085141

Notes
(0083975)
aferraz   
2016-02-05 14:00   
(edited on: 2016-02-08 15:41)
Test plan I:

As group admin role:
   Create the Enable Stock Reservations preference
   Create a Sales Order
   Add 10 units for a product with stock and complete it
   Click on Manage Reservation and reserve the whole quantity as allocated
   Check that a stock reservation related to the sales order line has been created.
   Generate a direct Picking List but do not process it
   Go to the Sales Order an decrease the reserved amount
   Go to the Picking list and delete the line
   Go to the Sales order and check that stock reservation has been deleted

Repeat the same flow with more than one sales order line, therefore there is more than one stock reservation. Check that stock reservations are deleted.
(0083976)
aferraz   
2016-02-05 14:01   
(edited on: 2016-02-08 15:47)
Test plan II:

As group admin role:
   Create the Enable Stock Reservations preference
   Set RN-Dev locator as "Outbound" Storage Bin Type in Warehouse and Storage Bins window, Storage Bin tab.
   Create a Sales Order
   Add 10 units for a product with stock and complete it
   Click on Manage Reservation and reserve the whole quantity as allocated
   Check that a stock reservation related to the sales order line has been created.
   Generate an outbound Picking List but do not process it
   Go to the Sales Order an decrease the reserved amount
   Go to the "Outbond" Picking list, edit the line by using "Edit Item" process button and un-select it
   Go to the Sales order and check that stock reservation has been deleted
(0084003)
psanjuan   
2016-02-08 14:16   
Issue verified.
(0084006)
psanjuan   
2016-02-08 15:46   
(edited on: 2016-02-08 15:48)
Test Plan above verified.

Issue can be code reviewed and closed.

As a side note:

In the case of changing the reserved amount, regardless it should not be allowed to do so whenever a picking list has already been created, stock reservations related are now being deleted, therefore it is required to reserve the goods once again and generate the picking list once again.
(0084220)
hgbot   
2016-02-15 19:20   
Repository: erp/devel/pi
Changeset: 0301db6b51d57e7b804d5d0f8fff5259b87d4f94
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Feb 05 14:06:10 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0301db6b51d57e7b804d5d0f8fff5259b87d4f94 [^]

Fixes issue 31952: Avoid negative reservations

Set quantity to zero in case quantity + p_qty is less than zero when updating current m_reservation_stock in M_RESERVE_STOCK_MANUAL, to avoid create negative reservations.

---
M src-db/database/model/functions/M_RESERVE_STOCK_MANUAL.xml
---
(0084221)
dmiguelez   
2016-02-15 19:21   
Code Review + Testing Ok
(0085141)
hudsonbot   
2016-03-17 10:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test