Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031936Openbravo ERP04. Warehouse managementpublic2016-01-19 06:052016-03-17 10:55
Reporteryogaskarnik 
Assigned Tononofrancisco 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket40056
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031936: Physical Inventory - Create Inventory Count List does not work when quantity left blank
DescriptionCreate Inventory Count List does not consider all the products when quantity left blank.
Steps To Reproduce1. Login to pi
2. Go to Warehouse Management || Transaction || Physical Inventory
3. Create a new record - Organization=F&B US East Coast
4. Click on "Create Inventory Count List" and select "Inventory Count"=blank
5. Observe that the product="Energy Drink" does not appear in the lines
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-19 06:05yogaskarnikNew Issue
2016-01-19 06:05yogaskarnikAssigned To => Triage Finance
2016-01-19 06:05yogaskarnikOBNetwork customer => Yes
2016-01-19 06:05yogaskarnikModules => Core
2016-01-19 06:05yogaskarnikSupport ticket => 40056
2016-01-19 06:05yogaskarnikResolution time => 1453330800
2016-01-19 06:05yogaskarnikTriggers an Emergency Pack => No
2016-01-22 22:17nonofranciscoAssigned ToTriage Finance => nonofrancisco
2016-01-22 22:17nonofranciscoStatusnew => scheduled
2016-01-26 18:35nonofranciscoNote Added: 0083619
2016-01-27 04:27yogaskarnikNote Added: 0083630
2016-01-27 17:20nonofranciscoNote Added: 0083641
2016-01-29 09:40hgbotCheckin
2016-01-29 09:40hgbotNote Added: 0083714
2016-01-29 09:40hgbotStatusscheduled => resolved
2016-01-29 09:40hgbotResolutionopen => fixed
2016-01-29 09:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24252e1edbaac0fb1cf68143f0045d5f897de78f [^]
2016-01-29 09:40vmromanosReview Assigned To => vmromanos
2016-01-29 09:40vmromanosNote Added: 0083715
2016-01-29 09:40vmromanosStatusresolved => closed
2016-03-17 10:55hudsonbotCheckin
2016-03-17 10:55hudsonbotNote Added: 0085087

Notes
(0083619)
nonofrancisco   
2016-01-26 18:35   
This seems not to be an issue.

The product Energy Drink does not appears in lines after click on "Create Inventory Count List" because the product not does not exists in East Coast Warehouse.
Move some quantity of the product from West Coast Warehouse to East Coast Warehouse and do the process again.
Realize the product is in the lines.

Test Plan:

As Openbravo / F&B International Group Admin
Go to Warehouse Management || Transaction || Physical Inventory
Create a new record - Organization=F&B US East Coast
Click on "Create Inventory Count List" and select "Inventory Count"=blank
Observe that the product="Energy Drink" does not appear in the lines

Go to Stock Report
  Product: Energy Drink
  Verify the product is available only in US West Coast
  
Go to Goods Movements
  Create a new redord
    Organization: F&B Us Inc.
  Create a new line
    Product: Energy Drink
    Storage Bin: WC-0-0-0
    New Storage Bin: EC-0-0-0
    Movement quantity: 10
    Process the movement
    
Go to Stock Report
  Product: Energy Drink
  Verify the product is now available in US West Coast and US East Coast
    
Go to Warehouse Management || Transaction || Physical Inventory
Create a new record - Organization=F&B US East Coast
Click on "Create Inventory Count List" and select "Inventory Count"=blank

Notice the product Energy Drink appears in the lines.
(0083630)
yogaskarnik   
2016-01-27 04:27   
Sine the Product: Energy Drink does not have any stock in F&B US East Coast, the product should appear in the inventory count list. The wiki documentation (http://wiki.openbravo.com/wiki/Physical_Inventory#Header [^]) says -

Inventory quantity: Includes or excludes products on physical inventory depending on actual quantities. The options available are:
empty - all product on physical inventory will be shown regardless its quantity

Regardless of the quantity the product should appear in inventory count list.
(0083641)
nonofrancisco   
2016-01-27 17:20   
Test Plan:

As Openbravo / F&B International Group Admin
Go to Warehouse Management || Transaction || Physical Inventory
Create a new record - Organization=F&B US East Coast
Click on "Create Inventory Count List" and select "Inventory Count"=blank

Notice the product Energy Drink appears in the lines.
(0083714)
hgbot   
2016-01-29 09:40   
Repository: erp/devel/pi
Changeset: 24252e1edbaac0fb1cf68143f0045d5f897de78f
Author: Nono Carballo <f.carballo <at> nectus.com>
Date: Wed Jan 27 00:44:55 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/24252e1edbaac0fb1cf68143f0045d5f897de78f [^]

Fixes Issue 31936: The SQL query of M_INVENTORY_LISTCREATE store procedure was
tuned to take care about null values.

The SQL query to retrieve the products that will be part of the lines was tuned
to take care about null values in aset.isoneattrsetvalrequired field.
The line AND aset.isoneattrsetvalrequired = 'Y' was replaced with
AND COALESCE(aset.isoneattrsetvalrequired, '-') = 'Y'

---
M src-db/database/model/functions/M_INVENTORY_LISTCREATE.xml
---
(0083715)
vmromanos   
2016-01-29 09:40   
Code review + testing OK
(0085087)
hudsonbot   
2016-03-17 10:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test