Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031912Openbravo ERP02. Master data managementpublic2016-01-15 13:502016-06-17 19:37
ReporterVictorVillar 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031912: Not possible to delete a product under some circumstances
DescriptionNot possible to delete a product under some circumstances
Steps To ReproduceAs group admin role,
 Go to Product window,
    create a new one
   Go To cost tab:
      create a new one
      Permanent: Y

Try to delete it, you can not because the permanent cost register.

It should be possible to remove a product if it has not a document related.
Proposed SolutionIt should be possible to remove a permanent cost if product does not have a document related.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-15 13:50VictorVillarNew Issue
2016-01-15 13:50VictorVillarAssigned To => Triage Finance
2016-01-15 13:50VictorVillarModules => Core
2016-01-15 13:50VictorVillarResolution time => 1431900000
2016-01-15 13:50VictorVillarTriggers an Emergency Pack => No
2016-01-15 13:51VictorVillarIssue Monitored: networkb
2016-04-04 10:07aferrazTarget Version3.0PR16Q2 =>
2016-04-04 10:16VictorVillarResolution time1431900000 => 1463522400
2016-04-05 12:19aferrazAssigned ToTriage Finance => aferraz
2016-04-05 12:19aferrazAssigned Toaferraz => Triage Finance
2016-04-05 12:21aferrazAssigned ToTriage Finance => Sanjota
2016-04-13 14:45aferrazNote Added: 0085612
2016-04-13 14:51aferrazNote Edited: 0085612bug_revision_view_page.php?bugnote_id=0085612#r11766
2016-04-19 17:09aferrazAssigned ToSanjota => markmm82
2016-05-06 20:28markmm82Statusnew => scheduled
2016-05-09 16:46markmm82Note Added: 0086318
2016-05-09 17:23aferrazProposed Solution updated
2016-05-09 19:31aferrazNote Deleted: 0085612
2016-05-09 19:32aferrazProposed Solution updated
2016-05-10 11:53hgbotCheckin
2016-05-10 11:53hgbotNote Added: 0086345
2016-05-10 11:53hgbotStatusscheduled => resolved
2016-05-10 11:53hgbotResolutionopen => fixed
2016-05-10 11:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/719ef21233f6efcdae5b0fde9abd7ccff11a49bc [^]
2016-05-10 11:53hgbotCheckin
2016-05-10 11:53hgbotNote Added: 0086346
2016-05-10 11:54aferrazReview Assigned To => aferraz
2016-05-10 11:54aferrazNote Added: 0086347
2016-05-10 11:54aferrazStatusresolved => closed
2016-05-10 11:54aferrazFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087528
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087529

Notes
(0086318)
markmm82   
2016-05-09 16:46   
Test plan 1:
As group admin role,
   Go to Product window,
    create a new one
   Go To cost tab:
      create a new one
      Permanent: Y
   Try to delete it, see the product is removed.

Test plan 2:
As group admin role,
   Go to Product window,
    create a new one
   Go To cost tab:
      create a new one
      Permanent: Y
   Go to Sales Order window
      create a new one
      Create a line with the previously created product
   Try to delete it, you can not because the permanent cost register and the document related to the product (the created sales order).
(0086345)
hgbot   
2016-05-10 11:53   
Repository: erp/devel/pi
Changeset: 719ef21233f6efcdae5b0fde9abd7ccff11a49bc
Author: Mark <markmm82 <at> gmail.com>
Date: Mon May 09 10:27:19 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/719ef21233f6efcdae5b0fde9abd7ccff11a49bc [^]

Fixes issue 31912: It is not possible to delete a product with a permanent cost

When a product is removed, the M_COSTING trigger is fired in cascade to delete the related costs, and it don't allow to remove the existing permanents costings associated to the product. To allow to remove the product with permanent costs was modified the M_COSTING_TRG to remove the permanent costs if the product have not related documents.

---
M src-db/database/model/triggers/M_COSTING_TRG.xml
---
(0086346)
hgbot   
2016-05-10 11:53   
Repository: erp/devel/pi
Changeset: 4c7b579487bdc0355def3ceba730719405c47f05
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon May 09 20:16:33 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4c7b579487bdc0355def3ceba730719405c47f05 [^]

Related to issue 31912: Code review improvements

---
M src-db/database/model/triggers/M_COSTING_TRG.xml
---
(0086347)
aferraz   
2016-05-10 11:54   
Code review + Testing OK
(0087528)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087529)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test