Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031904Openbravo ERPA. Platformpublic2016-01-15 11:472016-03-17 10:54
Reportermaite 
Assigned Tocaristu 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket40127
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031904: "Filter on change" option set to N in Grid Configuration at Window/Tab/Field Level does not work
Description"Filter on change" option set to N in Grid Configuration at Window/Tab/Field Level does not work
Steps To Reproduce1. As System Administrator, access Grid Configuration at Window/Tab/Field Level and configure:
  * tab= Order Invoices - Order Invoice P&E
  * Filter on change= no
2. Logout and login
3. Access Payment In window, run Add Details process and clean default filtering criteria in Order/Invoice grid. Start typing any Invoice document number and realize that filtering is performed before change focus
Proposed SolutionFollowing changes provided by Augusto solve problem for standard windows, but still P&E tabs are not working with these changes:


--- a/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js
+++ b/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js
@@ -128,7 +128,7 @@
 
   init: function () {
     var field = this.grid.getField(this.name);
- if (field && field.gridProps && field.gridProps.filterOnChange === false) {
+ if (field && field.gridProps && field.gridProps.filterEditorProperties && field.gridProps.filterEditorProperties.filterOnChange === false) {
       this.actOnKeypress = false;
     }
     this.Super('init', arguments);
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0028284 closed AugustoMauch Grid Configuration for High Volume Windows 
related to design defect 0032053 acknowledged Triage Platform Base Grid Configuration -> Filter on change option applies only to text fields 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-15 11:47maiteNew Issue
2016-01-15 11:47maiteAssigned To => platform
2016-01-15 11:47maiteOBNetwork customer => Yes
2016-01-15 11:47maiteModules => Core
2016-01-15 11:47maiteSupport ticket => 40127
2016-01-15 11:47maiteResolution time => 1455231600
2016-01-15 11:47maiteTriggers an Emergency Pack => No
2016-01-15 11:49maiteProposed Solution updated
2016-01-15 11:49maiteIssue Monitored: networkb
2016-01-15 12:50alostaleStatusnew => acknowledged
2016-01-18 09:49caristuAssigned Toplatform => caristu
2016-01-18 09:49caristuStatusacknowledged => scheduled
2016-01-19 08:51hgbotCheckin
2016-01-19 08:51hgbotNote Added: 0083390
2016-01-19 08:51hgbotStatusscheduled => resolved
2016-01-19 08:51hgbotResolutionopen => fixed
2016-01-19 08:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4e7ab3c00b3c1147d8d540cd51a4f62193b0e94 [^]
2016-01-19 08:52caristuReview Assigned To => alostale
2016-01-19 08:52caristuIssue Monitored: alostale
2016-01-19 10:05caristuNote Added: 0083393
2016-01-29 09:48alostaleNote Added: 0083717
2016-01-29 09:48alostaleStatusresolved => closed
2016-01-29 09:48alostaleFixed in Version => 3.0PR16Q2
2016-01-29 09:56alostaleRelationship addedrelated to 0028284
2016-01-29 10:00alostaleRelationship addedrelated to 0032053
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085053

Notes
(0083390)
hgbot   
2016-01-19 08:51   
Repository: erp/devel/pi
Changeset: a4e7ab3c00b3c1147d8d540cd51a4f62193b0e94
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jan 19 08:50:03 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a4e7ab3c00b3c1147d8d540cd51a4f62193b0e94 [^]

fixes issue 31904: 'Filter on change' option set to N does not work

The text items were not accessing properly to the 'filter on change' property. For P&E grids an additional problem was happening: the value of a variable called actOnKeypress used to disable/enbale the filtering on change was being overriden by the evaluateDisplayLogicForGridColumns() function. Also, the filter when pressing enter was not being working neither because the editFormDefaults values were not being used properly in P&E.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0083393)
caristu   
2016-01-19 10:05   
Created new test into TestLink to track this functionality: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9984 [^]
(0083717)
alostale   
2016-01-29 09:48   
code reviewed

Tested with filter on changed active and inactive for standard window and P&E grid in text fields
(0085053)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test