Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031892Retail ModulesWeb POSpublic2016-01-14 13:402016-02-03 13:25
Reporterasiermartirena 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR15Q2
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031892: [SERQA 533]The void layaway process does not save the cash up id correctly in its payments
DescriptionWhen doing a void layaway for a partially paid layaway, the payments generated to inverse the original payment is not nested to the corresponding cash up.
Steps To ReproduceCreate a partially paid layaway.
Load the layaway and click "Void this Layaway" button on the menu.
Verify that the payment/s generated to void the layaway are not nested to the cash up.
Proposed SolutionApply the two backout files attached and then the diff related to this issue.
Additional Information
TagsSER-QA
Relationships
depends on backport 0031932RR15Q4.2 closed jorge-garcia [SERQA 533]The void layaway process does not save the cash up id correctly in its payments 
depends on backport 0031933RR15Q3.4 closed jorge-garcia [SERQA 533]The void layaway process does not save the cash up id correctly in its payments 
related to defect 0031673RR16Q1 closed ranjith_qualiantech_com [SERQA 350] Overpayment when void a layaway with payments 
Attached Filesdiff backout_5a86b446511dac5bd70a5c506e68af935e3f520a.diff (4,130) 2016-01-18 16:03
https://issues.openbravo.com/file_download.php?file_id=8935&type=bug
diff backout_a2bca65788926025e32362c85120ca7d63828f67.diff (3,705) 2016-01-18 16:03
https://issues.openbravo.com/file_download.php?file_id=8936&type=bug
diff issue_31892.diff (18,165) 2016-01-18 16:03
https://issues.openbravo.com/file_download.php?file_id=8937&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-14 13:40asiermartirenaNew Issue
2016-01-14 13:40asiermartirenaAssigned To => marvintm
2016-01-14 13:40asiermartirenaRegression introduced in release => RR15Q2
2016-01-14 13:40asiermartirenaTriggers an Emergency Pack => No
2016-01-14 13:52asiermartirenaRegression level => Production - Confirmed Stable
2016-01-18 13:45guilleaerSummaryThe void layaway process does not save the cash up id correctly in its payments => [SERQA 533]The void layaway process does not save the cash up id correctly in its payments
2016-01-18 13:46ageteTag Attached: SER-QA
2016-01-18 13:47ageteResolution time => 1453935600
2016-01-18 13:57guilleaerAssigned Tomarvintm => Retail
2016-01-18 13:57guilleaerStatusnew => acknowledged
2016-01-18 16:03jorge-garciaStatusacknowledged => scheduled
2016-01-18 16:03jorge-garciaAssigned ToRetail => jorge-garcia
2016-01-18 16:03asiermartirenaFile Added: backout_5a86b446511dac5bd70a5c506e68af935e3f520a.diff
2016-01-18 16:03asiermartirenaFile Added: backout_a2bca65788926025e32362c85120ca7d63828f67.diff
2016-01-18 16:03asiermartirenaFile Added: issue_31892.diff
2016-01-18 16:04asiermartirenaProposed Solution updated
2016-01-18 16:29guilleaerStatusscheduled => acknowledged
2016-01-18 16:29guilleaerStatusacknowledged => scheduled
2016-01-18 16:33jorge-garciaRelationship addedrelated to 0031673
2016-01-20 12:26marvintmSeveritycritical => major
2016-01-28 11:10hgbotCheckin
2016-01-28 11:10hgbotNote Added: 0083651
2016-01-28 11:10hgbotStatusscheduled => resolved
2016-01-28 11:10hgbotResolutionopen => fixed
2016-01-28 11:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a184201820c78c2b8472531c83fb365bdf46147f [^]
2016-01-28 11:11hgbotCheckin
2016-01-28 11:11hgbotNote Added: 0083652
2016-01-28 11:11hgbotCheckin
2016-01-28 11:11hgbotNote Added: 0083654
2016-01-29 08:46hgbotCheckin
2016-01-29 08:46hgbotNote Added: 0083702
2016-02-01 18:59guilleaerReview Assigned To => guilleaer
2016-02-01 18:59guilleaerStatusresolved => closed
2016-02-01 18:59guilleaerFixed in Version => RR16Q2
2016-02-03 13:25hgbotCheckin
2016-02-03 13:25hgbotNote Added: 0083888

Notes
(0083651)
hgbot   
2016-01-28 11:10   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a184201820c78c2b8472531c83fb365bdf46147f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 26 14:00:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a184201820c78c2b8472531c83fb365bdf46147f [^]

Fixed issue 31892: [SERQA 533]The void layaway process does not save the
cash up id correctly in its payments

The problem is tha the cashup id is not loaded to the voided payment of the
layaway.

A refactor has been made, and now, the payments are managed by the
handlepayments function.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessVoidLayaway.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0083652)
hgbot   
2016-01-28 11:11   
Repository: tools/automation/pi-mobile
Changeset: 71a410a3a15433089fbcb5824ce02b3922ac494a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 19 13:33:31 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/71a410a3a15433089fbcb5824ce02b3922ac494a [^]

Verifies issue 31892: [SERQA 533]The void layaway process does not save the
cash up id correctly in its payments

Added test I31892_VoidLayawayAndCashUp

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31892_VoidLayawayAndCashUp.java
---
(0083654)
hgbot   
2016-01-28 11:11   
Repository: tools/automation/pi-mobile
Changeset: 98eb278ebadfbe573b3fd472cb4c93f1ebb23962
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jan 28 09:49:39 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/98eb278ebadfbe573b3fd472cb4c93f1ebb23962 [^]

Related to issue 31892: [SERQA 533]The void layaway process does not save the
cash up id correctly in its payments

The test for this issue must have a consistent order to check the data in the
database.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31892_VoidLayawayAndCashUp.java
---
(0083702)
hgbot   
2016-01-29 08:46   
Repository: tools/automation/pi-mobile
Changeset: 36c4aac12c2f864c0370341a1addda034953223c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jan 28 15:53:11 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/36c4aac12c2f864c0370341a1addda034953223c [^]

Related to issue 31892: [SERQA 533]The void layaway process does not save the
cash up id correctly in its payments

Added test I31892_VoidLayawayWithoutOverpayment to test the backports in
15Q3, 15Q4 and 16Q1.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31892_VoidLayawayWithoutOverpayment.java
---
(0083888)
hgbot   
2016-02-03 13:25   
Repository: tools/automation/pi-mobile
Changeset: 86351e559aaff0ec21322a435b9833f04c3e4598
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jan 28 15:53:11 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/86351e559aaff0ec21322a435b9833f04c3e4598 [^]

Related to issue 31892: [SERQA 533]The void layaway process does not save the
cash up id correctly in its payments

Added test I31892_VoidLayawayWithoutOverpayment to test the backports in
15Q3, 15Q4 and 16Q1.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31892_VoidLayawayWithoutOverpayment.java
---