Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031890Localization Pack: SpainMulti Dimensional Tax Reportpublic2016-01-14 12:572016-01-14 13:06
Reportervmromanos 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tovmromanos
Support ticket39850
OBNetwork customerOBPS
Regression introduced in release
Summary0031890: Multidimensional Tax Report is empty report if the Tax Rate filter is used
DescriptionMultidimensional Tax Report is empty report if the Tax Rate filter is used. The tax rate name is passed as parameter instead of the ID
Steps To ReproduceAs group admin role:
   Launch the Multidimensinal Tax Report, configure the filters in order to get some values there
   Select one of the tax rates shown there
   Launch the report again with the same filters but adding the tax rate in the Tax Rate filter
   Check the report is empty
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031744 closed markmm82 Multidimensional Tax Report Cash VAT is empty report if the Tax Rate filter is used 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-14 12:57vmromanosNew Issue
2016-01-14 12:57vmromanosAssigned To => markmm82
2016-01-14 12:57vmromanosResolution time => 1453330800
2016-01-14 12:57vmromanosSupport ticket => 39850
2016-01-14 12:57vmromanosOBNetwork customer => Yes
2016-01-14 12:57vmromanosIssue generated from0031744
2016-01-14 12:57vmromanosRelationship addedrelated to 0031744
2016-01-14 12:58vmromanosStatusnew => scheduled
2016-01-14 13:03hgbotCheckin
2016-01-14 13:03hgbotNote Added: 0083296
2016-01-14 13:03hgbotStatusscheduled => resolved
2016-01-14 13:03hgbotResolutionopen => fixed
2016-01-14 13:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/4b2c4f56185e4371b09d2f23b8c4a57e198f97ac [^]
2016-01-14 13:06vmromanosReview Assigned To => vmromanos
2016-01-14 13:06vmromanosNote Added: 0083298
2016-01-14 13:06vmromanosStatusresolved => closed

Notes
(0083296)
hgbot   
2016-01-14 13:03   
Repository: erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30
Changeset: 4b2c4f56185e4371b09d2f23b8c4a57e198f97ac
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Jan 14 13:01:51 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoiceTaxReportEnhanced30/rev/4b2c4f56185e4371b09d2f23b8c4a57e198f97ac [^]

Fixed bug 31890: Tax and Withholding combo doesn't filter

Solution partially based on m.molina@nectus.com one.

Each time the Organization combo fire the onchange event, the Tax Rate combo is populated with Tax Rates for this organization. The HTML source code for the combo was incorrect: inside the option the value attribute was setted with the text of the Tax Rate instead of the tax rate ID.
For this reason when the report was used filtering by the Tax rate, an incorrect parameter was submitted and no results obtained.


The fixes properly populates the tax rate and withholding combos with ID and name.
It uses ScrollableResults and session clears to avoid running out of memory.
It uses LinkedHashMap to store the id-value in the right order.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/invoiceTaxReportEnhanced30/ad_reports/OBMTR30_InvoiceTaxReportJR.java
---
(0083298)
vmromanos   
2016-01-14 13:06   
Solution based on markmm82 one.

Code review + testing OK.

Available in Multidimensional Tax Report 3.0.100 (or higher)