Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031877Retail ModulesWeb POSpublic2016-01-14 08:282016-06-22 09:43
Reporterguillermogil 
Assigned Tomigueldejuana 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2015-09-24
Regression introduced in releaseRR15Q4
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/611f7cddcbd891a4fa95074875daf911972a77af [^]
Triggers an Emergency PackNo
Summary0031877: It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached
DescriptionIt is not possible to add twice the same verified return to the order altough the maximum quantity is not reached.

You can add partially a verified return and if you try to add it again partially WebPOS does nothing.
Steps To ReproduceComplete an order with 6 Avalanche Transceivers
Go to Verify Returns popup
Search that order
Add 2 Avalanche Transceivers
Go to Verify Returns popup again
Add 3 Avalanche Transceivers
Click OK button

On 15Q3 is allowed to add them. On 15Q4 when you click OK button it does nothing
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0032057RR16Q1 closed ranjith_qualiantech_com It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached 
depends on backport 0032058RR15Q4.2 closed ranjith_qualiantech_com It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached 
caused by defect 0030816 closed mario_castello It is possible to return the same ticket more than once 
causes defect 0033149 closed migueldejuana It is possible to add twice the same verified return partially to the order when the maximum quantity is reached 
Attached Filespatch issue 31877 Source 178.patch (909) 2016-01-14 14:49
https://issues.openbravo.com/file_download.php?file_id=8921&type=bug
patch issue 31877 Test 4892.patch (4,127) 2016-01-14 14:49
https://issues.openbravo.com/file_download.php?file_id=8922&type=bug
patch issue 31877 Return quantity issue + popup msg 256.patch (2,655) 2016-06-06 09:42
https://issues.openbravo.com/file_download.php?file_id=9493&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-14 08:28guillermogilNew Issue
2016-01-14 08:28guillermogilAssigned To => Retail
2016-01-14 08:28guillermogilResolution time => 1452898800
2016-01-14 08:28guillermogilRegression level => Production - QA Approved
2016-01-14 08:28guillermogilTriggers an Emergency Pack => No
2016-01-14 10:52OrekariaStatusnew => acknowledged
2016-01-14 11:42OrekariaDescription Updatedbug_revision_view_page.php?rev_id=10627#r10627
2016-01-14 11:46OrekariaSummaryIt is not possible to add twice the same verified return partially to the order altough the maximum quantity is not reached => [HGVOL] It is not possible to add twice the same verified return partially to the order even the maximum quantity is not reached
2016-01-14 11:46OrekariaSummary[HGVOL] It is not possible to add twice the same verified return partially to the order even the maximum quantity is not reached => [HGVOL] It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached
2016-01-14 11:48OrekariaSummary[HGVOL] It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached => It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached
2016-01-14 11:58guillermogilDescription Updatedbug_revision_view_page.php?rev_id=10629#r10629
2016-01-14 14:49ranjith_qualiantech_comFile Added: issue 31877 Source 178.patch
2016-01-14 14:49ranjith_qualiantech_comFile Added: issue 31877 Test 4892.patch
2016-01-18 07:23ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-01-18 07:23ranjith_qualiantech_comStatusacknowledged => scheduled
2016-01-20 06:34hgbotCheckin
2016-01-20 06:34hgbotNote Added: 0083423
2016-01-20 06:34hgbotStatusscheduled => resolved
2016-01-20 06:34hgbotResolutionopen => fixed
2016-01-20 06:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ca558e1f022db5b8d049ec36a2029b1bc21ba122 [^]
2016-01-20 06:34hgbotCheckin
2016-01-20 06:34hgbotNote Added: 0083425
2016-01-29 12:32guilleaerRegression date => 2015-09-24
2016-01-29 12:32guilleaerRegression introduced in release => RR15Q4
2016-01-29 12:32guilleaerRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/611f7cddcbd891a4fa95074875daf911972a77af [^]
2016-01-29 12:33guilleaerReview Assigned To => guilleaer
2016-01-29 12:33guilleaerNote Added: 0083722
2016-01-29 12:33guilleaerStatusresolved => closed
2016-01-29 12:33guilleaerFixed in Version => RR16Q1
2016-01-29 12:33guilleaerStatusclosed => new
2016-01-29 12:33guilleaerResolutionfixed => open
2016-01-29 12:33guilleaerFixed in VersionRR16Q1 =>
2016-01-29 12:34guilleaerStatusnew => scheduled
2016-01-29 12:34guilleaerStatusscheduled => resolved
2016-01-29 12:34guilleaerFixed in Version => RR16Q2
2016-01-29 12:34guilleaerResolutionopen => fixed
2016-01-29 12:34guilleaerStatusresolved => closed
2016-02-02 13:29hgbotCheckin
2016-02-02 13:29hgbotNote Added: 0083846
2016-02-02 13:29hgbotStatusclosed => resolved
2016-02-02 13:29hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ca558e1f022db5b8d049ec36a2029b1bc21ba122 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.returns/rev/515a9b97a64f2570e28ed28e14fd023ea2890f36 [^]
2016-02-03 09:14guilleaerNote Deleted: 0083846
2016-02-03 09:14guilleaerStatusresolved => closed
2016-02-15 16:10hgbotCheckin
2016-02-15 16:10hgbotNote Added: 0084208
2016-06-06 09:42ranjith_qualiantech_comFile Added: issue 31877 Return quantity issue + popup msg 256.patch
2016-06-06 09:52ranjith_qualiantech_comNote Added: 0087016
2016-06-06 09:52ranjith_qualiantech_comNote Edited: 0087016bug_revision_view_page.php?bugnote_id=0087016#r12320
2016-06-15 13:38dmitry_mezentsevRelationship addedcauses 0033149
2016-06-15 13:39dmitry_mezentsevRelationship addedcaused by 0030816
2016-06-16 14:56hgbotCheckin
2016-06-16 14:56hgbotNote Added: 0087346
2016-06-20 09:48migueldejuanaAssigned Toranjith_qualiantech_com => migueldejuana
2016-06-20 09:48migueldejuanaNote Added: 0087646
2016-06-20 09:48migueldejuanaStatusclosed => new
2016-06-20 09:48migueldejuanaResolutionfixed => open
2016-06-20 09:48migueldejuanaFixed in VersionRR16Q2 =>
2016-06-20 09:48migueldejuanaStatusnew => scheduled
2016-06-20 09:49migueldejuanaNote Added: 0087647
2016-06-20 09:49migueldejuanaStatusscheduled => resolved
2016-06-20 09:49migueldejuanaResolutionopen => fixed
2016-06-21 15:42hgbotCheckin
2016-06-21 15:42hgbotNote Added: 0087731
2016-06-21 16:45hgbotCheckin
2016-06-21 16:45hgbotNote Added: 0087738
2016-06-22 09:43marvintmStatusresolved => closed

Notes
(0083423)
hgbot   
2016-01-20 06:34   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: ca558e1f022db5b8d049ec36a2029b1bc21ba122
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 20 11:03:36 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ca558e1f022db5b8d049ec36a2029b1bc21ba122 [^]

Fixes issue 31877 : Verify Return Qty exceeds until Total Quantity reaches

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0083425)
hgbot   
2016-01-20 06:34   
Repository: tools/automation/pi-mobile
Changeset: 018fdd4355fa0778d2868dd50134c57be3dee0a2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 19 12:43:47 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/018fdd4355fa0778d2868dd50134c57be3dee0a2 [^]

Verifies issue 31877: Added automated test 'I31877_VerifyReturnQtyWithTotalQty'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I31877_VerifyReturnQtyWithTotalQty.java
---
(0083722)
guilleaer   
2016-01-29 12:33   
code reviewed and tested. Regression information filled
(0084208)
hgbot   
2016-02-15 16:10   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.returns
Changeset: 4dc503cdb1cbb9629047e8003423b1c74e00de08
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Jan 20 11:03:36 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.returns/rev/4dc503cdb1cbb9629047e8003423b1c74e00de08 [^]

Fixed issue 0032057 backport of issue 31877 : Verify Return Qty exceeds until Total Quantity reaches

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087016)
ranjith_qualiantech_com   
2016-06-06 09:52   
issue 31877 Return quantity issue + popup msg 256.patch attached
Previous Fix is not working below scenario,
Complete an order with 6 Avalanche Transceivers
Go to Verify Returns popup
Search that order
Add 4 Avalanche Transceivers
Process the order
Go to Verify Returns popup
Add 2 Avalanche Transceivers
Click OK button
Go to Verify Returns popup again
Add 2 Avalanche Transceivers
It should give an error, but its not showing it

For the above issue, fix is attached
and also,
error msg is replaced by popup msg
(0087346)
hgbot   
2016-06-16 14:56   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 324b8f0d0add63d5f66cecb7dbb4aec164a894db
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 07:45:25 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/324b8f0d0add63d5f66cecb7dbb4aec164a894db [^]

Related to issue 0031877: It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached

- Backout ca558e1f022d
- Solve regrssions chain with one fix

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087646)
migueldejuana   
2016-06-20 09:48   
Backout and fix regression avoiding creating more issues
(0087647)
migueldejuana   
2016-06-20 09:49   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 2aef76e761868a6e58b9c89fdb5b51522e6d59a4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 09:46:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/2aef76e761868a6e58b9c89fdb5b51522e6d59a4 [^] [^]

Fixed issue 0030816: It is possible to return the same ticket more than once

- Check all open orders when adding a verified return line to the ticket
- If we exceed the qty available to return the line is not added
- Manage correctly remaining qty, initial qty and selected qty

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---

Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 5c1446007fc8dd4339071363c1782db4347cec7e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 11:21:47 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5c1446007fc8dd4339071363c1782db4347cec7e [^] [^]

Fixed issue 0030816: It is possible to return the same ticket more than once

- Cover also lines with item in differents bins

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087731)
hgbot   
2016-06-21 15:42   
Repository: retail/backports/3.0RR16Q1.4/org.openbravo.retail.returns
Changeset: 236bfb3d8f345cdb13ae0b1bc628d29ebbbe751b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 07:45:25 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.returns/rev/236bfb3d8f345cdb13ae0b1bc628d29ebbbe751b [^]

Related to issue 0031877: It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached

- Backout ca558e1f022d
- Solve regrssions chain with one fix

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087738)
hgbot   
2016-06-21 16:45   
Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.returns
Changeset: 13cefac57bf5945a615e475455d2c84bc641ec46
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 07:45:25 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.returns/rev/13cefac57bf5945a615e475455d2c84bc641ec46 [^]

Related to issue 0031877: It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached

- Backout ca558e1f022d
- Solve regrssions chain with one fix

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---