Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031868Retail ModulesWeb POSpublic2016-01-08 10:222016-03-08 17:26
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelQA functional test
Regression date2015-12-17
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e9de6ef5d061f49607b8ed0cc66c37ac30c23f8 [^]
Triggers an Emergency PackNo
Summary0031868: Cash Management events are not filtered by the selected payment method
DescriptionWhen selecting a payment method in the cash management, only the cash management events with the same payment method must be show to be selected.
Steps To Reproduce1) Go to ERP
2) Go to Organization window
     In Vall Blanca Store, go to the Cash Management Events tab
     Create two cash management events with payment method type Wire Transfer (one for Deposits and one for Withdrawals)
3) Go to POS Terminal Type window
     Select one terminal type and go to Payment Method tab
     In payment method Card, check the fields Allow Withdrawals and Allow Deposits.
4) Login in one of the terminals of the terminal type
      Go to Cash Management and click in Card withdrawal button and enter a quantity.
      See that the cash management events are not correct.
     
     
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0031838 closed jorge-garcia Cash Management events are not filtered by the selected payment method 
Attached Filesdiff mgmtEvent16Q1.diff (9,581) 2016-01-21 12:22
https://issues.openbravo.com/file_download.php?file_id=8955&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-13 09:26jorge-garciaTypedefect => backport
2016-01-13 09:26jorge-garciaTarget Version => RR16Q1
2016-01-13 09:58jorge-garciaResolution time => 1452812400
2016-01-13 09:58jorge-garciaRegression level => QA functional test
2016-01-13 09:58jorge-garciaRegression date => 2015-12-17
2016-01-13 09:58jorge-garciaRegression introduced in release => main
2016-01-13 09:58jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e9de6ef5d061f49607b8ed0cc66c37ac30c23f8 [^]
2016-01-19 08:25guillermogilIssue Monitored: guillermogil
2016-01-19 14:02hgbotCheckin
2016-01-19 14:02hgbotNote Added: 0083399
2016-01-19 14:02hgbotStatusscheduled => resolved
2016-01-19 14:02hgbotResolutionopen => fixed
2016-01-19 14:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/147ed36767c11592745199f7ea187ed1d46f3d08 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/f5ec2fe1dca3b8301f2c9a20305e28ee9e973573 [^]
2016-01-19 17:52marvintmReview Assigned To => marvintm
2016-01-19 17:52marvintmStatusresolved => closed
2016-01-19 17:52marvintmFixed in Version => RR16Q1
2016-01-20 17:21marvintmNote Added: 0083468
2016-01-20 17:21marvintmStatusclosed => new
2016-01-20 17:21marvintmResolutionfixed => open
2016-01-20 17:21marvintmFixed in VersionRR16Q1 =>
2016-01-21 12:22guillermogilFile Added: mgmtEvent16Q1.diff
2016-01-21 12:22guillermogilNote Added: 0083496
2016-02-01 13:00OrekariaStatusnew => scheduled
2016-02-24 19:56hgbotCheckin
2016-02-24 19:56hgbotNote Added: 0084476
2016-02-24 19:56hgbotStatusscheduled => resolved
2016-02-24 19:56hgbotResolutionopen => fixed
2016-02-24 19:56hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/f5ec2fe1dca3b8301f2c9a20305e28ee9e973573 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/68fad334a9e2ab07d622488653acd4e75ee6da41 [^]
2016-02-24 19:58guilleaerAssigned Tojorge-garcia => guilleaer
2016-03-03 16:17marvintmStatusresolved => closed
2016-03-03 16:17marvintmFixed in Version => RR16Q1
2016-03-04 12:44jorge-garciaAssigned Toguilleaer => jorge-garcia
2016-03-04 12:44jorge-garciaNote Added: 0084730
2016-03-04 12:44jorge-garciaStatusclosed => new
2016-03-04 12:44jorge-garciaResolutionfixed => open
2016-03-04 12:44jorge-garciaFixed in VersionRR16Q1 =>
2016-03-04 12:44jorge-garciaStatusnew => scheduled
2016-03-08 09:31hgbotCheckin
2016-03-08 09:31hgbotNote Added: 0084804
2016-03-08 10:17marvintmStatusscheduled => resolved
2016-03-08 10:17marvintmFixed in Version => RR16Q1
2016-03-08 10:17marvintmResolutionopen => fixed
2016-03-08 11:50hgbotCheckin
2016-03-08 11:50hgbotNote Added: 0084816
2016-03-08 17:26marvintmStatusresolved => closed

Notes
(0083399)
hgbot   
2016-01-19 14:02   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal
Changeset: f5ec2fe1dca3b8301f2c9a20305e28ee9e973573
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 19 14:01:16 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/f5ec2fe1dca3b8301f2c9a20305e28ee9e973573 [^]

Fixed issue 31868: Cash Management events are not filtered by the selected
payment method

It's necessary to do some changes in the logic of the popup. Now, the popup only
shows the cash management events that coincides with the payment method
selected.

---
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmtkeyboard.js
---
(0083468)
marvintm   
2016-01-20 17:21   
The popup needs to filter not only by payment method, but also by currency.
(0083496)
guillermogil   
2016-01-21 12:22   
See diff attached for the currency check
(0084476)
hgbot   
2016-02-24 19:56   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal
Changeset: 68fad334a9e2ab07d622488653acd4e75ee6da41
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Feb 24 19:55:59 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/68fad334a9e2ab07d622488653acd4e75ee6da41 [^]

Fixed issue 31868, Backport of 31838: Now Cash Management popup only shows the cash management events that coincides with the selected payment method

---
M src/org/openbravo/retail/posterminal/term/CashMgmtDepositEvents.java
M src/org/openbravo/retail/posterminal/term/CashMgmtDropEvents.java
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmtkeyboard.js
---
(0084730)
jorge-garcia   
2016-03-04 12:44   
It's necessary to backport the sampledata also for the tests.
(0084804)
hgbot   
2016-03-08 09:31   
Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.sampledata
Changeset: b15ecaec43db32c031c9500db919deffc4a9aa49
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Mar 04 13:52:34 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.sampledata/rev/b15ecaec43db32c031c9500db919deffc4a9aa49 [^]

Related to issue 31868: Cash Management events are not filtered by the selected
payment method

Needed to add some cashmgmt events for USD payment methods.

---
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_CMEVENTS.xml
---
(0084816)
hgbot   
2016-03-08 11:50   
Repository: tools/automation/pi-mobile
Changeset: a9fa3831c78ed2d142aea1a687cd2494cbc96138
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Mar 08 09:58:37 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a9fa3831c78ed2d142aea1a687cd2494cbc96138 [^]

Related to issue 31868: Cash Management events are not filtered by the selected
payment method

Some tests needs to be changed due to the new functionality.

The affected tests are:
* CashManagementUSDDeposit
* I30543_CashManagementInCashUpReport
* I31707_CashMgmEventsWithMultiplePaymentMthd

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/CashManagementUSDDeposit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I30543_CashManagementInCashUpReport.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I31707_CashMgmEventsWithMultiplePaymentMthd.java
---