Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031867Openbravo ERPA. Platformpublic2016-01-12 18:502017-09-14 13:32
Reportermalsasua 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2014-03-05
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/a652f7e46643 [^]
Triggers an Emergency PackNo
Summary0031867: the trees in the application can not be updated when preference "Use classic popup tree" is enabled
Descriptionwhen a tree is displayed in classic mode (adding the preference "Use classic popup tree"), it can not be modified: if you move one element from one parent to other parent, and you close and open again the tree, the change has not been applied
Steps To Reproduce. configure the preference "Use classic popup tree"
. go to window "product category"
. create new record:
  . name: test
  . is summary: Y
. click in tree button
. move the product category "Bio" inside of "test" node
. close the popup
. open tree again
the element "Bio" is not displayed inside of "test" node
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00318843.0PR16Q1 closed caristu the trees in the application can not be updated when preference "Use classic popup tree" is enabled 
depends on backport 00318853.0PR15Q4.2 closed caristu the trees in the application can not be updated when preference "Use classic popup tree" is enabled 
depends on backport 00318863.0PR15Q3.5 closed caristu the trees in the application can not be updated when preference "Use classic popup tree" is enabled 
caused by feature request 00259063.0PR14Q2 closed AugustoMauch Tree Extension Project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-12 18:50malsasuaNew Issue
2016-01-12 18:50malsasuaAssigned To => platform
2016-01-12 18:50malsasuaModules => Core
2016-01-12 18:50malsasuaTriggers an Emergency Pack => No
2016-01-13 15:26alostaleRelationship addedrelated to 0031870
2016-01-13 15:26alostaleStatusnew => acknowledged
2016-01-13 18:33caristuRegression level => Production - Confirmed Stable
2016-01-13 18:33caristuRegression date => 2014-03-05
2016-01-13 18:33caristuRegression introduced in release => 3.0PR14Q2
2016-01-13 18:33caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/a652f7e46643 [^]
2016-01-13 18:35caristuAssigned Toplatform => caristu
2016-01-13 18:49caristuNote Added: 0083270
2016-01-13 18:49caristuFile Added: issue31870.diff
2016-01-14 10:26caristuStatusacknowledged => scheduled
2016-01-14 10:50caristuFile Deleted: issue31870.diff
2016-01-14 10:55hgbotCheckin
2016-01-14 10:55hgbotNote Added: 0083280
2016-01-14 10:55hgbotStatusscheduled => resolved
2016-01-14 10:55hgbotResolutionopen => fixed
2016-01-14 10:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e913a860b967fdafd039d5299335b12d25dc2010 [^]
2016-01-15 08:29alostaleRelationship addedcaused by 0025906
2016-01-15 09:54hgbotCheckin
2016-01-15 09:54hgbotNote Added: 0083328
2016-01-15 10:23caristuNote Added: 0083332
2016-01-15 10:23caristuNote Edited: 0083332bug_revision_view_page.php?bugnote_id=0083332#r10640
2016-01-15 11:19alostaleReview Assigned To => alostale
2016-01-15 11:19alostaleNote Added: 0083334
2016-01-15 11:19alostaleStatusresolved => closed
2016-01-15 11:19alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085044
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085048
2017-09-14 13:32caristuRelationship deletedrelated to 0031870

Notes
(0083270)
caristu   
2016-01-13 18:49   
The following error is displayed in the log after trying to move a node in "classic mode":

ERROR org.openbravo.base.exception.OBSecurityException - Entity ADTable is not directly readable, only id and identifier properties are readable, property ADTable.treeType is neither of these.
org.openbravo.base.exception.OBSecurityException: Entity ADTable is not directly readable, only id and identifier properties are readable, property ADTable.treeType is neither of these.

The problem is that some part of the code requires to be executed in admin mode. Attached the patch with the fix.
(0083280)
hgbot   
2016-01-14 10:55   
Repository: erp/devel/pi
Changeset: e913a860b967fdafd039d5299335b12d25dc2010
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Thu Jan 14 10:49:51 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e913a860b967fdafd039d5299335b12d25dc2010 [^]

fixes issue 31867: can not move tree nodes in classic mode

When moving tree nodes using the classic mode there is a point where the process tries to recover the tree type. This information is stored in the ADTable entity which can not be accessed by non system roles. To prevent this error now the part where the tree type is recovered is executed using the DAL admin mode.

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0083328)
hgbot   
2016-01-15 09:54   
Repository: erp/devel/pi
Changeset: a1e778618363e55a966e2305b5b65da03948d9b9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jan 15 09:53:17 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a1e778618363e55a966e2305b5b65da03948d9b9 [^]

related to issue 31867: code review improvement

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0083332)
caristu   
2016-01-15 10:23   
In this case an automated test case has not been created, taking into account that the classic mode uses old technology and that the new tree view is also available and it is most commonly used.

However a new test case has been created into TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9983 [^]
(0083334)
alostale   
2016-01-15 11:19   
code reviewed + tested
(0085044)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085048)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test