Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031859Openbravo ERP09. Financial managementpublic2016-01-11 13:332016-03-17 10:54
Reporterplujan 
Assigned Todmiguelez 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelQA functional test
Regression date2015-11-12
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b48e8a24dcb38c56e5d69ea76ca286fdc8e91192 [^]
Triggers an Emergency PackNo
Summary0031859: [PR16Q1] Add Products to a Characteristic never ends processing
DescriptionAfter selecting a record in the pick and execute pop up for the Characteristics, processing never ends (see attached screenshot)
Steps To ReproduceFailing step is step 5 of this test case: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8624 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00318753.0PR16Q1 closed dmiguelez [PR16Q1] Add Products to a Characteristic never ends processing 
caused by feature request 00308843.0PR16Q1 closed jonibc Improve Add Products to Characteristic Value 
Attached Filespng AddCharacteristics.png (45,152) 2016-01-11 13:33
https://issues.openbravo.com/file_download.php?file_id=8905&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-01-11 13:33plujanNew Issue
2016-01-11 13:33plujanAssigned To => Retail
2016-01-11 13:33plujanFile Added: AddCharacteristics.png
2016-01-11 13:33plujanOBNetwork customer => No
2016-01-11 13:33plujanTriggers an Emergency Pack => No
2016-01-11 14:15alostaleRelationship addedcaused by 0030884
2016-01-11 14:17alostaleRegression level => QA functional test
2016-01-11 14:17alostaleRegression date => 2015-11-12
2016-01-11 14:17alostaleRegression introduced in release => main
2016-01-11 14:17alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b48e8a24dcb38c56e5d69ea76ca286fdc8e91192 [^]
2016-01-11 14:17alostalePrioritynormal => immediate
2016-01-11 14:19plujanProjectRetail Modules => Openbravo ERP
2016-01-11 14:21plujanModules => Core
2016-01-11 14:21plujanAssigned ToRetail => Triage Finance
2016-01-11 14:21plujanCategoryWeb POS => 09. Financial management
2016-01-11 14:21plujanSummary[RR16Q1] Add Products to a Characteristic never ends processing => [PR16Q1] Add Products to a Characteristic never ends processing
2016-01-13 13:23dmiguelezNote Added: 0083237
2016-01-13 17:23vmromanosStatusnew => scheduled
2016-01-13 17:23vmromanosAssigned ToTriage Finance => dmiguelez
2016-01-13 17:39hgbotCheckin
2016-01-13 17:39hgbotNote Added: 0083260
2016-01-13 17:39hgbotStatusscheduled => resolved
2016-01-13 17:39hgbotResolutionopen => fixed
2016-01-13 17:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1799d7a3ea4a2acdeef4c4e070c0961579e981c4 [^]
2016-01-13 17:39hgbotCheckin
2016-01-13 17:39hgbotNote Added: 0083261
2016-01-13 17:42vmromanosReview Assigned To => vmromanos
2016-01-13 17:42vmromanosNote Added: 0083263
2016-01-13 17:42vmromanosStatusresolved => closed
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085039
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085040

Notes
(0083237)
dmiguelez   
2016-01-13 13:23   
Steps to reproduce:

1
Login to ERP system using below details:
-'Username': Openbravo
-'Password': openbravo
Then change the role to 'The White Valley Group Admin' role

2
Navigate to 'Master Data Management || Pricing || Discounts and Promotions' window
Open discount with name '3x2 Bottles' record in form view.
Change 'Included Products' selector to 'All excluding defined'.
Change 'Included Characteristics' selector to 'Only those defined'.
Save the record.

3
Go to tab 'Characteristics'.
Add a record with characteristic 'Battery Life' and Value '120h max'.
Save the record.

4
Navigate to 'Master Data Management || Product Setup || Product Characteristic' window
Select 'Battery Life' record.
Go to Tab 'Value', select the '120h Max' record, click on button 'Add Products'.

5
In the pick & execute process, select the record of product 'Light sticks'.
Push over 'Done' button.

6
Navigate to 'Master Data Management || Product Setup || Product Characteristic' window
Select 'Battery Life' record.
Go to Tab 'Value', select the '20h ' record, click on button 'Add Products'.
The product 'Light sticks', should have the characteristic value '120 max'.
(0083260)
hgbot   
2016-01-13 17:39   
Repository: erp/devel/pi
Changeset: 1799d7a3ea4a2acdeef4c4e070c0961579e981c4
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Jan 13 12:44:01 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1799d7a3ea4a2acdeef4c4e070c0961579e981c4 [^]

Fixes Issue 31859. Removes unnecessary code that makes the process fail with a NPE
if the global variable has not been initized yet.

---
M src/org/openbravo/event/ProductCharacteristicValueEventHandler.java
---
(0083261)
hgbot   
2016-01-13 17:39   
Repository: erp/devel/pi
Changeset: f8867ebd1935eeca7064950529e7aabf181d2e65
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jan 13 17:35:14 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f8867ebd1935eeca7064950529e7aabf181d2e65 [^]

Related to issue 31859: Updated copyright year

---
M src/org/openbravo/event/ProductCharacteristicValueEventHandler.java
---
(0083263)
vmromanos   
2016-01-13 17:42   
Code review OK
(0085039)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
(0085040)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test