0031842: Confusing fields: 'Allow overpayment' and 'Overpayment limit'

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031842

Retail Modules

Web POS

public

2016-01-08 12:42

2016-02-18 17:41

Reporter

adrianromero

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR16Q2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0031842: Confusing fields: 'Allow overpayment' and 'Overpayment limit'

Description

These two fields were defined for the feature request: 29868: Define change limit for cash methods but its meaning are confusing.

Steps To Reproduce

Just open the Terminal type windows and go to the tab "Payment Methods" where these fields are defined and to make it visible select a payment method of type "Cash".

1.- Allow overpayment is redundant. Basically if the overpayment limit is zero has the same behaviour as unchecking this field
2.- Overpayment limit actually means "Change limit" the maximum change allowed to be returned to a customer.

Proposed Solution

1.- "Allow overpayment". It is redundant and can be simulated setting the limit to zero.
     RR15Q4, RR16Q1: Hide the field from the backend UI. Change WebPOS to ignore this value, assume true
     RR16Q2: Remove the field and clean up code

2.- Rename "Overpayment limit" to "Overpayment / Change Limit" and make it visible for all payment methods.

3.- ModuleScript:
    In order to avoid garbage in the database and also protect any potential implementation that has a modified "Allow overpayment" value it must be considered to remove completely this field from the database, adjust the functionality and create an script that sets the change limit to zero in case "Allow overpayment" is unchecked.

4.- Update documentation.
Terminal Type
http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#POS_Terminal_Type_window [^]
Overpayment
http://wiki.openbravo.com/wiki/Retail:Web_POS_User_Guide#Overpayment [^]

Test cases:
- create a sale with cash and pay more. same with a non-cash payment method
- see related issue 31792. create that test
- verify that change limit is working
- adjust existing tests

Additional Information

Tags

No tags attached.

Relationships

related to	feature request	0029868		closed	adrianromero	Define change limit for cash methods
depends on	backport	0031846	RR16Q1	closed	ranjith_qualiantech_com	Confusing fields: 'Allow overpayment' and 'Overpayment limit'
depends on	backport	0031847	RR15Q4.2	closed	Retail	Confusing fields: 'Allow overpayment' and 'Overpayment limit'
blocks	defect	0031792		closed	simbu94	It is not possible to return in Cash if a payment with USA Cash does not allow overpayment