Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031840ModulesNot Posted Transactionspublic2016-01-08 10:242016-01-13 13:11
ReporterVictorVillar 
Assigned Tovmromanos 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0031840: Error Out of memory trying to open the Report not posted window
DescriptionError Out of memory trying to open the Report not posted window due to large amount of data
Steps To ReproduceError Out of memory trying to open the Report not posted window due to large amount of data
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033294 closed markmm82 Performance problem in Report Not Posted window due to large amount of data 
Attached Filespng without.png (141,761) 2016-01-13 09:45
https://issues.openbravo.com/file_download.php?file_id=8912&type=bug
png

png withfix.png (135,961) 2016-01-13 09:46
https://issues.openbravo.com/file_download.php?file_id=8913&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-01-08 10:24VictorVillarNew Issue
2016-01-08 10:24VictorVillarAssigned To => Triage Finance
2016-01-08 10:24VictorVillarResolution time => 1452380400
2016-01-08 10:24VictorVillarIssue Monitored: networkb
2016-01-11 09:32aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-01-13 09:41vmromanosStatusnew => scheduled
2016-01-13 09:41vmromanosAssigned ToAtulOpenbravo => vmromanos
2016-01-13 09:45vmromanosNote Added: 0083221
2016-01-13 09:45vmromanosFile Added: without.png
2016-01-13 09:46vmromanosFile Added: withfix.png
2016-01-13 09:59vmromanosNote Added: 0083222
2016-01-13 10:00hgbotCheckin
2016-01-13 10:00hgbotNote Added: 0083223
2016-01-13 10:00hgbotStatusscheduled => resolved
2016-01-13 10:00hgbotResolutionopen => fixed
2016-01-13 10:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.financialmgmt.accounting.report.notposted/rev/55c3cd412ff8f6aaea88838baa60784cb7a23f0f [^]
2016-01-13 10:02vmromanosNote Added: 0083224
2016-01-13 10:32vmromanosNote Edited: 0083222bug_revision_view_page.php?bugnote_id=0083222#r10597
2016-01-13 13:11aferrazReview Assigned To => aferraz
2016-01-13 13:11aferrazNote Added: 0083236
2016-01-13 13:11aferrazStatusresolved => closed
2016-06-16 17:05maiteRelationship addedrelated to 0033294

Notes
(0083221)
vmromanos   
2016-01-13 09:45   
I'm unable to reproduce this issue in my local computer even with the customer environment, probably due to my local configuration. However I have detected a place where we can have memory leak.

Find attached the memory consumption comparation before and after the fix, where we can notice around 900MB has been saved.
(0083222)
vmromanos   
2016-01-13 09:59   
(edited on: 2016-01-13 10:32)
Test plan:
 In an environment with great amount of transactions
 Login as Openbravo Admin
 Go to Reset Accounting. Set Delete Accounting = Y and press OK.
 Try to open the Report not posted window.
 Verify you get data
(0083223)
hgbot   
2016-01-13 10:00   
Repository: erp/mods/org.openbravo.financialmgmt.accounting.report.notposted
Changeset: 55c3cd412ff8f6aaea88838baa60784cb7a23f0f
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jan 13 09:50:15 2016 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.financialmgmt.accounting.report.notposted/rev/55c3cd412ff8f6aaea88838baa60784cb7a23f0f [^]

Fixed bug 31840: Error Out of memory trying to open the Report not posted

Using ScrollableResults and cleaning the session every 100 records keep the memory usage under control

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/financialmgmt/accounting/report/notposted/NotPostedDocumentsDataSource.java
---
(0083224)
vmromanos   
2016-01-13 10:02   
Fixed in module version 1.0.100 (or higher)
(0083236)
aferraz   
2016-01-13 13:11   
Code review OK