Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031838Retail ModulesWeb POSpublic2016-01-08 10:222016-02-03 20:01
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression levelQA functional test
Regression date2015-12-17
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e9de6ef5d061f49607b8ed0cc66c37ac30c23f8 [^]
Triggers an Emergency PackNo
Summary0031838: Cash Management events are not filtered by the selected payment method
DescriptionWhen selecting a payment method in the cash management, only the cash management events with the same payment method must be show to be selected.
Steps To Reproduce1) Go to ERP
2) Go to Organization window
     In Vall Blanca Store, go to the Cash Management Events tab
     Create two cash management events with payment method type Wire Transfer (one for Deposits and one for Withdrawals)
3) Go to POS Terminal Type window
     Select one terminal type and go to Payment Method tab
     In payment method Card, check the fields Allow Withdrawals and Allow Deposits.
4) Login in one of the terminals of the terminal type
      Go to Cash Management and click in Card withdrawal button and enter a quantity.
      See that the cash management events are not correct.
     
     
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031707 closed jorge-garcia [SERQA 470] Issue in cash management functionallity when there are more than one payent method. 
depends on backport 0031868RR16Q1 closed jorge-garcia Cash Management events are not filtered by the selected payment method 
Attached Filesdiff mgmtEventsPI.diff (8,847) 2016-01-21 12:18
https://issues.openbravo.com/file_download.php?file_id=8954&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-01-08 10:22jorge-garciaNew Issue
2016-01-08 10:22jorge-garciaAssigned To => jorge-garcia
2016-01-08 10:22jorge-garciaOBNetwork customer => No
2016-01-08 10:22jorge-garciaTriggers an Emergency Pack => No
2016-01-08 10:22jorge-garciaRelationship addedrelated to 0031707
2016-01-08 10:24jorge-garciaStatusnew => scheduled
2016-01-08 13:43hgbotCheckin
2016-01-08 13:43hgbotNote Added: 0083185
2016-01-08 13:43hgbotStatusscheduled => resolved
2016-01-08 13:43hgbotResolutionopen => fixed
2016-01-08 13:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/147ed36767c11592745199f7ea187ed1d46f3d08 [^]
2016-01-08 13:44hgbotCheckin
2016-01-08 13:44hgbotNote Added: 0083186
2016-01-13 09:25jorge-garciaStatusresolved => new
2016-01-13 09:25jorge-garciaResolutionfixed => open
2016-01-13 09:26jorge-garciaStatusnew => scheduled
2016-01-13 09:27jorge-garciaStatusscheduled => resolved
2016-01-13 09:27jorge-garciaResolutionopen => fixed
2016-01-13 09:29jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3e9de6ef5d061f49607b8ed0cc66c37ac30c23f8 [^]
2016-01-13 09:57jorge-garciaResolution time => 1452812400
2016-01-13 09:57jorge-garciaRegression level => QA functional test
2016-01-13 09:57jorge-garciaRegression date => 2015-12-17
2016-01-13 09:57jorge-garciaRegression introduced in release => main
2016-01-19 17:53marvintmReview Assigned To => marvintm
2016-01-19 17:53marvintmStatusresolved => closed
2016-01-19 17:53marvintmFixed in Version => RR16Q2
2016-01-20 17:22marvintmNote Added: 0083469
2016-01-20 17:22marvintmStatusclosed => new
2016-01-20 17:22marvintmResolutionfixed => open
2016-01-20 17:22marvintmFixed in VersionRR16Q2 =>
2016-01-21 12:18guillermogilFile Added: mgmtEventsPI.diff
2016-01-21 12:18guillermogilNote Added: 0083495
2016-01-29 10:19OrekariaStatusnew => scheduled
2016-02-03 08:38hgbotCheckin
2016-02-03 08:38hgbotNote Added: 0083872
2016-02-03 08:38hgbotCheckin
2016-02-03 08:38hgbotNote Added: 0083873
2016-02-03 08:39hgbotCheckin
2016-02-03 08:39hgbotNote Added: 0083874
2016-02-03 08:41jorge-garciaStatusscheduled => resolved
2016-02-03 08:41jorge-garciaFixed in Version => RR16Q2
2016-02-03 08:41jorge-garciaResolutionopen => fixed
2016-02-03 20:01marvintmStatusresolved => closed

Notes
(0083185)
hgbot   
2016-01-08 13:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 147ed36767c11592745199f7ea187ed1d46f3d08
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 08 10:30:20 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/147ed36767c11592745199f7ea187ed1d46f3d08 [^]

Fixed issue 31838: Cash Management events are not filtered by the selected
payment method

It's necessary to do some changes in the logic of the popup. Now, the popup only
shows the cash management events that coincides with the payment method
selected.

---
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmtkeyboard.js
---
(0083186)
hgbot   
2016-01-08 13:44   
Repository: tools/automation/pi-mobile
Changeset: b86e6084f6a806de3101a9593ccbe1c009745f7c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 08 11:56:17 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b86e6084f6a806de3101a9593ccbe1c009745f7c [^]

Verifies issue 31838: Cash Management events are not filtered by the selected
payment method

Added test I31838_FilterCashMgmtEventsByPaymentMethod

Added license to test I31707_CashMgmEventsWithMultiplePaymentMthd

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I31707_CashMgmEventsWithMultiplePaymentMthd.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I31838_FilterCashMgmtEventsByPaymentMethod.java
---
(0083469)
marvintm   
2016-01-20 17:22   
The popup needs to filter not only by payment method, but also by currency.
(0083495)
guillermogil   
2016-01-21 12:18   
See diff attached for the currency check
(0083872)
hgbot   
2016-02-03 08:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e9ee5173f14169a1c4eb98b23b0c843c7142ae56
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 29 12:33:02 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e9ee5173f14169a1c4eb98b23b0c843c7142ae56 [^]

Related to issue 31838: Cash Management events are not filtered by the selected
payment method

The cash management events must be filtered by currency also.

Now if a payment method doesn't have a valid cash management event, the button
for that payment method is not shown in the cash management keyboard.

---
M src/org/openbravo/retail/posterminal/term/CashMgmtDepositEvents.java
M src/org/openbravo/retail/posterminal/term/CashMgmtDropEvents.java
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/cashmgmtkeyboard.js
---
(0083873)
hgbot   
2016-02-03 08:38   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 56ccb3e084d362df192f3a59e246d74710b68214
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 29 12:29:23 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/56ccb3e084d362df192f3a59e246d74710b68214 [^]

Related to issue 31838: Cash Management events are not filtered by the selected
payment method

Needed to add some cashmgmt events for USD payment methods.

---
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_CMEVENTS.xml
---
(0083874)
hgbot   
2016-02-03 08:39   
Repository: tools/automation/pi-mobile
Changeset: d33272f26fdba7ed0c39b9d5d52d266444324968
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Feb 01 09:23:20 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d33272f26fdba7ed0c39b9d5d52d266444324968 [^]

Related to issue 31838: Cash Management events are not filtered by the selected
payment method

Some tests needs to be changed due to the new functionality.

The affected tests are:
* CashManagementUSDDeposit
* I30543_CashManagementInCashUpReport
* I31707_CashMgmEventsWithMultiplePaymentMthd

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/CashManagementUSDDeposit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I30543_CashManagementInCashUpReport.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I31707_CashMgmEventsWithMultiplePaymentMthd.java
---