0031836: Null Pointer Exception on Save again button of Errors While Importing POS Data

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031836

Retail Modules

Web POS

public

2016-01-08 09:49

2016-01-19 17:19

Reporter

gorkaion

Assigned To

mtaal

Priority

immediate

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

RR16Q2

Fixed in Version

Merge Request Status

Review Assigned To

migueldejuana

OBNetwork customer

Support ticket

Regression level

QA functional test

Regression date

2015-11-27

Regression introduced in release

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bc165573bb04 [^]

Triggers an Emergency Pack

Summary

0031836: Null Pointer Exception on Save again button of Errors While Importing POS Data

Description

If an Order fails to integrate and appear in the Errors While Importing POS Data. When clicking on the Save again button a Null Pointer Exception message appears.

Steps To Reproduce

1. ensure that the current period is closed (in Open/Close Period Control)
2. create a new receipt in the POS
3. check that the receipt appear in the Errors While Importing POS Data with period closed error.
4. Open the period again
5. Click on Save Again button of "Errors While Importing POS Data" window.
6. See that a Null Pointer Exception message popup appears and the order is not processed.

Proposed Solution

The real exception is thrown in the SaveDataActionHandler class of org.openbravo.retail.posterminal.

Based in the Data Type of the error record it has to search the java class that manages the json that has to be imported. Since the ExternalOrderLoaded was added there are 2 different classes implementing the "Order" entity. So the following line of code throws a WELD exception as it does not know which class to inject
syncProcess = syncProcesses.select(new DataSynchronizationProcess.Selector(type)).get();

This exception is catched in the last catch Exception block. After this catch the SaveDataActionHandler is returning a null that it is the reason of the NPE message.

2 fixes must be done:

* The execute method should never return null. It should return an empty JSON or preferably a JSON with the error message.
* When the java class that manages the json is loaded it should consider the case when more than one is present and should pick up one. Based on the json or setting up some priorities on the classes.

Additional Information