Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031816Openbravo ERPA. Platformpublic2016-01-04 18:102016-03-17 10:54
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031816: Same unused (disabled) code in 3 junit tests (DalQueryTest, DalTest, DynamicEntityTest)
DescriptionThe 3 java files mentioned above all have a similar code which still exists in the test but is disabled via an 'if (false)' block.

https://code.openbravo.com/erp/devel/pi/file/62e77eb7765d/src-test/src/org/openbravo/test/dal/DalQueryTest.java#l173 [^]

Either that test code should be fixed and re-activated of be removed. But keeping it disabled since a long time (merge back from modulary branch) isn't really useful.
Steps To ReproduceCheck 'Dead code' warning in eclipse for the 3 files specified in the summary.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0008708pi closed mtaal Make test cases side effect free 
blocks feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-01-04 18:10shuehnerNew Issue
2016-01-04 18:10shuehnerAssigned To => platform
2016-01-04 18:10shuehnerModules => Core
2016-01-04 18:10shuehnerTriggers an Emergency Pack => No
2016-01-04 18:10shuehnerRelationship addedblocks 0031477
2016-01-07 12:05alostaleStatusnew => acknowledged
2016-01-19 07:53alostaleRelationship addedrelated to 0008708
2016-01-19 07:53alostaleAssigned Toplatform => alostale
2016-01-19 07:54alostaleReview Assigned To => mtaal
2016-01-19 07:56hgbotCheckin
2016-01-19 07:56hgbotNote Added: 0083388
2016-01-19 07:56hgbotStatusacknowledged => resolved
2016-01-19 07:56hgbotResolutionopen => fixed
2016-01-19 07:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1e99517ffbe9ebbd8e81c238d57a2ed3d3d9783d [^]
2016-01-19 13:18mtaalNote Added: 0083397
2016-01-19 13:18mtaalStatusresolved => closed
2016-01-19 13:18mtaalFixed in Version => 3.0PR16Q2
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085052

Notes
(0083388)
hgbot   
2016-01-19 07:56   
Repository: erp/devel/pi
Changeset: 1e99517ffbe9ebbd8e81c238d57a2ed3d3d9783d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jan 19 07:54:44 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1e99517ffbe9ebbd8e81c238d57a2ed3d3d9783d [^]

fixed issue 31816: removed unused code

---
M src-test/src/org/openbravo/test/dal/DalQueryTest.java
M src-test/src/org/openbravo/test/dal/DalTest.java
M src-test/src/org/openbravo/test/dal/DynamicEntityTest.java
---
(0083397)
mtaal   
2016-01-19 13:18   
Reviewed
(0085052)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test