Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031807Retail ModulesWeb POSpublic2015-12-30 23:472016-02-16 12:50
Reportermtaal 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2Fixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031807: Remote data queries for product and business partner show one more than the data limit
DescriptionSee description and files related to linked issue:

Remaining topic:
I see the noted behavior still for customer search, so showing one too many and no message is displayed.

See the attachment. I set data limit for customers to 1 and remote customers to Y.

For products it works fine, although I don't like the message is too technical..

Please change the message to:
There is more data in the search results than can be displayed, narrow your search to get more precise results.
(or something similar, although this message is much longer so might give spacing issues, I don't think we should spend to much time on it)
Steps To ReproduceSet the limit data preferences for product and business partner to a value of 1. Search for products/bps, 2 are shown.

https://issues.openbravo.com/view.php?id=31212 [^] [^]

http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#Querying_performance [^] [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031398RR16Q1 closed migueldejuana remote data queries for product and business partner show one more than the data limit 
depends on backport 0031808RR16Q1 closed migueldejuana [16Q1.1] Remote data queries for product and business partner show one more than the data limit 
related to design defect 0032179 new Retail Filtering customers by first letter do 3 or 4 queries 
Attached Filespng Selection_138.png (75,787) 2016-02-08 20:34
https://issues.openbravo.com/file_download.php?file_id=9037&type=bug
png

png Selection_139.png (167,371) 2016-02-08 20:35
https://issues.openbravo.com/file_download.php?file_id=9038&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-12-30 23:47mtaalNew Issue
2015-12-30 23:47mtaalAssigned To => migueldejuana
2015-12-30 23:47mtaalTriggers an Emergency Pack => No
2015-12-30 23:48mtaalRelationship addedrelated to 0031398
2015-12-30 23:49mtaalStatusnew => scheduled
2015-12-30 23:49mtaalNote Added: 0083092
2016-02-05 12:00hgbotCheckin
2016-02-05 12:00hgbotNote Added: 0083962
2016-02-05 12:00hgbotStatusscheduled => resolved
2016-02-05 12:00hgbotResolutionopen => fixed
2016-02-05 12:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fc85fe73849491b65df56ee6fed47d9e1dad327a [^]
2016-02-05 12:01migueldejuanaNote Added: 0083963
2016-02-05 12:02migueldejuanaReview Assigned To => mtaal
2016-02-08 20:33mtaalNote Added: 0084018
2016-02-08 20:33mtaalStatusresolved => new
2016-02-08 20:33mtaalResolutionfixed => open
2016-02-08 20:34mtaalFile Added: Selection_138.png
2016-02-08 20:35mtaalFile Added: Selection_139.png
2016-02-10 08:23hgbotCheckin
2016-02-10 08:23hgbotNote Added: 0084067
2016-02-10 08:23hgbotStatusnew => resolved
2016-02-10 08:23hgbotResolutionopen => fixed
2016-02-10 08:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fc85fe73849491b65df56ee6fed47d9e1dad327a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bfd0f6eccef1d9230132a6fbc1de92fa02a791ca [^]
2016-02-10 08:27hgbotCheckin
2016-02-10 08:27hgbotNote Added: 0084068
2016-02-10 08:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bfd0f6eccef1d9230132a6fbc1de92fa02a791ca [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb364547ec801eef034ab7884ed7071102cf9b90 [^]
2016-02-10 08:33migueldejuanaRelationship addedrelated to 0032179
2016-02-10 09:41hgbotCheckin
2016-02-10 09:41hgbotNote Added: 0084070
2016-02-16 12:50mtaalNote Added: 0084244
2016-02-16 12:50mtaalStatusresolved => closed
2016-02-16 12:50mtaalFixed in Version => RR16Q2

Notes
(0083092)
mtaal   
2015-12-30 23:49   
Needs to be backported but warrants no emergency pack by itself
(0083962)
hgbot   
2016-02-05 12:00   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: fc85fe73849491b65df56ee6fed47d9e1dad327a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 05 11:59:37 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fc85fe73849491b65df56ee6fed47d9e1dad327a [^]

Fixed issue 0031807: Remote data queries for product and business partner show one more than the data limit

- Improve the message but don't do it too large

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0083963)
migueldejuana   
2016-02-05 12:01   
Not able to reproduce.
The message has been improved a bit. DO not enlarge it more.
(0084018)
mtaal   
2016-02-08 20:33   
Strange, I tested it:
- set product and customer data as remote
- set both product and customer limit to 2
- when I search for products I only see 2 (correct), but no message is shown (see screenshot)
- when I search for customers I see 3 (not correct, should be 2) and no message is shown (incorrect also).
(0084067)
hgbot   
2016-02-10 08:23   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: bfd0f6eccef1d9230132a6fbc1de92fa02a791ca
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 10 08:23:14 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/bfd0f6eccef1d9230132a6fbc1de92fa02a791ca [^]

Fixed issue 0031807: Remote data queries for product and business partner show one more than the data limit

- Remove unneeded trigger, it is done in the line above

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0084068)
hgbot   
2016-02-10 08:27   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eb364547ec801eef034ab7884ed7071102cf9b90
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 10 08:27:07 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb364547ec801eef034ab7884ed7071102cf9b90 [^]

Fixed issue 0031807: Remote data queries for product and business partner show one more than the data limit

- Add a trigger to execute rendering code.

We should do more than one query to search customers by letter. We show update ob-dal to support multiple value for startWith

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/customersadvancedsearch.js
---
(0084070)
hgbot   
2016-02-10 09:41   
Repository: tools/automation/pi-mobile
Changeset: 2fba0d4694aad5d896fe00901b2a8551997bb062
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Feb 10 09:41:18 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2fba0d4694aad5d896fe00901b2a8551997bb062 [^]

Related to issue 0031807: Remote data queries for product and business partner show one more than the data limit

- Complete a bit more I31212_SearchWithLimitPref test
- Check also labels of limit

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31212_SearchWithLimitPref.java
---
(0084244)
mtaal   
2016-02-16 12:50   
Reviewed and tested