Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0031774 | Openbravo ERP | Z. Others | public | 2015-12-11 12:53 | 2015-12-24 11:44 |
|
| Reporter | maite | |
| Assigned To | vmromanos | |
| Priority | immediate | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0PR15Q4.2 | Fixed in Version | 3.0PR15Q4.2 | |
| Merge Request Status | |
| Review Assigned To | aferraz |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0031774: Bank Statement Line description overwritten with GL Item's description when adding gl item transaction form Match Statement |
| Description | Bank Statement Line description overwritten with GL Item's description when adding gl item transaction form Match Statement |
| Steps To Reproduce | 1. Access Cuenta de Banco financial account, create new Bank Statement record
2. Add Bank Statement line setting any amount and Description as "bsl description". Process bank statement
3. Run "Match Statement" process and press Add Transaction button (+) from your line. Realize that Description field "bsl description"
4. Select any GL Item in the combo. Realize that Description field has been overwritten with GL Item's description
If you follow similar process in version prior to refctor (for example MP30.3) you can verify that description field is maintained |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | blocks | defect | 0031697 | 3.0PR16Q1 | closed | vmromanos | Bank Statement Line description overwritten with GL Item's description when adding gl item transaction form Match Statement |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2015-12-24 11:34 | aferraz | Type | defect => backport |
| 2015-12-24 11:34 | aferraz | Target Version | 3.0PR16Q1 => 3.0PR15Q4.2 |
| 2015-12-24 11:43 | hgbot | Checkin | |
| 2015-12-24 11:43 | hgbot | Note Added: 0082986 | |
| 2015-12-24 11:43 | hgbot | Status | scheduled => resolved |
| 2015-12-24 11:43 | hgbot | Resolution | open => fixed |
| 2015-12-24 11:43 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/ad230fc1c0f1641dec56661e756d54812ede9917 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/7b0f4c9357803c72b630d189a495a9d41457b603 [^] |
| 2015-12-24 11:43 | hgbot | Checkin | |
| 2015-12-24 11:43 | hgbot | Note Added: 0082987 | |
| 2015-12-24 11:43 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/7b0f4c9357803c72b630d189a495a9d41457b603 [^] => http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/e7edf739e0eddf3c0712fa6416852547d98ac9f0 [^] |
| 2015-12-24 11:43 | hgbot | Checkin | |
| 2015-12-24 11:43 | hgbot | Note Added: 0082988 | |
| 2015-12-24 11:44 | aferraz | Review Assigned To | => aferraz |
| 2015-12-24 11:44 | aferraz | Note Added: 0082992 | |
| 2015-12-24 11:44 | aferraz | Status | resolved => closed |
| 2015-12-24 11:44 | aferraz | Fixed in Version | => 3.0PR15Q4.2 |
|
Notes |
|
|
(0082986)
|
|
hgbot
|
|
2015-12-24 11:43
|
|
Repository: erp/backports/3.0PR15Q4.2
Changeset: 7b0f4c9357803c72b630d189a495a9d41457b603
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Dec 23 01:08:07 2015 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/7b0f4c9357803c72b630d189a495a9d41457b603 [^]
Fixes Issue 31774:Bank Statement Line description overwritten with GL Item's
or payment's description when adding gl item or payment in add transaction
of Match Statement Process.
This issue is fixed in two area's
1. Add Transaction Process Definition window in Match Statement.
2. Transaction Tab of Financial Account window.
Whenever there exists a description prior adding gl item or payment in above
both cases description is appended with either gl item description or
payment description.
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionOnChangePaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/GLItemTransactionActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
M src/org/openbravo/erpCommon/ad_callouts/SE_GLItem_Transaction.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java
---
|
|
|
|
(0082987)
|
|
hgbot
|
|
2015-12-24 11:43
|
|
Repository: erp/backports/3.0PR15Q4.2
Changeset: e7edf739e0eddf3c0712fa6416852547d98ac9f0
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Dec 23 18:48:11 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/e7edf739e0eddf3c0712fa6416852547d98ac9f0 [^]
Fixed bug 31774: code review improvements
In case of removing a gl item from a transaction, the part of the transaction's description related to the GL Item (and everything else afterwards) will be deleted. The part of the transaction's description before the GL Item description
will be always kept.
The same behavior is applied when adding a new transaction from the Financial Account window and from the Match Statement --> Add transaction process
In case of removing a payment, the behavior is similar to the GL Item described above. However, since the payment description doesn't follow a constant structure (like in the case of GL Item's description), it's very hard to detect the description on the fly. That means that the flow will only work just after saving the transaction or in the first change after loading the transaction, which are the common flows. If the user selects different payments without saving the record, the system will append the different payment's description to the transaction.
The getFinAccTransactionDescription() method:
1. won't append multiple times the same description.
2. will add an extra empty line only when it's something to be appended
3. will work fine when the transaction already has a description with multiple lines
4. control any possible exception and returns the text to be append (if not blank), or the original description
Applied jsbeautifier to ob-aprm-addTransaction.js
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/GLItemTransactionActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
M src/org/openbravo/erpCommon/ad_callouts/SE_GLItem_Transaction.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java
---
|
|
|
|
(0082988)
|
|
hgbot
|
|
2015-12-24 11:43
|
|
|
|
|
|
|