Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031738Openbravo ERP09. Financial managementpublic2015-11-13 14:152015-12-17 16:01
Reporterngarcia 
Assigned Toaferraz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q4.2Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031738: UniqueValidCombination modulescript is deactivating some account combinations and creating new ones when it should not
DescriptionUniqueValidCombination modulescript is deactivating some account combinations and creating new ones when it should not

- The problem is reproducible until 3.0PR15Q3.3 version, whenever an update.database is done
- It is only reproducible after 3.0PR15Q4 version if the upgrade is done from MP19 or a previous version due to the solution of the 30396 bug
Steps To ReproduceAs group admin Role (in a version previous to 3.0PR15Q4):
   Create a record in the General Ledger Configuration
   Add the Account type dimension to it and select an account tree already used in another General Ledger (F&B España, S.A. Account Account)
   Check a new account combination has been created for each element value in the tree but with the new General Ledger. This is correct
   Now deactivate all the accounting combinations related with the same Account (10000 - Capital social)

* Launch the ant smartbuild -Dlocal=no command and restart Tomcat

As group admin role:
   Check that for one of the general ledgers the account combination has been set as inactive and a new one has been created
Proposed SolutionThe selectDuplicates and updateValidCombinationDeactivateDuplicated functions in the UniqueValidCombination_data.xsql should group by c_acctschema_id
Additional Information
TagsApproved
Relationships
blocks defect 0031470 closed aferraz UniqueValidCombination modulescript is deactivating some account combinations and creating new ones when it should not 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-12-16 17:43vmromanosTypedefect => backport
2015-12-16 17:43vmromanosTarget Version => 3.0PR15Q4.2
2015-12-17 16:00vmromanosTag Attached: Approved
2015-12-17 16:00hgbotCheckin
2015-12-17 16:00hgbotNote Added: 0082838
2015-12-17 16:00hgbotStatusscheduled => resolved
2015-12-17 16:00hgbotResolutionopen => fixed
2015-12-17 16:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/8efd1130ca4652fe0be980adab2c2de6f6cb1e50 [^]
2015-12-17 16:01vmromanosNote Added: 0082840
2015-12-17 16:01vmromanosStatusresolved => closed

Notes
(0082838)
hgbot   
2015-12-17 16:00   
Repository: erp/backports/3.0PR15Q4.2
Changeset: 8efd1130ca4652fe0be980adab2c2de6f6cb1e50
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Dec 01 18:20:18 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.2/rev/8efd1130ca4652fe0be980adab2c2de6f6cb1e50 [^]

Fixes issue 31738: UniqueValidCombination modulescript is deactivating accounts

Add group by c_acctschema_id in selectDuplicates and updateValidCombinationDeactivateDuplicated queries in UniqueValidCombination modulescript.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/UniqueValidCombinationData.class
M src-util/modulescript/src/org/openbravo/modulescript/UniqueValidCombination_data.xsql
---
(0082840)
vmromanos   
2015-12-17 16:01   
Code review + testing (Oracle & Postgres) OK