Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031720Retail ModulesWeb POSpublic2015-12-15 13:402016-02-29 14:52
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031720: add the ability to Open/Close the store from Web POS
DescriptionWe need to be able to open and close the store from one terminal using Web POS.
Now, when the store is closed, we can set the Business Date and the store is open automatically but we cannot close the store from Web POS. We have to add a menu entry option to be able to close it.
It must work with Multiserver.
http://wiki.openbravo.com/wiki/Projects:Retail_Open_Close_Store_WebPOS [^]
Steps To ReproduceSee Description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate feature request 0031653 closed migueldejuana Support open/close store through the WebPOS frontend 
Attached Filesdiff issue31720.diff (46,075) 2015-12-18 13:50
https://issues.openbravo.com/file_download.php?file_id=8825&type=bug
png Selection_139.png (288,023) 2016-02-16 15:31
https://issues.openbravo.com/file_download.php?file_id=9067&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-15 13:40migueldejuanaNew Issue
2015-12-15 13:40migueldejuanaAssigned To => migueldejuana
2015-12-15 13:40migueldejuanaTriggers an Emergency Pack => No
2015-12-15 15:41migueldejuanaNote Added: 0082773
2015-12-15 15:41migueldejuanaNote Deleted: 0082773
2015-12-15 15:41migueldejuanaDescription Updatedbug_revision_view_page.php?rev_id=10474#r10474
2015-12-15 17:18migueldejuanaDescription Updatedbug_revision_view_page.php?rev_id=10475#r10475
2015-12-18 11:03migueldejuanaRelationship addedhas duplicate 0031653
2015-12-18 11:26migueldejuanaReview Assigned To => mtaal
2015-12-18 13:50migueldejuanaFile Added: issue31720.diff
2016-01-07 16:46hgbotCheckin
2016-01-07 16:46hgbotNote Added: 0083160
2016-01-07 16:46hgbotStatusnew => resolved
2016-01-07 16:46hgbotResolutionopen => fixed
2016-01-07 16:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/369da97888e52d19c28832ca3d53ad11aa855f2b [^]
2016-01-07 16:48hgbotCheckin
2016-01-07 16:48hgbotNote Added: 0083163
2016-01-07 16:48hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/369da97888e52d19c28832ca3d53ad11aa855f2b [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/5676ac06a443e3180703093a75ebd4dc0e0c8ddf [^]
2016-01-07 17:53hgbotCheckin
2016-01-07 17:53hgbotNote Added: 0083171
2016-01-07 17:53hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/5676ac06a443e3180703093a75ebd4dc0e0c8ddf [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/53dc06f6d62b400e914d294e9864c5e3c824adfd [^]
2016-01-13 12:30hgbotCheckin
2016-01-13 12:30hgbotNote Added: 0083233
2016-01-13 12:30hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/53dc06f6d62b400e914d294e9864c5e3c824adfd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/0dfc06cfe79d055fd5525adc13e9dafdd634fd1a [^]
2016-01-21 01:03hgbotCheckin
2016-01-21 01:03hgbotNote Added: 0083476
2016-01-21 06:30mtaalNote Added: 0083478
2016-01-21 06:30mtaalStatusresolved => closed
2016-01-21 06:30mtaalFixed in Version => RR16Q2
2016-02-12 11:12migueldejuanaStatusclosed => new
2016-02-12 11:12migueldejuanaResolutionfixed => open
2016-02-12 11:12migueldejuanaFixed in VersionRR16Q2 =>
2016-02-12 11:16hgbotCheckin
2016-02-12 11:16hgbotNote Added: 0084150
2016-02-12 11:16hgbotStatusnew => resolved
2016-02-12 11:16hgbotResolutionopen => fixed
2016-02-12 11:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/0dfc06cfe79d055fd5525adc13e9dafdd634fd1a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/22db983ada74fe7bfccbd304a785e99e5fd2b48b [^]
2016-02-14 13:43OrekariaNote Added: 0084169
2016-02-14 13:43OrekariaStatusresolved => new
2016-02-14 13:43OrekariaResolutionfixed => open
2016-02-14 13:43OrekariaStatusnew => scheduled
2016-02-14 13:43hgbotCheckin
2016-02-14 13:43hgbotNote Added: 0084170
2016-02-15 17:28hgbotCheckin
2016-02-15 17:28hgbotNote Added: 0084212
2016-02-15 17:28hgbotStatusscheduled => resolved
2016-02-15 17:28hgbotResolutionopen => fixed
2016-02-15 17:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/22db983ada74fe7bfccbd304a785e99e5fd2b48b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/52a584c4f8a3b12c42f7be7b74a15c3382c42249 [^]
2016-02-15 17:28hgbotCheckin
2016-02-15 17:28hgbotNote Added: 0084213
2016-02-16 15:31mtaalNote Added: 0084256
2016-02-16 15:31mtaalStatusresolved => new
2016-02-16 15:31mtaalResolutionfixed => open
2016-02-16 15:31mtaalFile Added: Selection_139.png
2016-02-16 16:14hgbotCheckin
2016-02-16 16:14hgbotNote Added: 0084257
2016-02-16 16:14hgbotStatusnew => resolved
2016-02-16 16:14hgbotResolutionopen => fixed
2016-02-16 16:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/52a584c4f8a3b12c42f7be7b74a15c3382c42249 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/ae8c6bf5824adae2c608dcece6952d2f812a2b0f [^]
2016-02-27 08:54mtaalNote Added: 0084575
2016-02-29 14:52mtaalNote Added: 0084599
2016-02-29 14:52mtaalStatusresolved => closed
2016-02-29 14:52mtaalFixed in Version => RR16Q2

Notes
(0083160)
hgbot   
2016-01-07 16:46   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 369da97888e52d19c28832ca3d53ad11aa855f2b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jan 07 16:42:21 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/369da97888e52d19c28832ca3d53ad11aa855f2b [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS

- to open the store in the terminal we just have to go throw "Set Business Date" existing process
- to close the store, when doing the last cashup of the store, a close store popup will be shown(just when preference enabled) and we need to press Ok.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/sessions/OpenSessionPOS.java
M src/org/openbravo/retail/sessions/SetBusinessDate.java
M web/org.openbravo.retail.sessions/js/components/BusinessDateModel.js
M web/org.openbravo.retail.sessions/js/components/loginhook.js
M web/org.openbravo.retail.sessions/js/countcash/countcash-model.js
A src/org/openbravo/retail/sessions/CountOpenTills.java
A src/org/openbravo/retail/sessions/OpenSessionPOSEntryProcessor.java
A src/org/openbravo/retail/sessions/SetBusinessDateEntryProcessor.java
A src/org/openbravo/retail/sessions/WebPOSCloseStore.java
A src/org/openbravo/retail/sessions/WebPOSCloseStoreEntryProcessor.java
---
(0083163)
hgbot   
2016-01-07 16:48   
Repository: tools/automation/pi-mobile
Changeset: 5676ac06a443e3180703093a75ebd4dc0e0c8ddf
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jan 07 16:48:24 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5676ac06a443e3180703093a75ebd4dc0e0c8ddf [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS

- Add a test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OpenCloseStoreFromWebPOS.java
---
(0083171)
hgbot   
2016-01-07 17:53   
Repository: tools/automation/pi-mobile
Changeset: 53dc06f6d62b400e914d294e9864c5e3c824adfd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jan 07 17:52:59 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/53dc06f6d62b400e914d294e9864c5e3c824adfd [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS

- Unneeded code

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OpenCloseStoreFromWebPOS.java
---
(0083233)
hgbot   
2016-01-13 12:30   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 0dfc06cfe79d055fd5525adc13e9dafdd634fd1a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jan 13 12:30:13 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/0dfc06cfe79d055fd5525adc13e9dafdd634fd1a [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS

- Add missing service

---
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
---
(0083476)
hgbot   
2016-01-21 01:03   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: af2d8cb7e8e9f972a31245b9ee2a5b891f78559e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jan 21 01:03:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/af2d8cb7e8e9f972a31245b9ee2a5b891f78559e [^]

Related to issue 31720 add the ability to Open/Close the store from Web POS
Change label of ref_list values

---
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0083478)
mtaal   
2016-01-21 06:30   
Reviewed and tested
(0084150)
hgbot   
2016-02-12 11:16   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 22db983ada74fe7bfccbd304a785e99e5fd2b48b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 12 11:16:10 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/22db983ada74fe7bfccbd304a785e99e5fd2b48b [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS

- Allow closing the store before starting a new cashup and giving these options
  * Close the store and logout
  * Close store and change business date
  * Continue login process

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0084169)
Orekaria   
2016-02-14 13:43   
Breaking integration
(0084170)
hgbot   
2016-02-14 13:43   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: c41162238b2089760b0b37f8e7bcceffe92a0ae6
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sun Feb 14 13:41:14 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/c41162238b2089760b0b37f8e7bcceffe92a0ae6 [^]

Backed out issue 31720, changeset: a9a30f203619. Breaking integration

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0084212)
hgbot   
2016-02-15 17:28   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: 52a584c4f8a3b12c42f7be7b74a15c3382c42249
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 15 17:27:16 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/52a584c4f8a3b12c42f7be7b74a15c3382c42249 [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS


- Allow closing the store before starting a new cashup and giving these options
* Close the store and logout
* Close store and change business date
* Continue login process

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0084213)
hgbot   
2016-02-15 17:28   
Repository: tools/automation/pi-mobile
Changeset: 362c345055436084606c7f42f956c8fad6b2e6ec
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 15 17:25:49 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/362c345055436084606c7f42f956c8fad6b2e6ec [^]

Related to issue 0031720: add the ability to Open/Close the store from Web POS

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/common/selenium/terminals/WebPOSExtModulesTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/OpenCloseStoreFromWebPOS.java
---
(0084256)
mtaal   
2016-02-16 15:31   
I am not sure if it all works correctly. A flow I tested:
- set that vallblanca can close store from webpos
- login as vallblanca on vbs-1
- create a ticket and submit it
- logout
- login, you get the question if you want to close the store
- say yes, the store is closed.
Still what should have happened with the ticket and its cashup?

See the screenshot, also the open tills status, the terminal is closed, still there are open tills.
(0084257)
hgbot   
2016-02-16 16:14   
Repository: erp/pmods/org.openbravo.retail.sessions
Changeset: ae8c6bf5824adae2c608dcece6952d2f812a2b0f
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 16 16:14:05 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sessions/rev/ae8c6bf5824adae2c608dcece6952d2f812a2b0f [^]

Fixed issue 0031720: add the ability to Open/Close the store from Web POS

- If we already have a session open, do not show the modal

---
M web/org.openbravo.retail.sessions/js/components/loginhook.js
---
(0084575)
mtaal   
2016-02-27 08:54   
http://wiki.openbravo.com/wiki/Projects:POS_Terminal_Session_Management/User_Guide#Close_Store [^]
(0084599)
mtaal   
2016-02-29 14:52   
Reviewed and tested