Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031718Retail ModulesGift cards and gift voucherspublic2015-12-15 12:292016-01-28 16:45
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket39643
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031718: [SERQA 486]payment type "gift card" is not displayed when there is 6 payment methods
DescriptionA)
When the amount of buttons added from external modules* matches the number of "core" buttons shown on the 'More payments' popup, external payments are not added to the 'More payments' popup.
E.g.: if the core configuration of a terminal includes 6 payments (4 payments will be directly shown and 2 will be on the 'More payments' popup), and the user installs the Giftcards and Vouchers module (which adds 2 payment buttons), the giftcard payment buttons will not be shown in web pos

B)
When one terminal is configured with 6 or more payment methods, the payment method gift card is not displayed
Steps To ReproduceA)

Install the Giftcards and Vouchers module
Configure a POS Terminal in backend with 6 payment methods.
Login in web pos.
Create a ticket and add a product.
Click on the Total Amount button to pay the ticket.
Verify that 4 payment method buttons are shown, plus the 'More' button.
Click on the 'More' button and verify that only the 2 payment methods defined in the terminal are shown. The 'Gift Card' and 'Gift Voucher' buttons are not shown.


B)

F&B
. in backoffice
 terminal VBS-1
  . add two new payment methods (name 1 and 2)
  

. in POS
 go to VBS-1 terminal
  . new receipt, add one line, pay it:

in the payment methods, if you click in "more..." button, gift card button is not displayed (see attachment)

in backoffice, deactivate the payment method with name 2
in POS, create new receipt, add one line and pay it:
in the payment methods, if you click "more..." button, Gift Card button is displayed (see attachment2)
Proposed SolutionA)
    The following code adds external buttons to the payment button list:
    enyo.forEach(this.sideButtons, function (sidebutton) {
      btncomponent = this.getButtonComponent(sidebutton);
      if (countbuttons++ < paymentsbuttons) {
        this.createComponent(btncomponent);
      } else if (this.sideButtons.length !== OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.length) {
        OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.push(btncomponent);
        dialogbuttons[sidebutton.command] = sidebutton.label;
      } else {
        dialogbuttons[sidebutton.command] = sidebutton.label;
      }
    }, this);

This condition:
} else if (this.sideButtons.length !== OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.length) {
should probably be removed, and the logic inside that else-if moved to the final else.
Additional Information
TagsSER-QA
Relationships
related to defect 0028629 closed marvintm Gifts and vouched payment method duplicate after a Cashup 
has duplicate defect 0031746 closed Retail [SERQA 486] Payment buttons added from external modules missing under certain circumstances 
has duplicate defect 0032021 closed ranjith_qualiantech_com Payment methods on "More" gets duplicated 
Attached Filespng 1.png (211,553) 2015-12-15 12:29
https://issues.openbravo.com/file_download.php?file_id=8810&type=bug
png

png 2.png (213,782) 2015-12-15 12:29
https://issues.openbravo.com/file_download.php?file_id=8811&type=bug
png

patch Issue #31718 Source 5548.patch (1,174) 2015-12-24 11:46
https://issues.openbravo.com/file_download.php?file_id=8852&type=bug
patch Issue #31718 Test 4852.patch (10,933) 2015-12-24 11:46
https://issues.openbravo.com/file_download.php?file_id=8853&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-15 12:29malsasuaNew Issue
2015-12-15 12:29malsasuaAssigned To => Retail
2015-12-15 12:29malsasuaOBNetwork customer => Yes
2015-12-15 12:29malsasuaSupport ticket => 39643
2015-12-15 12:29malsasuaResolution time => 1452898800
2015-12-15 12:29malsasuaTriggers an Emergency Pack => No
2015-12-15 12:29malsasuaFile Added: 1.png
2015-12-15 12:29malsasuaFile Added: 2.png
2015-12-17 09:56OrekariaStatusnew => acknowledged
2015-12-17 21:54OrekariaRelationship addedrelated to 0031746
2015-12-18 08:09aaroncaleroRelationship replacedhas duplicate 0031746
2015-12-18 13:03OrekariaDescription Updatedbug_revision_view_page.php?rev_id=10511#r10511
2015-12-18 13:03OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10513#r10513
2015-12-18 13:03OrekariaProposed Solution updated
2015-12-18 13:05OrekariaTag Attached: SER-QA
2015-12-18 14:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2015-12-18 14:42ranjith_qualiantech_comStatusacknowledged => scheduled
2015-12-24 11:46ranjith_qualiantech_comFile Added: Issue #31718 Source 5548.patch
2015-12-24 11:46ranjith_qualiantech_comFile Added: Issue #31718 Test 4852.patch
2015-12-28 18:04ageteSummarypayment type "gift card" is not displayed when there is 6 payment methods => [SERQA 486]payment type "gift card" is not displayed when there is 6 payment methods
2016-01-05 07:15hgbotCheckin
2016-01-05 07:15hgbotNote Added: 0083127
2016-01-05 07:15hgbotStatusscheduled => resolved
2016-01-05 07:15hgbotResolutionopen => fixed
2016-01-05 07:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/910c9f789e68c05f380ff8f7a095d18af1c05639 [^]
2016-01-05 07:16hgbotCheckin
2016-01-05 07:16hgbotNote Added: 0083129
2016-01-07 14:17OrekariaRelationship addedrelated to 0028629
2016-01-26 18:23marvintmReview Assigned To => marvintm
2016-01-26 18:23marvintmStatusresolved => closed
2016-01-26 18:23marvintmFixed in Version => RR16Q2
2016-01-28 12:44OrekariaRelationship addedhas duplicate 0032021
2016-01-28 13:41marvintmRelationship deletedhas duplicate 0032021
2016-01-28 15:27hgbotCheckin
2016-01-28 15:27hgbotNote Added: 0083678
2016-01-28 15:27hgbotStatusclosed => resolved
2016-01-28 15:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/910c9f789e68c05f380ff8f7a095d18af1c05639 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal/rev/4d9a826363945b1b244099295b1ab9ffc637ff7e [^]
2016-01-28 16:45marvintmStatusresolved => closed
2016-02-04 12:18OrekariaRelationship addedhas duplicate 0032021

Notes
(0083127)
hgbot   
2016-01-05 07:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 910c9f789e68c05f380ff8f7a095d18af1c05639
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 05 11:42:48 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/910c9f789e68c05f380ff8f7a095d18af1c05639 [^]

Fixes issue 31718 : Display Gift Card Payments if any Custom Payment added

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0083129)
hgbot   
2016-01-05 07:16   
Repository: tools/automation/pi-mobile
Changeset: 1b827f2ad17b44a434b06ee69a558ebbbd36619a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 05 11:42:33 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1b827f2ad17b44a434b06ee69a558ebbbd36619a [^]

Verifies issue 31718: Added automated test 'I31718_CheckGiftCardPaymentWithCustomPayment'

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I30879_CheckMorePaymentMethodDisplay.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I31718_CheckGiftCardPaymentWithCustomPayment.java
---
(0083678)
hgbot   
2016-01-28 15:27   
Repository: retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal
Changeset: 4d9a826363945b1b244099295b1ab9ffc637ff7e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 05 11:42:48 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4.2/org.openbravo.retail.posterminal/rev/4d9a826363945b1b244099295b1ab9ffc637ff7e [^]

Fixes issue 31718 : Display Gift Card Payments if any Custom Payment added

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---