Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031702Retail ModulesWeb POSpublic2015-12-14 12:382016-01-22 15:31
Reporteramayavicente 
Assigned Toguilleaer 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031702: [SERQA 463] Wrong size of the Payment Method button
DescriptionWrong size of the Payment Method button when the payment method name is longer than usual.
Steps To ReproduceCASE 1
1. Login in backoffice.
2. In the 'POS terminal' window, for 'VBS-1' change the payment method name 'Card' to 'CardAdministracion'
3. Log into the webpos, add a product and click the 'Total amount' button.
ERROR: see image 463_1

CASE 2
1. Login in backoffice.
2. In the 'POS terminal' window, for 'VBS-1' change the payment method name 'Card' to 'Card Administracion line2 line3'
3. Log into the webpos, add a product and click the 'Total amount' button.
ERROR: see image 463_2
Proposed Solution
Additional Information
TagsSER-QA
Relationships
depends on design defect 0031787RR16Q2 closed guilleaer [SERQA 463] Wrong size of the Payment Method button 
Attached Filesjpg 463_1.JPG (149,990) 2015-12-14 12:38
https://issues.openbravo.com/file_download.php?file_id=8806&type=bug
jpg

jpg 463_2.JPG (123,135) 2015-12-14 12:40
https://issues.openbravo.com/file_download.php?file_id=8807&type=bug
jpg

jpg GAL_screenshoot_Selection_179.jpg (249,542) 2015-12-18 09:49
https://issues.openbravo.com/file_download.php?file_id=8819&type=bug
jpg

jpg GAL_screenshoot_Selection_180.jpg (233,053) 2015-12-18 09:49
https://issues.openbravo.com/file_download.php?file_id=8820&type=bug
jpg

jpg GAL_screenshoot_Selection_181.jpg (209,110) 2015-12-18 09:49
https://issues.openbravo.com/file_download.php?file_id=8821&type=bug
jpg

jpg GAL_screenshoot_Selection_182.jpg (126,415) 2015-12-18 09:55
https://issues.openbravo.com/file_download.php?file_id=8822&type=bug
jpg

jpg GAL_screenshoot_Selection_183.jpg (115,599) 2015-12-18 09:56
https://issues.openbravo.com/file_download.php?file_id=8823&type=bug
jpg

patch 1683.patch (844) 2015-12-24 12:27
https://issues.openbravo.com/file_download.php?file_id=8854&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-14 12:38amayavicenteNew Issue
2015-12-14 12:38amayavicenteAssigned To => Retail
2015-12-14 12:38amayavicenteFile Added: 463_1.JPG
2015-12-14 12:38amayavicenteOBNetwork customer => Yes
2015-12-14 12:38amayavicenteResolution time => 1451257200
2015-12-14 12:38amayavicenteTriggers an Emergency Pack => No
2015-12-14 12:39amayavicenteTag Attached: SER-QA
2015-12-14 12:40amayavicenteFile Added: 463_2.JPG
2015-12-14 13:34OrekariaAssigned ToRetail => dbaz
2015-12-14 13:34OrekariaStatusnew => feedback
2015-12-14 14:36dbazNote Added: 0082723
2015-12-14 14:37dbazAssigned Todbaz => Retail
2015-12-14 14:37dbazStatusfeedback => new
2015-12-17 09:55OrekariaStatusnew => acknowledged
2015-12-17 12:46OrekariaStatusacknowledged => scheduled
2015-12-17 12:46OrekariaAssigned ToRetail => guilleaer
2015-12-18 09:34hgbotCheckin
2015-12-18 09:34hgbotNote Added: 0082864
2015-12-18 09:34hgbotStatusscheduled => resolved
2015-12-18 09:34hgbotResolutionopen => fixed
2015-12-18 09:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/dfe9bacdf582a3e61d84af46d37531efc63462ce [^]
2015-12-18 09:37guilleaerNote Added: 0082865
2015-12-18 09:49guilleaerFile Added: GAL_screenshoot_Selection_179.jpg
2015-12-18 09:49guilleaerFile Added: GAL_screenshoot_Selection_180.jpg
2015-12-18 09:49guilleaerFile Added: GAL_screenshoot_Selection_181.jpg
2015-12-18 09:55guilleaerFile Added: GAL_screenshoot_Selection_182.jpg
2015-12-18 09:56guilleaerFile Added: GAL_screenshoot_Selection_183.jpg
2015-12-18 09:58hgbotCheckin
2015-12-18 09:58hgbotNote Added: 0082866
2015-12-18 10:37hgbotCheckin
2015-12-18 10:37hgbotNote Added: 0082868
2015-12-22 13:35ageteNote Added: 0082937
2015-12-22 13:35ageteStatusresolved => new
2015-12-22 13:35ageteResolutionfixed => open
2015-12-24 12:27OrekariaAssigned Toguilleaer => Orekaria
2015-12-24 12:27OrekariaFile Added: 1683.patch
2015-12-28 10:16OrekariaStatusnew => scheduled
2015-12-28 18:57hgbotCheckin
2015-12-28 18:57hgbotNote Added: 0083028
2015-12-28 18:58OrekariaStatusscheduled => feedback
2015-12-28 18:58OrekariaStatusfeedback => scheduled
2015-12-28 18:58OrekariaAssigned ToOrekaria => Retail
2015-12-28 18:59OrekariaStatusscheduled => resolved
2015-12-28 18:59OrekariaFixed in Version => RR16Q1
2015-12-28 18:59OrekariaResolutionopen => fixed
2015-12-28 19:10OrekariaAssigned ToRetail => Orekaria
2015-12-29 10:10jorge-garciaReview Assigned To => jorge-garcia
2015-12-29 10:25jorge-garciaNote Added: 0083035
2015-12-29 10:25jorge-garciaStatusresolved => closed
2016-01-20 09:20hgbotCheckin
2016-01-20 09:20hgbotNote Added: 0083430
2016-01-20 09:21hgbotCheckin
2016-01-20 09:21hgbotNote Added: 0083431
2016-01-20 09:21hgbotCheckin
2016-01-20 09:21hgbotNote Added: 0083432
2016-01-20 09:23guilleaerAssigned ToOrekaria => guilleaer
2016-01-20 09:23guilleaerStatusclosed => new
2016-01-20 09:23guilleaerResolutionfixed => open
2016-01-20 09:23guilleaerFixed in VersionRR16Q1 =>
2016-01-20 09:24guilleaerStatusnew => scheduled
2016-01-20 09:24guilleaerStatusscheduled => resolved
2016-01-20 09:24guilleaerFixed in Version => RR16Q2
2016-01-20 09:24guilleaerResolutionopen => fixed
2016-01-22 15:31marvintmStatusresolved => closed

Notes
(0082723)
dbaz   
2015-12-14 14:36   
Let's try a visualization like this:

http://jsfiddle.net/yznwu6bt/3/ [^]
(0082864)
hgbot   
2015-12-18 09:34   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: dfe9bacdf582a3e61d84af46d37531efc63462ce
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Dec 18 09:33:37 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/dfe9bacdf582a3e61d84af46d37531efc63462ce [^]

Fixed issue 31702: Convenience function has been created to be executed when this buttons are created.

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0082865)
guilleaer   
2015-12-18 09:37   
I have done my best to try to avoid this fix, but the current design of the keyboard doesn't allow to use standard css practices to achieve the expected result.
A redesign of the keyboard is needed in order to use correct CSS techniques. For the moment i think that the commit is enough.
(0082866)
hgbot   
2015-12-18 09:58   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: efe18d0446d42e013251658e3ffe03009ba8482a
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Dec 18 09:57:55 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/efe18d0446d42e013251658e3ffe03009ba8482a [^]

Related to issue 31702: Add support to single column mode

---
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0082868)
hgbot   
2015-12-18 10:37   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: fac66079d461278fe4518af1b5625af99a6bd0b8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Dec 18 10:35:41 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/fac66079d461278fe4518af1b5625af99a6bd0b8 [^]

Related to issue 31702: If screen changes from 2 columns to 1 column buttons are redrawn

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
---
(0082937)
agete   
2015-12-22 13:35   
The solution given is incomplete:
- If the button is one of the mains, it shows: Administr...
- If the button is into the ones in MORE option, buttons larger, althow the word fits perfectly it still indicates Administr....
- If the payment method is selected, in the button More it indicates (Administration)
(0083028)
hgbot   
2015-12-28 18:57   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 76ff880538daf94c5301c4daa694cfb4a59fbda7
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Dec 28 18:56:18 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/76ff880538daf94c5301c4daa694cfb4a59fbda7 [^]

Related to issue 31702: Restored the default behaviour until the ellipsis algorithm is improved

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
---
(0083035)
jorge-garcia   
2015-12-29 10:25   
Will try to fix in RR16Q2 (see related issue).

Code review OK.
(0083430)
hgbot   
2016-01-20 09:20   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 8f193714833f9ed6210428eced76e7f8cb24a1dd
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jan 19 09:39:18 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/8f193714833f9ed6210428eced76e7f8cb24a1dd [^]

Related to issue 31702: Don't apply ellipsis for more popup buttons. Use original content now is optional

---
M web/org.openbravo.mobile.core/source/component/ob-keypadbasic.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0083431)
hgbot   
2016-01-20 09:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 33ebbe4d806c0229fab492743f34af3cd4a52fc7
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Jan 18 20:59:53 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33ebbe4d806c0229fab492743f34af3cd4a52fc7 [^]

Related to issue 31702: Use ellipsis in more button

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---
(0083432)
hgbot   
2016-01-20 09:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fd06dae345d796e4ed8d99da7a6ace9b2c912a95
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Jan 18 22:42:02 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd06dae345d796e4ed8d99da7a6ace9b2c912a95 [^]

Related to issue 31702: remove unwanted change

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---