Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031699Openbravo ERP09. Financial managementpublic2015-12-14 10:242015-12-15 23:49
Reportervmromanos 
Assigned Tovmromanos 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Topsanjuan
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031699: Payments after manual cash vat settlement
DescriptionWhen an invoice is paid after a manual cash VAT settlement has taken place, the system shouldn't add a "Cash VAT" record in Invoice | Tax | Cash VAT tab, because the cash vat amount has been already settled in the Manual Cash VAT Settlement.

This flow is not controlled right now, and the system wrongly creates a new record each time a new payment is registered to a settled invoice
Steps To ReproduceAs Group Admin:
1. Create a Cash VAT Sales Invoice with any line and process it. Do not pay it.
2. Create a new Manual Cash VAT Settlement for a date range that covers the previous invoice. Process it.
Verify a new Cash VAT record at Sales Invoice window has been created for the 100% (that's OK)
3. Now add a new payment for this invoice. Verify a new "Cash VAT" record has been automatically created. This is wrong: the system shouldn't create a new record because the cash vat has been already settled in the Manual Cash VAT Settlement document.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0028557 closed vmromanos Modules New process/management needed to settle unpaid VAT at a given date. 
Attached Filesdiff 31699.diff (2,794) 2015-12-14 11:19
https://issues.openbravo.com/file_download.php?file_id=8802&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-14 10:24vmromanosNew Issue
2015-12-14 10:24vmromanosAssigned To => vmromanos
2015-12-14 10:24vmromanosOBNetwork customer => No
2015-12-14 10:24vmromanosModules => Core
2015-12-14 10:24vmromanosTriggers an Emergency Pack => No
2015-12-14 10:24vmromanosRelationship addedrelated to 0028557
2015-12-14 10:25vmromanosStatusnew => scheduled
2015-12-14 11:17vmromanosNote Added: 0082699
2015-12-14 11:19vmromanosFile Added: 31699.diff
2015-12-14 14:38psanjuanNote Added: 0082724
2015-12-14 15:38hgbotCheckin
2015-12-14 15:38hgbotNote Added: 0082726
2015-12-14 15:38hgbotStatusscheduled => resolved
2015-12-14 15:38hgbotResolutionopen => fixed
2015-12-14 15:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/45c7d09e8fd077d8cbb909e28d60ff9568a4542e [^]
2015-12-14 15:38vmromanosReview Assigned To => psanjuan
2015-12-14 15:38vmromanosStatusresolved => closed
2015-12-15 23:49hudsonbotCheckin
2015-12-15 23:49hudsonbotNote Added: 0082790

Notes
(0082699)
vmromanos   
2015-12-14 11:17   
Test plan I:
As Group Admin:
1. Create a Cash VAT Sales Invoice with any line and process it. Do not pay it.
2. Create a new Manual Cash VAT Settlement for a date range that covers the previous invoice. Process it.
Verify a new Cash VAT record at Sales Invoice window has been created for the 100% (that's OK)
3. Now add a new partial payment for this invoice.
Verify no new Cash VAT record has been created

Test plan II:
As Group Admin:
1. Create a Cash VAT Sales Invoice with any line and process it. Do not pay it.
2. Create a new Manual Cash VAT Settlement for a date range that covers the previous invoice. Process it.
Verify a new Cash VAT record at Sales Invoice window has been created for the 100% (that's OK)
3. Now fully pay this invoice.
Verify no new Cash VAT record has been created
(0082724)
psanjuan   
2015-12-14 14:38   
Test Plan above verified. See also Test Link under the folder "Manual Cash VAT Settlement".
(0082726)
hgbot   
2015-12-14 15:38   
Repository: erp/devel/pi
Changeset: 45c7d09e8fd077d8cbb909e28d60ff9568a4542e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Dec 14 11:14:22 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/45c7d09e8fd077d8cbb909e28d60ff9568a4542e [^]

Fixed bug 31699: Payments after manual cash vat settlement

When an invoice has been already included in a Manual Cash VAT Settlement, the system won't create new Cash VAT management records when partially/fully paying the invoice.

---
M src/org/openbravo/erpCommon/utility/CashVATUtil.java
---
(0082790)
hudsonbot   
2015-12-15 23:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ecd185534f50 [^]
Maturity status: Test