Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031673Retail ModulesWeb POSpublic2015-12-09 13:312016-01-28 11:11
Reporteramayavicente 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031673: [SERQA 350] Overpayment when void a layaway with payments
DescriptionWhen voiding a layaway with partial payments, if an overpayment is done (for instance with card)the warning message is not raised.
Steps To Reproduce1. Create a layaway with partial payments.
2. Search the layaway crated previously in 'Layaways'.
3. In the menu, click 'Void this layaway' and before confirm, enter a payment higher than the outstanding amount in Card.
4. Confirm the void.
ERROR: The overpayment warning message is not raised and it should.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
related to defect 0031892 closed jorge-garcia [SERQA 533]The void layaway process does not save the cash up id correctly in its payments 
Attached Files? overpaymentWithLayaway.mp4 (2,402,548) 2015-12-09 13:42
https://issues.openbravo.com/file_download.php?file_id=8789&type=bug
png issue31673.png (222,793) 2015-12-29 09:47
https://issues.openbravo.com/file_download.php?file_id=8870&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2015-12-09 13:31amayavicenteNew Issue
2015-12-09 13:31amayavicenteAssigned To => Retail
2015-12-09 13:31amayavicenteResolution time => 1450825200
2015-12-09 13:31amayavicenteTriggers an Emergency Pack => No
2015-12-09 13:31amayavicenteTag Attached: SER-QA
2015-12-09 13:39OrekariaStatusnew => acknowledged
2015-12-09 13:42OrekariaFile Added: overpaymentWithLayaway.mp4
2015-12-09 13:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2015-12-09 13:43ranjith_qualiantech_comStatusacknowledged => scheduled
2015-12-11 04:19hgbotCheckin
2015-12-11 04:19hgbotNote Added: 0082662
2015-12-11 04:19hgbotStatusscheduled => resolved
2015-12-11 04:19hgbotResolutionopen => fixed
2015-12-11 04:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2bca65788926025e32362c85120ca7d63828f67 [^]
2015-12-11 04:19hgbotCheckin
2015-12-11 04:19hgbotNote Added: 0082663
2015-12-14 12:05OrekariaReview Assigned To => guilleaer
2015-12-29 09:11jorge-garciaReview Assigned Toguilleaer => jorge-garcia
2015-12-29 09:46jorge-garciaNote Added: 0083032
2015-12-29 09:46jorge-garciaStatusresolved => new
2015-12-29 09:46jorge-garciaResolutionfixed => open
2015-12-29 09:46jorge-garciaStatusnew => scheduled
2015-12-29 09:47jorge-garciaFile Added: issue31673.png
2015-12-29 12:22OrekariaTarget Version => RR16Q1
2015-12-29 13:16hgbotCheckin
2015-12-29 13:16hgbotNote Added: 0083047
2015-12-29 13:16hgbotStatusscheduled => resolved
2015-12-29 13:16hgbotResolutionopen => fixed
2015-12-29 13:16hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2bca65788926025e32362c85120ca7d63828f67 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5a86b446511dac5bd70a5c506e68af935e3f520a [^]
2015-12-29 13:16hgbotCheckin
2015-12-29 13:16hgbotNote Added: 0083048
2015-12-29 13:31jorge-garciaNote Added: 0083050
2015-12-29 13:31jorge-garciaStatusresolved => closed
2015-12-29 13:31jorge-garciaFixed in Version => RR16Q1
2016-01-18 16:33jorge-garciaRelationship addedrelated to 0031892
2016-01-28 11:11hgbotCheckin
2016-01-28 11:11hgbotNote Added: 0083653

Notes
(0082662)
hgbot   
2015-12-11 04:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a2bca65788926025e32362c85120ca7d63828f67
Author: Ranjith <ranjith <at> qualiantech.com>
Date: Fri Dec 11 08:48:20 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a2bca65788926025e32362c85120ca7d63828f67 [^]

Fixes issue 31673 : Show Overpayment Confirmation when voiding the layaway

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0082663)
hgbot   
2015-12-11 04:19   
Repository: tools/automation/pi-mobile
Changeset: 5ca59528208f359ad0ea543d9878183065d99563
Author: Ranjith <ranjith <at> qualiantech.com>
Date: Fri Dec 11 08:45:44 2015 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5ca59528208f359ad0ea543d9878183065d99563 [^]

Verifies issue 31673: Added automated test 'I31673_VoidLayawayCheckOverPayment'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31673_VoidLayawayCheckOverPayment.java
---
(0083032)
jorge-garcia   
2015-12-29 09:46   
When the user clicks in Done button and there is an overpayment voiding a layaway with a partial payment, a popup is shown. If you click the popup's cancel button, the Done button in the payment window is always disabled (see attached image).

Steps to reproduce:
1. Create a layaway with partial payments.
2. Search the layaway crated previously in 'Layaways'.
3. In the menu, click 'Void this layaway' and before confirm, enter a payment higher than the outstanding amount in Card.
4. Confirm the void and check that a warning popup is shown.
5. Click on Cancel button in the popup
6. Check that the Done button is disabled
(0083047)
hgbot   
2015-12-29 13:16   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5a86b446511dac5bd70a5c506e68af935e3f520a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Dec 29 17:45:31 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5a86b446511dac5bd70a5c506e68af935e3f520a [^]

Fixes issue 31673 : Show Overpayment Confirmation when voiding the layaway

Show/Enable Done Button while closing/hiding Overpayment Confirmation

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0083048)
hgbot   
2015-12-29 13:16   
Repository: tools/automation/pi-mobile
Changeset: eb06d936775fa92040b67172fe3494da03d6d27b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Dec 29 17:43:58 2015 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/eb06d936775fa92040b67172fe3494da03d6d27b [^]

Verifies issue 31673: Added automated test 'I31673_VoidLayawayCheckOverPayment'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31673_VoidLayawayCheckOverPayment.java
---
(0083050)
jorge-garcia   
2015-12-29 13:31   
Code review and testing OK
(0083653)
hgbot   
2016-01-28 11:11   
Repository: tools/automation/pi-mobile
Changeset: 5aa53c7682ed74d36798e38b9c255b0ae693b7a2
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Jan 22 09:48:43 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5aa53c7682ed74d36798e38b9c255b0ae693b7a2 [^]

Related to issue 31673: Added automated test I31673_VoidLayawayCheckOverPayment

Two of the cheks of the module has been deleted. Only need to check if the
button is enabled when the user close or cancel the overpayment popup.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31673_VoidLayawayCheckOverPayment.java
---