Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031672Openbravo ERPY. DBSourceManagerpublic2015-12-09 12:572016-03-17 10:54
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031672: Add tests to check that the exclusion filter works properly in DBSourceManager
DescriptionRight know it is possible to define a exclusion filter to ignore certain tables, views, triggers and functions when dbsourcemanager loads the model from the databaset (see [1]).

The proper behaviour of this functionality is not covered by tests.

[1] http://wiki.openbravo.com/wiki/ERP_2.50:Developers_Guide/How_To_Exclude_Database_Physical_Objects_From_Model [^]
Steps To Reproduce-
Proposed SolutionAdd tests to check the exclusion filter works properly
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0029800 closed AugustoMauch Allow excluding sequences from model 
related to feature request 0031685 closed AugustoMauch Allow using SQL wildcards in the dbsourmanager exclude filter 
Attached Files? 31672.export (13,663) 2015-12-09 16:05
https://issues.openbravo.com/file_download.php?file_id=8792&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-09 12:57AugustoMauchNew Issue
2015-12-09 12:57AugustoMauchAssigned To => platform
2015-12-09 12:57AugustoMauchModules => Core
2015-12-09 12:57AugustoMauchTriggers an Emergency Pack => No
2015-12-09 12:57AugustoMauchAssigned Toplatform => AugustoMauch
2015-12-09 16:05AugustoMauchFile Added: 31672.export
2015-12-10 09:19AugustoMauchRelationship addedrelated to 0029800
2015-12-11 10:12AugustoMauchStatusnew => scheduled
2015-12-11 10:13AugustoMauchNote Added: 0082673
2016-01-20 11:44AugustoMauchReview Assigned To => alostale
2016-01-20 12:23hgbotCheckin
2016-01-20 12:23hgbotNote Added: 0083440
2016-01-20 12:23hgbotStatusscheduled => resolved
2016-01-20 12:23hgbotResolutionopen => fixed
2016-01-20 12:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^]
2016-01-20 12:23hgbotCheckin
2016-01-20 12:23hgbotNote Added: 0083443
2016-01-20 12:23hgbotCheckin
2016-01-20 12:23hgbotNote Added: 0083444
2016-01-20 12:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^] => http://code.openbravo.com/erp/devel/dbsm-main/rev/06fa38a1654c2937a529b0d0a6e6b3dace012a21 [^]
2016-01-20 13:30AugustoMauchRelationship addedrelated to 0031685
2016-01-20 15:26alostaleNote Added: 0083463
2016-01-20 15:26alostaleStatusresolved => closed
2016-01-20 15:26alostaleFixed in Version => 3.0PR16Q2
2016-03-17 10:54hudsonbotCheckin
2016-03-17 10:54hudsonbotNote Added: 0085057

Notes
(0082673)
AugustoMauch   
2015-12-11 10:13   
Done, waiting for the PR16Q2 window to be open
(0083440)
hgbot   
2016-01-20 12:23   
Repository: erp/devel/pi
Changeset: 9cbd94b17c8829193f42387b92d1d098b018637f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jan 20 12:20:10 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9cbd94b17c8829193f42387b92d1d098b018637f [^]

Fixes issue 31672, fixes issue 29800, fixes issue 31685: Wildcards in exclusion

Updates the dbsourcemanager jar, now it is allowed to use wildcards in the exclusion filter (see [1]).

[1] http://wiki.openbravo.com/wiki/How_To_Exclude_Database_Physical_Objects_From_Model [^]

---
M src-db/database/lib/dbsourcemanager.jar
---
(0083443)
hgbot   
2016-01-20 12:23   
Repository: erp/devel/dbsm-main
Changeset: 0c8377991884c991dc23a2fb2a5a1a7117140021
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Dec 09 12:57:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/0c8377991884c991dc23a2fb2a5a1a7117140021 [^]

Related with issue 31672: Enables using a custom exclude filter in DbsmTest

---
M src-test/src/org/openbravo/dbsm/test/base/DbsmTest.java
---
(0083444)
hgbot   
2016-01-20 12:23   
Repository: erp/devel/dbsm-main
Changeset: 06fa38a1654c2937a529b0d0a6e6b3dace012a21
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Dec 09 16:00:11 2015 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/06fa38a1654c2937a529b0d0a6e6b3dace012a21 [^]

Fixes issue 31672: Adds tests to check the exclusion filter in dbsourcemanager

The new tests check that the exclude filter works properly for functions, tables, triggers and views. The tests check that the excluded database objects are indeed in the database, but that are not exported.

---
M src-test/src/org/openbravo/dbsm/test/model/ModelSuite.java
A src-test/model/excludeFilter/BASE_MODEL_WITH_FUNCTION.xml
A src-test/model/excludeFilter/BASE_MODEL_WITH_TABLE.xml
A src-test/model/excludeFilter/BASE_MODEL_WITH_TRIGGER.xml
A src-test/model/excludeFilter/BASE_MODEL_WITH_VIEW.xml
A src-test/model/excludeFilter/excludeFunction.xml
A src-test/model/excludeFilter/excludeTable.xml
A src-test/model/excludeFilter/excludeTrigger.xml
A src-test/model/excludeFilter/excludeView.xml
A src-test/src/org/openbravo/dbsm/test/model/CheckExcludeFilter.java
---
(0083463)
alostale   
2016-01-20 15:26   
reviewed and tested as part of project http://wiki.openbravo.com/wiki/Projects:Wildcard_Support_In_Exclude_Filter [^]
(0085057)
hudsonbot   
2016-03-17 10:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test