Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031667Retail ModulesWeb POSpublic2015-12-09 09:562015-12-28 19:12
Reporteralostale 
Assigned ToOrekaria 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031667: unlimited terminals licenses don't allow to create terminals
DescriptionWhen activating an instance with a license with unlimited POS terminals, it is not possible to have any active terminal.
Steps To Reproduce1. Obtain a license with unlimited POS terminals
2. In an retail instance login as system admin and try to activate the instance with that license
    -> ERROR: "The maximum number of allowed active POS terminals in this instance, -1, has been exceeded."
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00310903.0PR16Q1 closed alostale Openbravo ERP Implement Retail licensing model 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-12-09 09:56alostaleNew Issue
2015-12-09 09:56alostaleAssigned To => alostale
2015-12-09 09:56alostaleOBNetwork customer => No
2015-12-09 09:56alostaleTriggers an Emergency Pack => No
2015-12-09 10:18alostaleRelationship addedrelated to 0031090
2015-12-09 15:26alostaleReview Assigned To => AugustoMauch
2015-12-09 15:26alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10429#r10429
2015-12-09 15:49hgbotCheckin
2015-12-09 15:49hgbotNote Added: 0082622
2015-12-09 15:49hgbotStatusnew => resolved
2015-12-09 15:49hgbotResolutionopen => fixed
2015-12-09 15:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4191367d16e034a57be67b16bb7992397b536a56 [^]
2015-12-09 15:53hgbotCheckin
2015-12-09 15:53hgbotNote Added: 0082623
2015-12-09 21:38hudsonbotCheckin
2015-12-09 21:38hudsonbotNote Added: 0082630
2015-12-28 19:11OrekariaStatusresolved => closed
2015-12-28 19:11OrekariaFixed in Version => RR16Q1
2015-12-28 19:12OrekariaAssigned Toalostale => Orekaria

Notes
(0082622)
hgbot   
2015-12-09 15:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4191367d16e034a57be67b16bb7992397b536a56
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Dec 09 15:48:34 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4191367d16e034a57be67b16bb7992397b536a56 [^]

fixed bug 31667: unlimited terminals licenses don't allow to create terminals

  When checking if current license is unlimited (coded as -1L) the comparision
  was incorrectly performed by checking instance equality rather than values.

  Fixed by using Long.equals instead of == operator.

---
M src/org/openbravo/retail/posterminal/security/POSLicenseRestrictions.java
---
(0082623)
hgbot   
2015-12-09 15:53   
Repository: erp/devel/pi
Changeset: b9e9226226ff13472e87e02536da925c26f447c1
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Dec 09 15:52:19 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b9e9226226ff13472e87e02536da925c26f447c1 [^]

related to issue 31667: incorrect about message for unlimited POS licenses

  Unlimited POS licenses displayed incorrectly POS limitations: it showed -1 were
  it should be "unlimited".

  This was caused by incorrect Long comparsion.

  Fixed by using Long.equals instead of == operator.

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
---
(0082630)
hudsonbot   
2015-12-09 21:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/fd2b88269a44 [^]
Maturity status: Test