Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031655Retail ModulesWeb POSpublic2015-12-07 14:592016-06-16 08:40
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031655: WebPOS Synchronous transactions
DescriptionSee wiki page:
http://wiki.openbravo.com/wiki/Projects:WebPOS_Synchronized_Transactions [^]
Steps To ReproduceSee description
Proposed SolutionSee wiki page.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0030897 closed fmolina Inactive storage bin considered when POS Order synchronized 
depends on feature request 0032899RR16Q3 closed mtaal Provide a base class which implements default offline and online behavior in multi-server environments 
blocks defect 0032162 feedback Retail Finish the 'I30897_InactiveStorageBinConsidered' test 
causes defect 0041178pi new Retail There is two references to Web POS in Mobile Core code 
Attached Filesdiff 1505-mobile.diff (107,464) 2016-05-15 16:48
https://issues.openbravo.com/file_download.php?file_id=9414&type=bug
diff 1505-core.diff (64,585) 2016-05-15 16:48
https://issues.openbravo.com/file_download.php?file_id=9415&type=bug
diff 1505-retail.diff (83,686) 2016-05-15 16:48
https://issues.openbravo.com/file_download.php?file_id=9416&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-12-07 14:59mtaalNew Issue
2015-12-07 14:59mtaalAssigned To => mtaal
2015-12-07 14:59mtaalTriggers an Emergency Pack => No
2016-02-04 11:26hgbotCheckin
2016-02-04 11:26hgbotNote Added: 0083921
2016-02-05 19:30hgbotCheckin
2016-02-05 19:30hgbotNote Added: 0083988
2016-02-05 19:30hgbotStatusnew => resolved
2016-02-05 19:30hgbotResolutionopen => fixed
2016-02-05 19:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b296383fd9f307d2bc4d980edddd58b2c62da796 [^]
2016-02-05 19:31hgbotCheckin
2016-02-05 19:31hgbotNote Added: 0083989
2016-02-05 19:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b296383fd9f307d2bc4d980edddd58b2c62da796 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b4f987dcae8ef3ea097c57505c3cd9aad80c38de [^]
2016-02-08 12:02migueldejuanaReview Assigned To => mtaal
2016-02-08 15:18OrekariaAssigned Tomtaal => migueldejuana
2016-02-08 15:18OrekariaNote Added: 0084004
2016-02-08 15:18OrekariaStatusresolved => new
2016-02-08 15:18OrekariaResolutionfixed => open
2016-02-08 15:18OrekariaStatusnew => scheduled
2016-02-08 15:23OrekariaRelationship addedrelated to 0030897
2016-02-08 16:50OrekariaRelationship addedblocks 0032162
2016-02-09 08:30hgbotCheckin
2016-02-09 08:30hgbotNote Added: 0084024
2016-02-09 08:30hgbotStatusscheduled => resolved
2016-02-09 08:30hgbotResolutionopen => fixed
2016-02-09 08:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b4f987dcae8ef3ea097c57505c3cd9aad80c38de [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0a9d720baf1aa2f0a6395853d52bd897a4e65b8 [^]
2016-02-09 08:31hgbotCheckin
2016-02-09 08:31hgbotNote Added: 0084025
2016-02-09 08:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0a9d720baf1aa2f0a6395853d52bd897a4e65b8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2f792e3dea76183e6f509f7d8e00c245c449c52a [^]
2016-02-17 15:53migueldejuanaNote Added: 0084293
2016-02-17 15:53migueldejuanaStatusresolved => new
2016-02-17 15:53migueldejuanaResolutionfixed => open
2016-02-23 13:13hgbotCheckin
2016-02-23 13:13hgbotNote Added: 0084420
2016-02-23 13:13hgbotStatusnew => resolved
2016-02-23 13:13hgbotResolutionopen => fixed
2016-02-23 13:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2f792e3dea76183e6f509f7d8e00c245c449c52a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3bf463fe8806345b3f83ee212312708d43a27c5b [^]
2016-02-23 13:14hgbotCheckin
2016-02-23 13:14hgbotNote Added: 0084421
2016-02-23 13:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3bf463fe8806345b3f83ee212312708d43a27c5b [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33e591f858d262185703fed85d0db09f0993f683 [^]
2016-02-23 14:07hgbotCheckin
2016-02-23 14:07hgbotNote Added: 0084430
2016-02-23 14:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33e591f858d262185703fed85d0db09f0993f683 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abb22a9df9f9749d3fac366001c472ec155faeff [^]
2016-02-27 08:53mtaalNote Added: 0084574
2016-02-29 11:12mtaalNote Added: 0084586
2016-02-29 11:12mtaalStatusresolved => new
2016-02-29 11:12mtaalResolutionfixed => open
2016-03-01 14:29hgbotCheckin
2016-03-01 14:29hgbotNote Added: 0084623
2016-03-01 14:29hgbotCheckin
2016-03-01 14:29hgbotNote Added: 0084624
2016-03-01 14:29hgbotCheckin
2016-03-01 14:29hgbotNote Added: 0084625
2016-03-01 14:33hgbotCheckin
2016-03-01 14:33hgbotNote Added: 0084626
2016-03-01 14:33hgbotCheckin
2016-03-01 14:33hgbotNote Added: 0084627
2016-03-01 14:33hgbotCheckin
2016-03-01 14:33hgbotNote Added: 0084628
2016-03-01 14:33hgbotCheckin
2016-03-01 14:33hgbotNote Added: 0084629
2016-03-01 15:30migueldejuanaNote Added: 0084631
2016-03-01 17:42hgbotCheckin
2016-03-01 17:42hgbotNote Added: 0084638
2016-03-10 11:06migueldejuanaFile Added: issue31655Core.diff
2016-03-10 11:06migueldejuanaFile Added: issue31655Posterminal.diff
2016-03-10 11:07migueldejuanaNote Added: 0084865
2016-03-14 17:46migueldejuanaFile Deleted: issue31655Core.diff
2016-03-14 17:46migueldejuanaFile Added: issue31655Core.diff
2016-03-16 10:42migueldejuanaFile Deleted: issue31655Posterminal.diff
2016-03-16 10:42migueldejuanaFile Deleted: issue31655Core.diff
2016-03-16 10:43migueldejuanaFile Added: issue31655Core.diff
2016-03-16 10:43migueldejuanaFile Added: issue31655Posterminal.diff
2016-04-22 01:20mtaalAssigned Tomigueldejuana => mtaal
2016-05-01 15:30mtaalNote Added: 0086098
2016-05-01 15:46mtaalNote Edited: 0086098bug_revision_view_page.php?bugnote_id=0086098#r11929
2016-05-02 13:18mtaalFile Deleted: issue31655Core.diff
2016-05-02 13:19mtaalFile Deleted: issue31655Posterminal.diff
2016-05-02 13:19mtaalFile Added: retail-31655.diff
2016-05-02 13:19mtaalFile Added: core-31655.diff
2016-05-02 16:19mtaalReview Assigned Tomtaal => migueldejuana
2016-05-04 00:42mtaalFile Deleted: retail-31655.diff
2016-05-04 00:43mtaalFile Deleted: core-31655.diff
2016-05-04 00:43mtaalFile Added: pi-mobile-test.diff
2016-05-04 00:43mtaalFile Added: retail-v2.diff
2016-05-04 00:43mtaalFile Added: core-v2.diff
2016-05-09 06:32mtaalRelationship addeddepends on 0032899
2016-05-09 06:32mtaalFile Deleted: retail-v2.diff
2016-05-09 06:32mtaalFile Deleted: pi-mobile-test.diff
2016-05-09 06:32mtaalFile Deleted: core-v2.diff
2016-05-09 08:55mtaalFile Added: pi-mobile.diff
2016-05-09 09:09mtaalFile Added: 31655-core-0905.diff
2016-05-09 09:09mtaalFile Added: 31655-retail-0905.diff
2016-05-10 16:01mtaalFile Deleted: 31655-core-0905.diff
2016-05-10 16:01mtaalFile Deleted: pi-mobile.diff
2016-05-10 16:02mtaalFile Deleted: 31655-retail-0905.diff
2016-05-10 16:02mtaalFile Added: core-1005.diff
2016-05-10 16:02mtaalFile Added: retail-1005.diff
2016-05-10 16:02mtaalFile Added: pi-mobile-1005.diff
2016-05-12 01:14mtaalFile Deleted: core-1005.diff
2016-05-12 01:14mtaalFile Deleted: retail-1005.diff
2016-05-12 01:15mtaalFile Deleted: pi-mobile-1005.diff
2016-05-12 01:15mtaalFile Added: retail-1205.diff
2016-05-12 01:15mtaalFile Added: core-1205.diff
2016-05-12 01:15mtaalFile Added: pi-mobile-1205.diff
2016-05-12 11:36mtaalFile Deleted: core-1205.diff
2016-05-12 11:36mtaalFile Added: core-1205.diff
2016-05-14 09:02mtaalFile Deleted: core-1205.diff
2016-05-14 09:02mtaalFile Deleted: retail-1205.diff
2016-05-14 09:02mtaalFile Added: 1405-retail.diff
2016-05-14 09:02mtaalFile Added: 1405-core.diff
2016-05-15 16:48mtaalFile Deleted: pi-mobile-1205.diff
2016-05-15 16:48mtaalFile Deleted: 1405-retail.diff
2016-05-15 16:48mtaalFile Deleted: 1405-core.diff
2016-05-15 16:48mtaalFile Added: 1505-mobile.diff
2016-05-15 16:48mtaalFile Added: 1505-core.diff
2016-05-15 16:48mtaalFile Added: 1505-retail.diff
2016-05-19 00:44hgbotCheckin
2016-05-19 00:44hgbotNote Added: 0086568
2016-05-19 00:52hgbotCheckin
2016-05-19 00:52hgbotNote Added: 0086569
2016-05-19 00:52hgbotStatusnew => resolved
2016-05-19 00:52hgbotResolutionopen => fixed
2016-05-19 00:52hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abb22a9df9f9749d3fac366001c472ec155faeff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7408dbbf02795b2403656fabaf2ec8caaf08135 [^]
2016-05-20 08:54migueldejuanaNote Added: 0086591
2016-05-20 08:54migueldejuanaStatusresolved => closed
2016-05-20 10:06hgbotCheckin
2016-05-20 10:06hgbotNote Added: 0086595
2016-06-16 08:40hgbotCheckin
2016-06-16 08:40hgbotNote Added: 0087325
2019-06-26 09:38joniturralde93Relationship addedcauses 0041178

Notes
(0083921)
hgbot   
2016-02-04 11:26   
Repository: tools/automation/pi-mobile
Changeset: eb20d02a4e51f0a8b80e493b58fd3c6fb6900552
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Feb 04 11:26:23 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/eb20d02a4e51f0a8b80e493b58fd3c6fb6900552 [^]

Related to issue 31655: Process a synchronious order

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I31655_CreateSynchronizedSale.java
---
(0083988)
hgbot   
2016-02-05 19:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b296383fd9f307d2bc4d980edddd58b2c62da796
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 05 19:29:20 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b296383fd9f307d2bc4d980edddd58b2c62da796 [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Create the reference for the OrderLoader preference
- Set it in the model

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0083989)
hgbot   
2016-02-05 19:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b4f987dcae8ef3ea097c57505c3cd9aad80c38de
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Feb 05 19:28:02 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b4f987dcae8ef3ea097c57505c3cd9aad80c38de [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Check if the request is shynchronized and in that case, process the import Entry and send bach the response
- Set error = true to send back the message error
- If it is a synchronized request, show Loading... window in the call and hide in the response
- In the response, show error message if exists and continue executing the callback
- Set in the request if is synched or not depending on the preference defined on the model
- Save the status of the Loading... window and the change time

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0084004)
Orekaria   
2016-02-08 15:18   
Null pointer exception when running the 'I30897_InactiveStorageBinConsidered' test:

java.lang.AssertionError: 1 Errors in the OBPOS_Errors table while importing POS data: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
ORG --> D270A5AC50874F8BA67A88EE977F8E3B
TYPEOFDATA -->
Order
ERROR -->
java.lang.NullPointerException
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.isSynchronizedRequest(DataSynchronizationProcess.java:107)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:282)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:198)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:98)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:41)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:59)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:370)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:292)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
    at java.util.concurrent.FutureTask.run(FutureTask.java:262)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:745)
(0084024)
hgbot   
2016-02-09 08:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f0a9d720baf1aa2f0a6395853d52bd897a4e65b8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 09 08:30:17 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f0a9d720baf1aa2f0a6395853d52bd897a4e65b8 [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Access to isSynchronized from Utils

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/ExternalOrderLoaderErrorHandler.java
---
(0084025)
hgbot   
2016-02-09 08:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2f792e3dea76183e6f509f7d8e00c245c449c52a
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 09 08:29:09 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2f792e3dea76183e6f509f7d8e00c245c449c52a [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Check if request is null
- Put isSynchronized in utils

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M src/org/openbravo/mobile/core/utils/OBMOBCUtils.java
---
(0084293)
migueldejuana   
2016-02-17 15:53   
When an order fails, we must see the sent order in Web POS and be able to fix whatever we need.
(0084420)
hgbot   
2016-02-23 13:13   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3bf463fe8806345b3f83ee212312708d43a27c5b
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 22 16:49:22 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3bf463fe8806345b3f83ee212312708d43a27c5b [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Handle order error in requestrouter

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0084421)
hgbot   
2016-02-23 13:14   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 33e591f858d262185703fed85d0db09f0993f683
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Feb 22 16:53:05 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/33e591f858d262185703fed85d0db09f0993f683 [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Handle order loader error

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
A web/org.openbravo.retail.posterminal/js/data/synchronizedorder.js
---
(0084430)
hgbot   
2016-02-23 14:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: abb22a9df9f9749d3fac366001c472ec155faeff
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Feb 23 14:06:33 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/abb22a9df9f9749d3fac366001c472ec155faeff [^]

Fixed issue 0031655: WebPOS Synchronous transactions

- Update copyright

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0084574)
mtaal   
2016-02-27 08:53   
http://wiki.openbravo.com/wiki/Retail:Configuration_Guide#Synchronized_order [^]
(0084586)
mtaal   
2016-02-29 11:12   
I tested on multi-server with two servers, I forced an exception in the Orderloader if the order has more than 2 lines (central) or more than 1 line (store). In this way I can force errors on different servers.

What I noticed:
- when I force an error on central but not on store I get a message: 'Some records can not be saved'. This eventhough the order was correctly saved on the store server
- in this case the order remains in webpos but with the done button disabled. The order should have gone away as at least one message succeeded.
- when I force an error on both central and store I get a js error (see below). In this case the message should have been displayed, the done button should remain green. Also it should be possible to change the order, add/remove lines. I felt that when I added lines after the message that the order amount was not updated.

TypeError: Cannot read property 'scale' of undefined
    at toNumber (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:10648:14 [^])
    at Object.OB.DEC.toNumber (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:10708:12 [^])
    at null.<anonymous> (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:21407:53 [^])
    at Array.forEach (native)
    at Function._.each._.forEach (http://store1.openbravo.com:8080/openbravo/web/org.openbravo.mobile.core/lib/vendor/underscore-1.3.3.js:76:11 [^])
    at Collection.(anonymous function) [as each] (http://store1.openbravo.com:8080/openbravo/web/org.openbravo.mobile.core/lib/vendor/backbone-0.9.2.js:859:24 [^])
    at Backbone.Model.extend.adjustPrices (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:21363:25 [^])
    at Backbone.Model.extend.prepareToSend (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:21354:12 [^])
    at null.<anonymous> (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:41076:15 [^])
    at Backbone.Events.trigger (http://store1.openbravo.com:8080/openbravo/web/org.openbravo.mobile.core/lib/vendor/backbone-0.9.2.js:163:27 [^]); line: Object.OB.UTIL.showError (http://store1.openbravo.com:8080/openbravo/web/js/gen/b76329f659e11b7887488d647958ba58_WebPOS.js:10373:6 [^]) (*,+)processConsoleLevel @ b76329f659e11b7887488d647958ba58_WebPOS.js:2589
b76329f659e11b7887488d647958ba58_WebPOS.js:10648 Uncaught TypeError: Cannot read property 'scale' of undefined
(0084623)
hgbot   
2016-03-01 14:29   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a9e5e34471e3ffede3f5b1c3cd7909e5e20de1e8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:20:31 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a9e5e34471e3ffede3f5b1c3cd7909e5e20de1e8 [^]

Related to issue 31655: Backout 1903

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0084624)
hgbot   
2016-03-01 14:29   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 927c7ca3e632890655137288d36c0ea836475f9f
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:21:17 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/927c7ca3e632890655137288d36c0ea836475f9f [^]

Related to issue 31655: Backout 1886

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M src/org/openbravo/mobile/core/utils/OBMOBCUtils.java
---
(0084625)
hgbot   
2016-03-01 14:29   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 84c3efd8a98efc47d317d36e71480ed790484f69
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:22:07 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/84c3efd8a98efc47d317d36e71480ed790484f69 [^]

Related to issue 31655: Backout 1883

---
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
---
(0084626)
hgbot   
2016-03-01 14:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b4ec1d5fc24f3e2515fc500bbcdb19f57461db69
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:17:59 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b4ec1d5fc24f3e2515fc500bbcdb19f57461db69 [^]

Related to issue 31655: Backout 6105

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0084627)
hgbot   
2016-03-01 14:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 23f9bbcc549bbdbd62fb15c78f15193cb3f322af
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:18:06 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/23f9bbcc549bbdbd62fb15c78f15193cb3f322af [^]

Related to issue 31655: Backout 6104

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
R web/org.openbravo.retail.posterminal/js/data/synchronizedorder.js
---
(0084628)
hgbot   
2016-03-01 14:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1c41944e99ea95a25e1b604516cae76e750099d0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:18:39 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1c41944e99ea95a25e1b604516cae76e750099d0 [^]

Related to issue 31655: Backout 6059

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
M src/org/openbravo/retail/posterminal/ExternalOrderLoaderErrorHandler.java
---
(0084629)
hgbot   
2016-03-01 14:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0c0c7e2ec600e185f724b57454a8a2cef1cdd458
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Mar 01 14:19:08 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c0c7e2ec600e185f724b57454a8a2cef1cdd458 [^]

Related to issue 31655: Backout 6049

---
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
---
(0084631)
migueldejuana   
2016-03-01 15:30   
Backout: This change has been postponed to the next release to do a more generic solution.
(0084638)
hgbot   
2016-03-01 17:42   
Repository: tools/automation/pi-mobile
Changeset: b20fe3e9a091daf579693e20d484d1b130e66cbf
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Mar 01 17:19:06 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b20fe3e9a091daf579693e20d484d1b130e66cbf [^]

Related to issue 31655: Link the 'I31655_CreateSynchronizedSale' to its issue status

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I31655_CreateSynchronizedSale.java
---
(0084865)
migueldejuana   
2016-03-10 11:07   
Attached diffs with the solution.
(0086098)
mtaal   
2016-05-01 15:30   
(edited on: 2016-05-01 15:46)
Documentation:
http://wiki.openbravo.com/wiki/Retail:Store_Server#Synchronized_Transactions [^]

All previous commits (except test) have been backed out. Only new commits after this comment apply to this issue.

Only testcase is retained from previous commits and adapted:
https://code.openbravo.com/tools/automation/pi-mobile/file/b20fe3e9a091/src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I31655_CreateSynchronizedSale.java [^]
(0086568)
hgbot   
2016-05-19 00:44   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6a10c0a2dd157a64ab121e6b6d95ffd9c462f700
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu May 19 00:43:38 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6a10c0a2dd157a64ab121e6b6d95ffd9c462f700 [^]

Related to issue 31655: WebPOS Synchronous transactions
Main synchronized transaction behavior, also added preferences for offline wait time

Summary of changes:
src-db changes: new title/texts for popup, new import entry type, new preferences for offline wait time and synchronized mode, new service definition
DataSynchronizationProcess.java: in case of synchronized mode: prevent commit and always return error/exception no specific error handling
MobileService.java: move service processing to separate class MobileServiceProcessor
MobileServiceProcessor.java: contains the code which was previously in MobileService, so that it can be called from other classes, set synchronized mode in class and pass on to process class
SecuredJSONProcess.java: add synchronized and jsonresult members in this class/level, is really used by subclasses, some changes to prevent NPE if class is called through MobileServiceProcessor, which will always call execSecure
MobileMainServerCheck.java: implement preference for offline wait time
MobileServerController.java: added checks for more defensive coding
MobileServerUtils.java: new utils methods
SynchronizedServerProcessCaller.java: main new class for synchronized processing of synced data, unpacks the json to call individual services.
ob-dal.js: contain code to create and restore in-memory datadump/backup
ob-commonbuttons.js: add a possibility to hide the close button, for unhideable modal confirmation boxes
ob-datasource.js: handle one more way that error/exception is returned in json, automatically do all transaction services synchronized (if synchronized mode is enabled)
ob-requestrouter.js: added utility method
ob-terminal-model.js: main flow change to collect all data which needs to be synced and send them as one request to server using new service
ob-utilitiesui.js: add possibility to create non-closeable modal, return the model so it can be used for show/hide by caller

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/mobile/core/process/DataSynchronizationProcess.java
M src/org/openbravo/mobile/core/process/MobileService.java
M src/org/openbravo/mobile/core/process/SecuredJSONProcess.java
M web/org.openbravo.mobile.core/source/component/ob-commonbuttons.js
M web/org.openbravo.mobile.core/source/component/ob-menu.js
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/data/ob-datasource.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
M web/org.openbravo.mobile.core/source/utils/ob-utilities.js
M web/org.openbravo.mobile.core/source/utils/ob-utilitiesui.js
A src/org/openbravo/mobile/core/process/MobileServiceProcessor.java
A src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java
---
(0086569)
hgbot   
2016-05-19 00:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e7408dbbf02795b2403656fabaf2ec8caaf08135
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu May 19 00:51:42 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7408dbbf02795b2403656fabaf2ec8caaf08135 [^]

Fixes issue 31655: WebPOS Synchronous transactions
Changes to the UI to navigate UI view only after succesfull transaction on server.

Summary of changes:
LoginUtilsServlet.java: moved code to utils class
CashupSynchronized: service which is called to load cashup information, if there are errors in the queue will read the cashup info from the central server
POSImportEntryProcessor.java: added OBMOBC_SynchronizedData as import entry type
cashmgmt-model.js: if transaction fails then remove cash management entries, user has to re-enter them, call postsync actions in success callback
cashup-model.js: do a real error callback, when the server returns an error
closecash.js: when in synchronized mode there is an error then don't show error message, it is already displayed
datacustomeraddrsave.js: move code to global function which can be called from UI, keep trigger for backward compat
datacustomersave.js: move code to global function which can be called from UI, keep trigger for backward compat
dataordersave.js: in synchronized mode only clean the ui if success return from the server, some code is maintained to retain same UI behavior in case of non-synchronized mode
login-model.js: specify which models are checkpointed
bplocation.js: call global function to save location instead of calling trigger
businesspartner.js: call global function to save bp instead of using trigger
pointofsale-model.js: for multi-order wait with printing until success callback
customeraddress/components/sharedcomponents.js: move the code which changes UI to a callback, called when server succeeds
customers/components/sharedcomponents.js: move the code which changes UI to a callback, called when server succeeds
cashupreportutils.js: in case of synchronized mode, reread the cashup from the server

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
M web/org.openbravo.retail.posterminal/js/closecash/view/closecash.js
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/bplocation.js
M web/org.openbravo.retail.posterminal/js/model/businesspartner.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
A src/org/openbravo/retail/posterminal/master/CashupSynchronized.java
---
(0086591)
migueldejuana   
2016-05-20 08:54   
Tested and reviewed
(0086595)
hgbot   
2016-05-20 10:06   
Repository: tools/automation/pi-mobile
Changeset: 54c2e66c65f5411027c0d475a91517043696bdff
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri May 20 10:06:16 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/54c2e66c65f5411027c0d475a91517043696bdff [^]

Related to issue 31655 Synchronized Transactions
Remove out dated test

---
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I31655_CreateSynchronizedSale.java
---
(0087325)
hgbot   
2016-06-16 08:40   
Repository: tools/automation/pi-mobile
Changeset: b25342989139431b916e3835b7c68ed9feb10616
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jun 16 08:40:05 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b25342989139431b916e3835b7c68ed9feb10616 [^]

Related to issue 31655: WebPOS Synchronous transactions
Added synchronized transaction test cases

---
M src-test/org/openbravo/test/mobile/common/junit/toolbox/OBWildcardPatternSuite.java
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/BaseSynchronizedTransactionTest.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/SynchronizedCashupWithDeposit.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/SynchronizedCashupWithSaleAndReturn.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I25623_VerifiedReturnsAvoidMoreThanOrdered.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I27476_SameDocumentNoAfterPayAndReload.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I27615_PartiallyPaidLayaway.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I30412_QuotationsAndPromotions.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I31323_LayawayPayOpenTicket.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I31462_VoidLayaway.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_I31892_VoidLayawayAndCashUp.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/Synchronized_RejectQuotations.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/TestNonSynchronizedSale.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/TestSynchronizedSaleWithError.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/synchronizedtransactions/TestSynchronizedTransaction.java
---