Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031650Retail ModulesWeb POSpublic2015-12-07 09:212015-12-29 14:09
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q1Fixed in VersionRR16Q1 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031650: Change POSImportEntryProcessor to use Business Event Handler concept
DescriptionThe POSImportEntryProcessor class [1] uses the concept of a ImportEntryPreprocessor to set the pos terminal. But it is better to use an entity event listener as this covers all the cases when a new import entry is created through code.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/aadb5f0c8865/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java [^]

[2]
http://wiki.openbravo.com/wiki/How_to_implement_a_business_event_handler [^]
Steps To ReproduceSee the code, change to use an entity event listener
Proposed SolutionNote, the code is touched/used by all the retail test cases. Any change here will be thoroughly tested through automated tests.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-12-07 09:21mtaalNew Issue
2015-12-07 09:21mtaalAssigned To => mtaal
2015-12-07 09:21mtaalOBNetwork customer => No
2015-12-07 09:21mtaalTriggers an Emergency Pack => No
2015-12-07 11:22mtaalReview Assigned To => marvintm
2015-12-07 11:22hgbotCheckin
2015-12-07 11:22hgbotNote Added: 0082586
2015-12-07 11:22hgbotStatusnew => resolved
2015-12-07 11:22hgbotResolutionopen => fixed
2015-12-07 11:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bea678f20cf910f8895ff807083f070751fdad7 [^]
2015-12-24 14:22mtaalNote Added: 0082994
2015-12-29 12:27OrekariaReview Assigned Tomarvintm => Orekaria
2015-12-29 12:32OrekariaStatusresolved => new
2015-12-29 12:32OrekariaResolutionfixed => open
2015-12-29 12:32OrekariaStatusnew => scheduled
2015-12-29 14:09OrekariaStatusscheduled => resolved
2015-12-29 14:09OrekariaFixed in Version => RR16Q1
2015-12-29 14:09OrekariaResolutionopen => fixed
2015-12-29 14:09OrekariaStatusresolved => closed

Notes
(0082586)
hgbot   
2015-12-07 11:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0bea678f20cf910f8895ff807083f070751fdad7
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Dec 07 09:41:12 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0bea678f20cf910f8895ff807083f070751fdad7 [^]

Fixes issue 31650: Change POSImportEntryProcessor to use Business Event Handler concept
use business event handler instead of pre-processor as it covers more cases
when persisting new import entries

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0082994)
mtaal   
2015-12-24 14:22   
Api change noted, approved and recorded here:
http://wiki.openbravo.com/wiki/Retail:API_changes#PI [^]